Page MenuHomePhabricator

[BUG] "Add X articles to reading list" cells not respecting list lang direction when device lang is RTL
Closed, ResolvedPublic

Description

How many times were you able to reproduce it?

All

Prerequisites

  1. iOS 10.3.1
  2. ensure there's at least one reading list with articles having images and one reading list with no articles (so we can proof both image and image-less LTR cells)
  3. now switch DEVICE lang to Hebrew (or use Xcode WikipediaRTL scheme)
  4. add two reading lists with Hebrew keyboard
  5. add at least one article with an image to one of the Hebrew lists you just created (so we can proof both image and image-less RTL cells)

Steps to reproduce

  1. Double-check that device lang is Hebrew (from prerequisite steps)
  2. Go to Explore
  3. Tap "Save for later" for any Explore article (the button is in Hebrew)
  4. When the reading list hint appears at the bottom of the screen tap it

Expected results

Cells should layout correctly for respective list title language direction - ie for the Hebrew cells they should have thumbnail on the left with text on the right, for English thumbnail should be on right with text on left

Actual results

Screen Shot 2018-04-17 at 4.22.22 PM.png (1×862 px, 120 KB)

Environments observed

App version:
5.8
OS versions:
10.3.1 (Note - ensure any fixes also work with iOS 11)
Device model:
All
Device language:
Hebrew/English

Event Timeline

cmadeo subscribed.

Simulator Screen Shot - iPhone 8 - 2018-04-30 at 10.57.26.png (1×750 px, 80 KB)

@NHarateh_WMF This is what I'm seeing on the new build. Seems like the LTR langs are flipped?

@cmadeo if the device's language is RTL, reading list cells will also be RTL - it's because unlike an article, a reading list has no language so we need to rely on the device's language to decide if reading list cells should be LFT or RTL

@NHarateh_WMF Ah, makes sense! Looks good to me then! Thanks for the clarification!