Page MenuHomePhabricator

Improvements to Wikistats2 chart popups
Closed, ResolvedPublic13 Estimated Story Points

Description

From @Nuria :

  • Overlay with point values keeps on displaying even when cursor is no longer on top of graph. It should disappear. F17054773

Also:

  • Unify the aspect of popups for all chart types: map, line, bars
  • Bar chart popup does not work visually for very short bars, is lost in the white of teh background, and the arrow is not visible.
  • Line chart popup blocks visibility of lines: we should make line chart popup dynamic

Event Timeline

Screen Shot 2018-04-17 at 4.34.37 PM.png (1×1 px, 210 KB)

Overlay with point values keeps on displaying even when cursor is no longer on top of graph. It should disappear.

fdans triaged this task as Medium priority.Apr 19 2018, 4:44 PM
fdans moved this task from Incoming to Mentoring on the Analytics board.
Nuria raised the priority of this task from Medium to High.Apr 19 2018, 6:19 PM

This happens in both bar-chart and line-chart.

mforns renamed this task from When cursor is out of graph overlay should not display to Improvements to Wikistats2 chart popups.Jul 5 2018, 2:40 PM
mforns updated the task description. (Show Details)
  • have the popup be the same component for all charts, that receives the data.

libraries that can help:

sahil505 added a project: Analytics-Kanban.
sahil505 set the point value for this task to 13.
sahil505 updated the task description. (Show Details)

Change 448852 had a related patch set uploaded (by Sahil505; owner: Sahil505):
[analytics/wikistats2@master] Hide overlay when the cursor is no longer on top of graph

https://gerrit.wikimedia.org/r/448852

Change 449029 had a related patch set uploaded (by Sahil505; owner: Sahil505):
[analytics/wikistats2@master] Made Bar-chart popup dynamic

https://gerrit.wikimedia.org/r/449029

Change 449029 merged by Milimetric:
[analytics/wikistats2@master] Made Bar-chart popup dynamic

https://gerrit.wikimedia.org/r/449029

Change 448852 abandoned by Mforns:
Hide overlay when the cursor is no longer on top of graph

Reason:
After refactors, this code is obsolete, sorry.

https://gerrit.wikimedia.org/r/448852

Aklapper removed a project: Patch-For-Review.

All related patches in Gerrit have been merged or abandoned. Assuming that this task can be resolved as its parent task T189210 is also resolved.
Please reopen if I misunderstood.