Page MenuHomePhabricator

Popups Cucumber tests fails quietly with "undefined step"
Closed, ResolvedPublic


This task covers the work to fix the missing steps identified in the mwext-mw-selenium-jessie job:

13:36:23     And the page "Selenium diff test" exists and has at least "51" edits # features/step_definitions/create_page_api_steps.rb:1
13:36:23       Undefined step: "the page "Selenium diff test" exists" (Cucumber::Undefined)
13:36:23       ./features/step_definitions/create_page_api_steps.rb:3:in `/^the page "(.*?)" exists and has at least "(\d+)" edits$/'
13:36:23       features/special_history_nojs.feature:7:in `And the page "Selenium diff test" exists and has at least "51" edits'


14:33:34   @integration
14:33:34   Scenario: Bug: T129600                                            # features/switch_views.feature:18
14:33:34     Given I am on the desktop site                                  # features/switch_views.feature:19
14:33:34 You can implement step definitions for undefined steps with these snippets:
14:33:34 Given(/^I am on the desktop site$/) do
14:33:34   pending # express the regexp above with the code you wish you had
14:33:34 end

This job should pass gracefully without skipping any tests. Ideally, skipping tests would cause the build to fail.

Event Timeline

Change 427384 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/extensions/MobileFrontend@master] Fix: add missing Cucumber step

Change 427384 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Fix: add missing Cucumber step

Niedzielski assigned this task to Jdrewniak.

The issue is fixed although the infrastructure could still be improved to detect this problem in the future.