Maniphest T192467

Remove unused configuration global $wgSiteSupportPage
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Mainframe98
	Apr 18 2018, 3:59 PM

Description

This configuration global is unused in MediaWiki, and does not appear to have any usages in any extensions or skins.
The documentation page states that

This has been superseded in later versions by the $wgNavigationLinks setting and MediaWiki:Sidebar

but it was never deprecated. Note that $wgNavigationLinks has been removed in MediaWiki 1.5.0, which means that this setting is unused for over a decade.

Considering its lack of usage, I think we can forego a deprecation period as there are no known usages.

Usage search: https://codesearch.wmflabs.org/search/?q=SiteSupportPage&i=nope&files=&repos=

Actionables

Remove from DefaultSettings.php
Remove from rOMWC InitialiseSettings.php
Mark as removed on it's documentation page

Details

	Subject	Repo	Branch	Lines +/-
	Don't try to set wgSiteSupportPage, ignored for a decade	operations/mediawiki-config	master	+0 -8
	Remove $wgSiteSupportPage	mediawiki/core	master	+1 -5

Customize query in gerrit

Event Timeline

Mainframe98 created this task.Apr 18 2018, 3:59 PM

Mainframe98 updated the task description. (Show Details)Apr 18 2018, 4:11 PM

Change 427428 had a related patch set uploaded (by Mainframe98; owner: Mainframe98):
[mediawiki/core@master] Remove $wgSiteSupportPage

https://gerrit.wikimedia.org/r/427428

gerritbot added a project: Patch-For-Review.Apr 18 2018, 4:26 PM

Krinkle added a project: MW-1.31-release.Apr 18 2018, 4:29 PM

Mainframe98 moved this task from Unsorted to Needs removal on the Technical-Debt board.Apr 18 2018, 5:07 PM

Krinkle moved this task from Backlog to Core on the MW-1.31-release board.Apr 18 2018, 6:08 PM

Change 427428 merged by jenkins-bot:
[mediawiki/core@master] Remove $wgSiteSupportPage

https://gerrit.wikimedia.org/r/427428

Restricted Application added a project: Product-Analytics. · View Herald TranscriptApr 18 2018, 11:32 PM

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)).Apr 19 2018, 12:01 AM

• Phabricator_maintenance removed a project: Product-Analytics.Apr 19 2018, 12:19 AM

@Krinkle You've added the MW-1.31-release project, so does that mean this should also be back-ported to 1.31?

Mainframe98 updated the task description. (Show Details)Apr 19 2018, 11:48 AM

I was planning to, but there's not much value in doing so at this point, and we've already merged the release notes.

Then, all that's left is removing from InitialiseSettings.php.

Change 428365 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[operations/mediawiki-config@master] Don't try to set wgSiteSupportPage, ignored for a decade

https://gerrit.wikimedia.org/r/428365

gerritbot added a project: Patch-For-Review.Apr 23 2018, 4:06 PM

Change 428365 merged by jenkins-bot:
[operations/mediawiki-config@master] Don't try to set wgSiteSupportPage, ignored for a decade

https://gerrit.wikimedia.org/r/428365

Jdforrester-WMF closed this task as Resolved.Apr 30 2018, 11:08 PM

Jdforrester-WMF removed a project: Patch-For-Review.

Jdforrester-WMF updated the task description. (Show Details)

Krinkle removed a project: MediaWiki-Configuration.May 1 2018, 3:01 AM