Page MenuHomePhabricator

Allow putting OOUI toolbar menus into an overlay
Closed, ResolvedPublic

Description

To allow toolbar menus to escape confines of stacking contexts and avoid overlap issues like this:

…we have to allow them to be put into an overlay.

Also tagging VE because its floating toolbar probably complicates this. I have to find out if we need to support a combination of both these features.

Event Timeline

matmarex triaged this task as Normal priority.Apr 18 2018, 9:51 PM
matmarex created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 18 2018, 9:51 PM
matmarex raised the priority of this task from Normal to High.Apr 18 2018, 9:51 PM
matmarex edited projects, added VisualEditor (Current work); removed VisualEditor.

Change 428136 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[oojs/ui@master] Toolbar: Put all popups (from PopupToolGroup and PopupTool) into an overlay

https://gerrit.wikimedia.org/r/428136

Jdforrester-WMF moved this task from Backlog to Reviewing on the OOUI board.Apr 24 2018, 3:44 PM

@matmarex The changed behavior is confusing. Sure, stacking context might get unwanted results like the one in the screenshot, but are we sure about this?!

There seems to be a lot of weird behaviour to arise from this right now

@Volker_E Looks like you were testing OOUI with the broken 'overflow: hidden' change that was merged and reverted today (https://gerrit.wikimedia.org/r/#/c/428616/) – try again on master, the menus should not be cut off like that.

@matmarex Glad, that it was that simple.

@Ryasmeen We need to make sure, that this works across themes, in products like Flow and CX2.

Volker_E moved this task from Reviewing to OOUI-0.26.5 on the OOUI board.Apr 24 2018, 10:57 PM
Volker_E edited projects, added OOUI (OOUI-0.26.5); removed OOUI.

Change 428136 merged by jenkins-bot:
[oojs/ui@master] Toolbar: Put all popups (from PopupToolGroup and PopupTool) into an overlay

https://gerrit.wikimedia.org/r/428136

Volker_E closed this task as Resolved.Apr 24 2018, 11:08 PM
Volker_E removed a project: Patch-For-Review.
Volker_E removed a subscriber: gerritbot.

Putting this on resolved, any issues found should be filed as follow-ups.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptApr 24 2018, 11:09 PM