| matmarex | |
| Apr 18 2018, 9:51 PM |
| F17292581: image.png | |
| Apr 24 2018, 9:46 PM |
| F17292567: T192505 Toolbar into overlay - screencast 2018-04-24.mp4 | |
| Apr 24 2018, 9:46 PM |
| F16902422: Screenshot from 2018-04-10 12-20-10.png | |
| Apr 18 2018, 9:51 PM |
To allow toolbar menus to escape confines of stacking contexts and avoid overlap issues like this:
…we have to allow them to be put into an overlay.
Also tagging VE because its floating toolbar probably complicates this. I have to find out if we need to support a combination of both these features.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Toolbar: Put all popups (from PopupToolGroup and PopupTool) into an overlay | oojs/ui | master | +158 -152 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T174144 Improve Flow input tools (toolbars, shortcuts...) | |||
| Open | None | T93243 Flow's VE toolbar v2 | |||
| Resolved | matmarex | T192505 Allow putting OOUI toolbar menus into an overlay |
Change 428136 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[oojs/ui@master] Toolbar: Put all popups (from PopupToolGroup and PopupTool) into an overlay
@matmarex The changed behavior is confusing. Sure, stacking context might get unwanted results like the one in the screenshot, but are we sure about this?!
There seems to be a lot of weird behaviour to arise from this right now
@Volker_E Looks like you were testing OOUI with the broken 'overflow: hidden' change that was merged and reverted today (https://gerrit.wikimedia.org/r/#/c/428616/) – try again on master, the menus should not be cut off like that.
@Ryasmeen We need to make sure, that this works across themes, in products like Flow and CX2.
Change 428136 merged by jenkins-bot:
[oojs/ui@master] Toolbar: Put all popups (from PopupToolGroup and PopupTool) into an overlay