Maniphest T192625

[BUG] Fix article Read more "Save for later" button tap causing "Find in page" bar to appear
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Mhurd
	Apr 20 2018, 1:46 AM

Tags

Referenced Files

	F17153502: 9.mov.gif
	Apr 20 2018, 1:46 AM

Subscribers

Description

How many times were you able to reproduce it?

Every time

Steps to reproduce

Load any article
Scroll to Read more section at bottom of article
Tap any "Save for later" button

Expected results

Article is saved

Actual results

Article is saved but the Find in page search bar appears at the very bottom of the page

Screenshots

Tap image for animation:

9.mov.gif (720×396 px, 923 KB)

Environments observed

App version:
5.8
OS versions:
All
Device model:
All
Device language:
All

Related Objects

Mentioned In: rAPIOSb23c50f995cb: Merge pull request #2241 from wikimedia/fix/read-more-regression/T192625

Event Timeline

Mhurd created this task.Apr 20 2018, 1:46 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 20 2018, 1:46 AM

https://github.com/wikimedia/wikipedia-ios/pull/2241

• NHarateh_WMF mentioned this in rAPIOSb23c50f995cb: Merge pull request #2241 from wikimedia/fix/read-more-regression/T192625.Apr 20 2018, 8:08 PM

• NHarateh_WMF edited projects, added iOS-app-v5.8.1-Manatee-On-A-Scootscoot; removed iOS-app-v5.8.0-Manatee-On-A-Skateboard.Apr 23 2018, 12:44 PM

• NHarateh_WMF moved this task from Tasks from Product Backlog to Waiting for Build on the iOS-app-v5.8.1-Manatee-On-A-Scootscoot board.

LGoto moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.Apr 23 2018, 8:49 PM

• NHarateh_WMF moved this task from Waiting for Build to Needs Design Review on the iOS-app-v5.8.1-Manatee-On-A-Scootscoot board.Apr 24 2018, 5:37 PM

Fixed for me! Thanks!

Looks fixed on 5.8.1 (1400)

good catch @Mhurd

• JMinor closed this task as Resolved.May 8 2018, 2:34 AM