Page MenuHomePhabricator

Gerrit's New UI reply dialog ignores Ctrl-Z
Closed, ResolvedPublic

Description

Upstream https://bugs.chromium.org/p/gerrit/issues/detail?id=8812


To reproduce:

  1. Use Gerrit new UI (polygerrit)
  2. Open a change and click "Reply".
  3. Type foo bar.
  4. Select the a in bar
  5. Type z. The text now reads "foo bzr"
  6. Type + Z, which in normal text areas is "undo"
  7. Observe that the change was not undone: the text is still foo bzr

Expected behavior:
In step 6, the text would again read "foo bar".

Additional notes:

This is with the new Gerrit UI (polygerrit), the old UI (GWT based) works as expected.

You could then continue by pressing + + Z (or + Y, at least in my version of Firefox) which would redo the change to produce foo bzr.

You should also be able to type a long paragraph, making many edits, and use + Z and + + Z to repeatedly undo and redo, as is the case in a standard textarea.

For whatever reason this bug does not occur when making an inline comment, only when using the reply popup.

Event Timeline

That is still a valid bug in Gerrit 3.2.7.

Still happening in Gerrit 3.3.6. It might be due to some Chrome specific code being used that prevented another feature from working properly on Firefox ( https://gerrit-review.googlesource.com/c/gerrit/+/290135 )

I have replied on upstream task.

Still happening on our Gerrit 3.4.6.

It works with 3.7.0-rc1 which I have checked on upstream instance https://gerrit-review.googlesource.com/

Maybe that was addressed as part of 3.5.0 change https://gerrit-review.googlesource.com/c/gerrit/+/321425 which seems to overhaul how keyboard shortcuts are managed.

Still happening on our Gerrit 3.5.4.

Still happening with Gerrit 3.6.8 and Firefox 115.

hashar claimed this task.

That finally got fixed in Gerrit 3.7.6 (I have tested with Firefox 115).