Page MenuHomePhabricator

Gerrit's New UI reply dialog ignores Ctrl-Z
Open, Needs TriagePublic

Description

To reproduce:

  1. Use Gerrit new UI (polygerrit)
  2. Open a change and click "Reply".
  3. Type foo bar.
  4. Select the a in bar
  5. Type z. The text now reads "foo bzr"
  6. Type Ctrl + Z, which in normal text areas is "undo"
  7. Observe that the change was not undone: the text is still foo bzr

Expected behavior:
In step 6, the text would again read "foo bar".

Additional notes:

This is with the new Gerrit UI (polygerrit), the old UI (GWT based) works as expected.

You could then continue by pressing Ctrl + + Z (or Ctrl + Y, at least in my version of Firefox) which would redo the change to produce foo bzr.

You should also be able to type a long paragraph, making many edits, and use Ctrl + Z and Ctrl + + Z to repeatedly undo and redo, as is the case in a standard textarea.

For whatever reason this bug does not occur when making an inline comment, only when using the reply popup.

Event Timeline

Anomie created this task.Apr 20 2018, 4:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 20 2018, 4:27 PM
Paladox moved this task from Backlog to Reported Upstream on the Upstream board.Apr 20 2018, 4:31 PM
Paladox moved this task from Bugs & stuff to PolyGerrit on the Gerrit board.Apr 21 2018, 4:36 PM

Ctrl-z works for me.

Anomie added a comment.Mar 9 2019, 2:29 PM

Still not working for me in Firefox 65 at https://gerrit.wikimedia.org/

hashar updated the task description. (Show Details)Mar 11 2019, 9:30 AM