Page MenuHomePhabricator

Remove ve.Range#clone & ve.dm.Selection#clone
Closed, ResolvedPublic

Description

Both these classes are supposed to be immutable - so we should never need to clone them.

At worst there are some lazily evaluated properties (e.g. TableSelection#getTableNode)

Event Timeline

Esanders created this task.Apr 20 2018, 4:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 20 2018, 4:41 PM

Change 427932 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Deprecated ve.Range#clone and ve.dm.Selection#clone

https://gerrit.wikimedia.org/r/427932

Change 427934 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] [BREAKING CHANGE] Remove ve.Range#clone and ve.dm.Selection#clone

https://gerrit.wikimedia.org/r/427934

Change 427932 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] [DEPRECATING CHANGE] Deprecate ve.Range#clone and ve.dm.Selection#clone

https://gerrit.wikimedia.org/r/427932

Change 429227 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (174890b5e)

https://gerrit.wikimedia.org/r/429227

Change 429227 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (174890b5e)

https://gerrit.wikimedia.org/r/429227

Change 427934 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] [BREAKING CHANGE] Remove ve.Range#clone and ve.dm.Selection#clone

https://gerrit.wikimedia.org/r/427934

Change 429526 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (e673ad6de)

https://gerrit.wikimedia.org/r/429526

Change 429526 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (e673ad6de)

https://gerrit.wikimedia.org/r/429526

Deskana closed this task as Resolved.May 14 2018, 1:04 PM