Page MenuHomePhabricator
Create Task
Maniphest T192671

Remove ve.Range#clone & ve.dm.Selection#clone
Closed, ResolvedPublic
Actions

Description

Both these classes are supposed to be immutable - so we should never need to clone them.

At worst there are some lazily evaluated properties (e.g. TableSelection#getTableNode)

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (e673ad6de)mediawiki/extensions/VisualEditormaster+1 -1
[BREAKING CHANGE] Remove ve.Range#clone and ve.dm.Selection#cloneVisualEditor/VisualEditormaster+12 -43
Update VE core submodule to master (174890b5e)mediawiki/extensions/VisualEditormaster+1 -1
[DEPRECATING CHANGE] Deprecate ve.Range#clone and ve.dm.Selection#cloneVisualEditor/VisualEditormaster+18 -31
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Apr 20 2018, 4:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 20 2018, 4:41 PM
gerritbot subscribed.Apr 20 2018, 5:00 PM

Change 427932 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Deprecated ve.Range#clone and ve.dm.Selection#clone

https://gerrit.wikimedia.org/r/427932

gerritbot added a project: Patch-For-Review.Apr 20 2018, 5:00 PM
gerritbot added a comment.Apr 20 2018, 5:20 PM

Change 427934 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] [BREAKING CHANGE] Remove ve.Range#clone and ve.dm.Selection#clone

https://gerrit.wikimedia.org/r/427934

Jdforrester-WMF edited projects, added VisualEditor (Current work), Technical-Debt; removed VisualEditor.Apr 26 2018, 3:30 PM
gerritbot added a comment.Apr 26 2018, 3:44 PM

Change 427932 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] [DEPRECATING CHANGE] Deprecate ve.Range#clone and ve.dm.Selection#clone

https://gerrit.wikimedia.org/r/427932

gerritbot added a comment.Apr 26 2018, 3:58 PM

Change 429227 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (174890b5e)

https://gerrit.wikimedia.org/r/429227

gerritbot added a comment.Apr 26 2018, 4:36 PM

Change 429227 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (174890b5e)

https://gerrit.wikimedia.org/r/429227

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)).Apr 26 2018, 5:00 PM
gerritbot added a comment.Apr 27 2018, 9:39 PM

Change 427934 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] [BREAKING CHANGE] Remove ve.Range#clone and ve.dm.Selection#clone

https://gerrit.wikimedia.org/r/427934

gerritbot added a comment.Apr 27 2018, 9:48 PM

Change 429526 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (e673ad6de)

https://gerrit.wikimedia.org/r/429526

Jdforrester-WMF assigned this task to Esanders.Apr 27 2018, 10:39 PM
Jdforrester-WMF moved this task from Incoming to Code review on the VisualEditor (Current work) board.
gerritbot added a comment.Apr 29 2018, 1:13 PM

Change 429526 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (e673ad6de)

https://gerrit.wikimedia.org/r/429526

Jdforrester-WMF moved this task from Code review to Product owner review on the VisualEditor (Current work) board.Apr 30 2018, 5:14 PM
• Deskana closed this task as Resolved.May 14 2018, 1:04 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL