Page MenuHomePhabricator

Rename pywikipedia to pywikibot on Toolforge
Closed, ResolvedPublic

Description

The name pywikipedia is a really historic one for pywikibot, this should be renamed

Event Timeline

Do you refer to the /shared/pywikipedia/ directory that hosts the shared nightly clone of the repo?

If such a thing exist (not a UNIX guy, sorry), maybe also leave a redirect when moving the stuff so things don't suddenly break? Thanks.

I don't agree on renaming, that would break it for the users who use it. It's just a bunch of symlinks to /data/project/pywikibot/ anyway. What I would propose:

  • Change owner to tools.pywikibot for /shared/pywikipedia/ (now a big mix)
  • Link /shared/pywikibot to /data/project/pywikibot/public_html/core/
  • Leave a readme in /shared/pywikipedia/ to say it's deprecated and people should use /shared/pywikibot/

@valhallasw would you mind doing this bit of house keeping?

Mentioned in SAL (#wikimedia-cloud) [2018-04-23T14:41:48Z] <zhuyifei1999_> chown tools.pywikibot:tools.pywikibot /shared/pywikipedia/ Prior owner: tools.russbot:project-tools T192732

  • Change owner to tools.pywikibot for /shared/pywikipedia/ (now a big mix)

Done. I think the other two should be better done by those who maintain tools.pywikibot :)

I've symlinked /shared/pywikibot/core to /data/project/pywikibot/public_html/core, as we might want to add other linked folders at some point as well.

Anything else to do here?

Probably not. We could make Toolforge somehow warn pywikipedia here is obsolete and mark this task as stalled until the time to completely remove pywikipedia folders will come?

We could make Toolforge somehow warn pywikipedia here is obsolete

There's a README inside:

06:08:52 0 ✓ zhuyifei1999@tools-bastion-02: ~$ cat /shared/pywikipedia/README.md 
This directory is deprecated; please use /shared/pywikibot instead.

There is, but...is core_old updated as well? If so, it may be useful for some people as well.

There is, but...is core_old updated as well?

No, the directory seems to be from 2013 and still uses svn.

10:32:30 0 ✓ zhuyifei1999@tools-bastion-03: /shared/pywikipedia/core_old$ ls -al
total 116
drwxrwsr-x 7 tools.russbot   project-tools    4096 Dec  3  2013 .
drwxr-sr-x 4 tools.pywikibot tools.pywikibot  4096 Apr 23 16:59 ..
-rw-rw-r-- 1 tools.russbot   project-tools    1117 Oct 11  2013 CREDITS
drwxrwsr-x 3 tools.russbot   project-tools    4096 Oct 12  2013 externals
-rw-r--r-- 1 tools.russbot   project-tools   11837 Sep 28  2013 ez_setup.py
-rw-r--r-- 1 tools.russbot   project-tools   11989 Nov 11  2013 generate_user_files.py
-rw-rw-r-- 1 tools.russbot   project-tools      11 Jul 29  2013 .gitattributes
-rw-r--r-- 1 tools.russbot   project-tools     100 Sep  8  2013 .gitignore
-rw-r--r-- 1 tools.russbot   project-tools     289 Nov 26  2013 .gitmodules
-rw-rw-r-- 1 tools.russbot   project-tools     110 Jul 29  2013 .gitreview
-rw-r--r-- 1 tools.russbot   project-tools     809 Nov 11  2013 INSTALL
-rw-r--r-- 1 tools.russbot   project-tools    1297 Nov 11  2013 LICENSE
-rw-r--r-- 1 tools.russbot   project-tools     147 Oct 25  2013 .pep8
-rw-r--r-- 1 tools.russbot   project-tools    3904 Dec  3  2013 pwb.py
drwxrwsr-x 8 tools.russbot   project-tools    4096 Nov 18  2013 pywikibot
-rw-r--r-- 1 tools.russbot   project-tools    5799 Nov 11  2013 README-conversion.txt
-rw-r--r-- 1 tools.russbot   project-tools    1226 Aug 31  2013 README.md
drwxrwsr-x 5 tools.russbot   project-tools    4096 Feb  2  2016 scripts
-rw-r--r-- 1 tools.russbot   project-tools    1942 Oct  2  2013 setup.py
drwxrwsr-x 6 tools.russbot   project-tools    4096 Dec  4  2013 .svn
-rw-r--r-- 1 tools.russbot   project-tools     328 Oct 27  2013 .svnprops
drwxrwsr-x 6 tools.russbot   project-tools    4096 Oct  2  2013 tests
-rw-r--r-- 1 tools.russbot   project-tools    1369 Oct  6  2013 .travis.yml
-rw-r--r-- 1 tools.russbot   project-tools     201 Aug  9  2013 user-config.py.sample
10:32:47 0 ✓ zhuyifei1999@tools-bastion-03: /shared/pywikipedia/core_old$ svn log
svn: E155036: Please see the 'svn upgrade' command
svn: E155036: The working copy at '/mnt/nfs/labstore-secondary-tools-project/.shared/pywikipedia/core_old'
is too old (format 10) to work with client version '1.8.8 (r1568071)' (expects format 31). You need to upgrade the working copy first.
Dvorapa closed this task as Resolved.EditedMar 23 2019, 7:06 PM
Dvorapa assigned this task to valhallasw.

Basically done