Maniphest T192772

Settings cog should use modal used for anonymous users
Open, LowPublic
Actions

Assigned To

None

Authored By

	• Jhernandez
	Apr 23 2018, 12:20 PM

Description

From T192710: [Feedback] Personal observations about the page previews feature usability

The "gear" icon on the preview panel links to https://en.wikipedia.org/wiki/Special:Preferences#mw-prefsection-rendering For me this is highly confusing

Proposal: treatment will be exactly same as it is for anonymous users.

However rather than saving to localStorage we will use the api to update the related user preference

developer notes

we will need to pass the preferences key to the client. mw.user.options can be used for the rest
we will need to deal with the asynchronous nature of the save. When hitting done what should happen? Should we show a spinner or should we just show a toast when the action has been completed? What if there is an error while saving?

Replication steps

Login to page previews
Hover over a preview
Click settings cog

Expected: I can disable page previews within a modal without leaving the page
Actual: I am unexpectedly navigated to Special:Preferences to disable the settings, losing my context in the article.

Related Objects

Mentioned In: T192710: [Feedback] Personal observations about the page previews feature usability
Mentioned Here: T192710: [Feedback] Personal observations about the page previews feature usability

Event Timeline

• Jhernandez created this task.Apr 23 2018, 12:20 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 23 2018, 12:20 PM

• Jhernandez mentioned this in T192710: [Feedback] Personal observations about the page previews feature usability.Apr 23 2018, 12:26 PM

@Nirzar thoughts?

@alexhollender ping. Anything to do here?

Jdlrobson moved this task from Backlog to Needs Analysis on the Page-Previews board.Jul 25 2018, 8:41 AM

• Jhernandez unsubscribed.Jul 25 2018, 10:38 AM

@Jdlrobson I think it would make sense to use the modal we've implemented for logged out users as a shortcut here for logged in users. So if I'm logged in and I hit the gear icon on a page preview I should get this modal:

Screen Shot 2018-07-30 at 9.03.05 AM.png (661×1 px, 257 KB)

In this case you wouldn't be shown were the "master" version of the setting is located in your preferences, but I'm not sure that's an actual problem? We could also add a link at the bottom of the modal (for logged in users only) that's like "Go to preferences" and land them at the #mw-prefsection-rendering-reading section

@alexhollender we will need some mocks to deal with the async behaviour. What happens when save is hit and the save fails? What about when the save is slow?

ovasileva triaged this task as Low priority.Aug 21 2018, 9:14 AM

ovasileva moved this task from Needs Analysis to Hovercards Pt2 on the Page-Previews board.

@Jdlrobson could you check if you can still reproduce this? Perhaps it somehow resolved itself... I just clicked the gear icon as an anonymous user and was shown the preferences modal:
https://s3.amazonaws.com/img0.recordit.co/PBS3egOsQN.mp4?AWSAccessKeyId=AKIAINSRFOQXTN4DT46A&Expires=1537898860&Signature=f%2BhtueezPrCw6kD4ioQwVf8LYeg%3D

^ I can replicate it. I suspect you were confused by the task so I added some replication steps.

Jdlrobson edited projects, added Web-Team-Backlog (Tracking); removed Web-Team-Backlog (Design).Jun 17 2021, 9:34 PM

Jdlrobson moved this task from Untriaged to Move to Backlog on the Web-Team-Backlog (Tracking) board.Sep 7 2021, 9:17 PM

LGoto edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Tracking).Sep 21 2021, 8:26 PM

Jdlrobson moved this task from Incoming to Not ready to estimate on the Web-Team-Backlog board.Sep 23 2021, 11:29 PM

ovasileva moved this task from Not ready to estimate to Groomed on the Web-Team-Backlog board.Dec 4 2023, 5:53 PM

Jdlrobson moved this task from Hovercards Pt2 to Backlog on the Page-Previews board.Jan 16 2024, 9:01 PM

	F24336888: Screen Shot 2018-07-30 at 9.03.05 AM.png
	Jul 30 2018, 4:22 PM

Settings cog should use modal used for anonymous usersOpen, LowPublicActions