The original fix for this patch caused another regression (T200940) - by making it impossible to ctrl+command+click links into new tabs. The patch was reverted, this task reopened with updated acceptance criteria
- I feel the area that is clickable on the panel is strange- I guess it is only on the part that is 100% visible, and that a gap has to be added between the preferences and the button, but maybe the gap can be just a corner on the right-down, or at least extend the clickable parts a bit more towards the bottom part? Image attached:
For readers it is unclear where the clickable area on the page previews panel begins. Intuitively one might think that the content (image + text) is clickable, but currently the bottom portion of the text content is not clickable.
When fixing this, we'll also need to make sure that we don't break default browser behaviour, for example, opening a link in a new tab via keyboard shortcuts (command+ctrl+click)
- the entire panel, aside from the cog+cog hover area, should click-through to the respective page
- the entire panel should have pointer:cursor
Currently the links only apply to the thumbnail portion and the extra portion via links inside the preview itself (note the red line surrounding the link inside this preview:)
We need to propose a solution.
Bind a click to anywhere on the preview to the link via JS. The settings cog should stop propagation to the parent element. Note, there is a danger of accessibility problems here but these are recorded and will be dealt with later. [Update: doesn't work. Breaks open in new tab]
This can be tested on http://reading-web-staging.wmflabs.org/