Maniphest T19283

Double URL escaping in show/hide links for log entries
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Mormegil
	Jan 31 2009, 5:11 PM

Description

Simple patch fixing the bug

LogEventsList::getShowHideLinks uses Title::getPrefixedUrl, but the result is URL-encoded once again after it is passed through Skin::revDeleteLink. Title:getPrefixedDBkey should be used instead (c.f. PageHistory::historyLine).

This is probably not a problem for English-language wikis (since Special:Log does not have any escaped characters), but e.g. for a Czech-language wiki, that breaks the link (since Speciální:Log is double-encoded to Speci%25C3%25A1ln%25C3%25AD%3ALog).

Version: unspecified
Severity: normal

attachment LogEventsList.php.diff ignored as obsolete

Details

Reference: bz17283

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:28 PM

• bzimport added projects: MediaWiki-Page-deletion, good first task.

• bzimport set Reference to bz17283.

• bzimport added a subscriber: Unknown Object (MLST).

Mormegil created this task.Jan 31 2009, 5:11 PM

Created attachment 5755
Patch fixing both occurrences of the bug

Oh, and while we are at it, the same bug is on another place: RevisionDeleteForm::__construct

And, in this case, it affects even English-language wikis, I believe, since the doubly-escaped string is a title of any random page.

Attached:

SpecialRevisionDelete.php.diff1 KBDownload

Applied in r46714. Thanks.

Double URL escaping in show/hide links for log entriesClosed, ResolvedPublicActions

Description

Details

Event Timeline

Double URL escaping in show/hide links for log entries
Closed, ResolvedPublic
Actions