Page MenuHomePhabricator
Create Task
Maniphest T192837

update mobileview API to support magic word
Closed, ResolvedPublic
Actions

Description

  • API should consume new wikidata description end point
  • API should return correct description and the source

Related patch updating MobileFrontend page output: https://gerrit.wikimedia.org/r/#/c/425911/

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Get overridden description in mobileview APImediawiki/extensions/MobileFrontendmaster+64 -9
Customize query in gerrit

Related Objects
Search...

Event Timeline

LGoto created this task.Apr 23 2018, 7:21 PM
LGoto triaged this task as Medium priority.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 23 2018, 7:21 PM
Aklapper added a comment.Apr 24 2018, 11:38 AM

(As the task description mentions a Gerrit patch which is linked to T190953, I'm wondering what's the relation of this task to T190953?)

• Mholloway added a comment.Apr 24 2018, 12:37 PM

@Aklapper The patch was brought up at a meeting yesterday as possibly resolving the issue. I just reviewed the patch and it actually doesn't update ApiMobileView as we need, but might point us in the right direction. I'll update the description.

• Mholloway updated the task description. (Show Details)Apr 24 2018, 12:37 PM
• Fjalapeno raised the priority of this task from Medium to High.Apr 27 2018, 3:47 PM
• Fjalapeno edited projects, added Product-Infrastructure-Team-Backlog-Deprecated (Kanban); removed Product-Infrastructure-Team-Backlog-Deprecated.
Mhurd subscribed.Apr 30 2018, 10:00 PM
• bearND claimed this task.May 1 2018, 3:20 PM
• bearND moved this task from To Do to Doing on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.
gerritbot subscribed.May 1 2018, 8:24 PM

Change 430246 had a related patch set uploaded (by BearND; owner: BearND):
[mediawiki/extensions/MobileFrontend@master] Get overridden description in mobileview API

https://gerrit.wikimedia.org/r/430246

gerritbot added a project: Patch-For-Review.May 1 2018, 8:24 PM
pmiazga added a project: Web-Team-Backlog-Archived (Tracking).May 8 2018, 1:24 PM
gerritbot added a comment.May 8 2018, 4:58 PM

Change 430246 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Get overridden description in mobileview API

https://gerrit.wikimedia.org/r/430246

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)).May 8 2018, 5:00 PM
• bearND moved this task from Doing to To Deploy on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.May 8 2018, 5:09 PM
• bearND closed this task as Resolved.May 10 2018, 9:31 PM
• bearND moved this task from To Deploy to Sign off on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.

https://en.wikipedia.org/w/api.php?action=mobileview&format=json&page=Wagon_Train&sections=0&prop=description%7Csections

{
  "mobileview": {
    "description": "Western television series aired 1957-1965",
    "descriptionsource": "local",
[...]
Jdlrobson mentioned this in T195872: MobileViewAPI throws undefined index notice and other warnings.May 29 2018, 3:39 PM
• Vvjjkkii renamed this task from update mobileview API to support magic word to qeeaaaaaaa.Jul 1 2018, 1:14 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed • bearND as the assignee of this task.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
AntiCompositeNumber renamed this task from qeeaaaaaaa to update mobileview API to support magic word.Jul 1 2018, 4:14 AM
AntiCompositeNumber closed this task as Resolved.
AntiCompositeNumber assigned this task to • bearND.
AntiCompositeNumber removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
AntiCompositeNumber updated the task description. (Show Details)
AntiCompositeNumber added subscribers: gerritbot, Aklapper.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits