Page MenuHomePhabricator
Create Task
Maniphest T192946

Make gwtoolsetUploadMediafileJob JSON-serializable
Closed, ResolvedPublic
Actions

Description

The gwtoolsetUploadMediafileJob contains non-scalar value in it's parameters, the partner-template-name property is an instance of Title , thus it's serialization relies on the redis-base JobQueue ability to use PHP serialization.

The kafka-based queue deliberately doesn't support PHP serialization and requires all the jobs to be JSON-serializable per T161647, so the gwtoolsetUploadMediafileJob job should be changed and made JSON-serializable.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Stop including partner-template-name in job paramsmediawiki/extensions/GWToolsetmaster+8 -10
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Pchelolo created this task.Apr 24 2018, 5:50 PM
• Pchelolo triaged this task as Medium priority.
• Pchelolo added projects: MediaWiki-extensions-GWToolset, Multimedia.Apr 24 2018, 6:30 PM
Restricted Application added a project: Commons. · View Herald TranscriptApr 24 2018, 6:30 PM
• fdans raised the priority of this task from Medium to Needs Triage.Apr 26 2018, 4:32 PM
• fdans moved this task from Incoming to Radar on the Analytics board.
Milimetric triaged this task as Medium priority.Apr 30 2018, 4:49 PM
Milimetric subscribed.

sorry - reverting accidental change of priority

JeanFred moved this task from Incoming to Uploading (upload_by_url and server side upload) on the Commons board.May 23 2018, 11:41 AM
• Pchelolo mentioned this in T175210: Select candidate jobs for transferring to the new infrastucture.May 29 2018, 10:10 AM
• Ramsey-WMF assigned this task to matthiasmullie.May 30 2018, 10:17 PM
• Ramsey-WMF added subscribers: MaxSem, • Ramsey-WMF.

Assigning to Matthias, who can ping @MaxSem for assistance and review :)

• Ramsey-WMF moved this task from Untriaged to Next up on the Multimedia board.May 31 2018, 5:21 PM
• Ramsey-WMF added a project: Multimedia-Team-Working-Board.
gerritbot subscribed.Jun 4 2018, 2:22 PM

Change 437255 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/GWToolset@master] Stop including partner-template-name in job params

https://gerrit.wikimedia.org/r/437255

gerritbot added a project: Patch-For-Review.Jun 4 2018, 2:22 PM
matthiasmullie moved this task from To Do to Code Review on the Multimedia-Team-Working-Board board.Jun 4 2018, 2:23 PM
gerritbot added a comment.Jun 4 2018, 6:46 PM

Change 437255 merged by jenkins-bot:
[mediawiki/extensions/GWToolset@master] Stop including partner-template-name in job params

https://gerrit.wikimedia.org/r/437255

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)).Jun 4 2018, 7:00 PM
Milimetric unsubscribed.Jun 11 2018, 3:52 PM
• Pchelolo closed this task as Resolved.Jun 12 2018, 10:20 AM
• Pchelolo edited projects, added Services (done); removed Patch-For-Review, Services (blocked).

Thank you, logs indicate the job's being serialized properly now.

• Vvjjkkii renamed this task from Make gwtoolsetUploadMediafileJob JSON-serializable to pbeaaaaaaa.Jul 1 2018, 1:14 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed matthiasmullie as the assignee of this task.
• Vvjjkkii raised the priority of this task from Medium to High.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii edited subscribers, added: matthiasmullie; removed: gerritbot, Aklapper.
• Community_Tech_bot updated the task description. (Show Details)Jul 1 2018, 5:58 AM
Mainframe98 renamed this task from pbeaaaaaaa to Make gwtoolsetUploadMediafileJob JSON-serializable.Jul 1 2018, 8:01 AM
Mainframe98 closed this task as Resolved.
Mainframe98 assigned this task to matthiasmullie.
Mainframe98 lowered the priority of this task from High to Medium.
Mainframe98 removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
Mainframe98 edited subscribers, added: gerritbot, Aklapper; removed: matthiasmullie.
Aklapper edited projects, added Analytics-Radar; removed Analytics.Jun 10 2020, 6:44 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits