Page MenuHomePhabricator

Remove all page previews instrumentation code
Open, Stalled, NormalPublic

Description

The Popups EventLogging instrumentation still provides significant additional information compared the new VirtualPageView schema introduced for T182414: [Spike] How can we measure seen page previews with as high a degree of accuracy as possible?. But the Popups instrumentation is not used currently, and increases the size and complexity of the codebase. If we've decided we have no need to use it again, we should remove this code.

AC

  • ext.popups.core.previewCount is deleted from localStorage, if it's present.
  • The ./counts module is removed.
  • The following properties are removed from the BOOT action:
    • sessionToken
    • pageToken
    • page
    • user.editCount
    • user.previewCount
  • The ./getBucket module is removed.
  • The ./reducers/eventLogging module is removed.
  • The ./changeListeners/eventLogging module is removed.
  • The ./isEnabled module is tidied up by removing the bucket parameter.
  • The wiring code in index.js is removed.
  • The corresponding unit tests
  • The actions.js has been audited and eventLogging only data on actions has been removed (like probably timedAction)
    • This can be done by checking which action types the reducers/eventLogging was acting on, and check where they are triggered in the actions.js, and seeing if the info there is needed in other usages in other reducers.

Sign off steps

The following should be done as part of the sign off process:

  • The Popups schema is marked as inactive.
  • Record the assets size change by disabling the code.

Event Timeline

Unclear whether we want to do this just yet given talk in T173952 but it's ready for estimation and working on.

ovasileva triaged this task as Normal priority.May 7 2018, 10:28 AM
ovasileva changed the task status from Open to Stalled.May 22 2018, 11:07 AM
ovasileva added subscribers: Lea_WMDE, ovasileva.

Marking as stalled until @Lea_WMDE has a chance to review what WMDE might need for reference previews.

Vvjjkkii renamed this task from Remove all page previews instrumentation code to s8daaaaaaa.Jul 1 2018, 1:14 AM
Vvjjkkii changed the task status from Stalled to Open.
Vvjjkkii raised the priority of this task from Normal to High.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed a subscriber: Aklapper.
Mainframe98 renamed this task from s8daaaaaaa to Remove all page previews instrumentation code.Jul 1 2018, 8:00 AM
Mainframe98 changed the task status from Open to Stalled.
Mainframe98 lowered the priority of this task from High to Normal.
Mainframe98 updated the task description. (Show Details)
Mainframe98 added a subscriber: Aklapper.
Jdlrobson moved this task from Backlog to Next Up on the Page-Previews board.Jul 25 2018, 8:40 AM

I'm not sure what the status of this ticket is. @Lea_WMDE, do you know if the existing instrumentation will be used for reference previews?

@Niedzielski I still have not had time to look into the existing instrumentation. Who would be the best person to help me go through it? @Tbayer?

@Lea_WMDE, yes, I believe @Tbayer would be the best person to discuss instrumentation. If there are coding questions, I am happy to help with that.

@Lea_WMDE Yes, happy to talk about the data side - feel free to post questions here or set up a quick call in case that seems preferable.

Thanks @Tbayer! I had a look now and I am wondering if the data for page previews is still being tracked / if we still have data from previous tracking endevours that I could look at concerning the questions outlined in T214493?

Thanks @Tbayer! I had a look now and I am wondering if the data for page previews is still being tracked

  • The Popups schema is no longer collecting data, although you should be able to reactivate it with a simple configuration change, as we haven't yet removed the instrumentation code (this task).
  • The less detailed VirtualPageView schema is still sending data. Its main purpose is to provide aggregated content consumption numbers (how often a given page has been previewed for >1sec) that are stored in the Virtualpageview_hourly table - rather than answering product questions about how the previews feature is being used per se; we used the Popups schema for that.

/ if we still have data from previous tracking endevours that I could look at concerning the questions outlined in T214493?

Yes, there is still data in the usual places where EventLogging data is stored, e.g. the event.popups Hive table. (I guess you may already have looked at the results published at https://www.mediawiki.org/wiki/Page_Previews/2017-18_A/B_Tests and perhaps the further details in the Phab task(s) linked from there.)

Quiddity removed a subscriber: Quiddity.Feb 18 2019, 9:12 PM