Maniphest T193053

Remove PopupsBetaFeature code
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	Jdlrobson
	Apr 25 2018, 4:30 PM

Description

Popups is never going to be a beta feature again. Let's remove the associated code.

acceptance criteria

Image assets relating to feature removed
hooks relating to enabling the feature / showing it in preferences is removed
PopupsBetaFeature config variable removed
Documentation in markdown files updated

Sign off step

mediawiki.org updated

Details

	Subject	Repo	Branch	Lines +/-
	Remove remaining references to beta	mediawiki/extensions/Popups	master	+1 -3
	Remove BetaFeature code	mediawiki/extensions/Popups	master	+47 -298

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		ovasileva	T192622 [EPIC] Page previews post-deploy cleanup
		Resolved		ABorbaWMF	T193053 Remove PopupsBetaFeature code

Event Timeline

Jdlrobson created this task.Apr 25 2018, 4:30 PM

Jdlrobson removed a project: Readers-Web-Kanbanana-Board-Old.

Jdlrobson moved this task from Incoming to Upcoming on the Web-Team-Backlog board.

• Jhernandez updated the task description. (Show Details)Apr 25 2018, 4:33 PM

Jdlrobson triaged this task as Medium priority.Apr 25 2018, 4:54 PM

Jdlrobson set the point value for this task to 3.

Jdlrobson added a project: Readers-Web-Kanbanana-Board-Old.

Jdlrobson moved this task from Upcoming to 2017-18 Q4 on the Web-Team-Backlog board.

Jdlrobson moved this task from To Do to Doing on the Readers-Web-Kanbanana-Board-Old board.Apr 26 2018, 6:35 PM

Jdlrobson updated the task description. (Show Details)Apr 26 2018, 9:12 PM

Change 429347 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/Popups@master] Remove BetaFeature code

https://gerrit.wikimedia.org/r/429347

gerritbot added a project: Patch-For-Review.Apr 26 2018, 9:12 PM

Jdlrobson moved this task from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Apr 26 2018, 9:12 PM

Change 429347 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Remove BetaFeature code

https://gerrit.wikimedia.org/r/429347

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)).May 1 2018, 4:00 PM

Anthony, could you please do a quick and generic page previews QA on the beta cluster and check page previews are working correctly if the user is logged in (and has it disabled/enabled) or is anonymous (and has it disabled/enabled). Heads up @ovasileva that the beta feature code is gone \o/

Looking good to me on the Dog article on beta

updated https://www.mediawiki.org/wiki/Beta_Features, I think we're all done here, but @Jdlrobson - handing this over to you since some checkboxes are still open in the acceptance criteria.

ovasileva updated the task description. (Show Details)May 2 2018, 3:10 PM

Jdlrobson updated the task description. (Show Details)May 2 2018, 8:32 PM

Change 430478 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/Popups@master] Remove remaining references to beta

https://gerrit.wikimedia.org/r/430478

Change 430478 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Remove remaining references to beta

https://gerrit.wikimedia.org/r/430478

Jdlrobson closed this task as Resolved.May 3 2018, 4:49 PM

Jdlrobson updated the task description. (Show Details)

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)); removed MW-1.32-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)).May 3 2018, 5:00 PM

	F17511720: image.png
	May 1 2018, 11:28 PM

	F17511718: image.png
	May 1 2018, 11:28 PM

	F17511724: image.png
	May 1 2018, 11:28 PM

	F17511727: image.png
	May 1 2018, 11:28 PM

Remove PopupsBetaFeature codeClosed, ResolvedPublic3 Estimated Story PointsActions