Page MenuHomePhabricator

Remove PopupsBetaFeature code
Closed, ResolvedPublic3 Estimated Story Points


Popups is never going to be a beta feature again. Let's remove the associated code.

acceptance criteria

  • Image assets relating to feature removed
  • hooks relating to enabling the feature / showing it in preferences is removed
  • PopupsBetaFeature config variable removed
  • Documentation in markdown files updated

Sign off step

  • updated

Related Objects

Event Timeline

Jdlrobson triaged this task as Medium priority.Apr 25 2018, 4:54 PM
Jdlrobson set the point value for this task to 3.
Jdlrobson moved this task from Upcoming to 2017-18 Q4 on the Readers-Web-Backlog board.

Change 429347 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/Popups@master] Remove BetaFeature code

Change 429347 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Remove BetaFeature code

Jdlrobson added a subscriber: ovasileva.

Anthony, could you please do a quick and generic page previews QA on the beta cluster and check page previews are working correctly if the user is logged in (and has it disabled/enabled) or is anonymous (and has it disabled/enabled). Heads up @ovasileva that the beta feature code is gone \o/

Looking good to me on the Dog article on beta

image.png (768×1 px, 578 KB)

image.png (768×1 px, 545 KB)

image.png (768×1 px, 494 KB)

image.png (768×1 px, 496 KB)

updated, I think we're all done here, but @Jdlrobson - handing this over to you since some checkboxes are still open in the acceptance criteria.

Change 430478 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/Popups@master] Remove remaining references to beta

Change 430478 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Remove remaining references to beta

Jdlrobson updated the task description. (Show Details)