Maniphest T193087

Use 'default' instead of 'value' in HTMLTextField
Closed, ResolvedPublic
Actions

Description

Using 'value' param in 'type' => 'text' or 'class' => HTMLTextField may not be useful. And this may rise problem like T192705, because 'value' param does not change upon Form submit where as 'default' can change.

Solution

Use 'default' instead of 'value'

Details

	Subject	Repo	Branch	Lines +/-
	Use 'default' instead of 'value' in HTMLTextField	mediawiki/core	master	+1 -1
	Use 'default' instead of 'value'	mediawiki/extensions/IndexFunction	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned Here: T192705: Special:GlobalUserRights does not have a value in username field when access /USERNAME

Event Timeline

Jayprakash12345 created this task.Apr 25 2018, 8:55 PM

Restricted Application added a project: User-Jayprakash12345. · View Herald TranscriptApr 25 2018, 8:55 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Jayprakash12345 renamed this task from Use 'default' instead of 'value' in HTMLUserTextField to Use 'default' instead of 'value' in HTMLTextField.Apr 25 2018, 9:02 PM

Jayprakash12345 updated the task description. (Show Details)

Change 429210 had a related patch set (by Jayprakash12345) published:
[mediawiki/extensions/IndexFunction@master] Use 'default' instead of 'value'

https://gerrit.wikimedia.org/r/429210

gerritbot added a project: Patch-For-Review.Apr 26 2018, 3:09 PM

Change 429210 merged by jenkins-bot:
[mediawiki/extensions/IndexFunction@master] Use 'default' instead of 'value'

https://gerrit.wikimedia.org/r/429210

• Vvjjkkii renamed this task from Use 'default' instead of 'value' in HTMLTextField to s7daaaaaaa.Jul 1 2018, 1:14 AM

• Vvjjkkii triaged this task as High priority.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed subscribers: gerritbot, Aklapper.

AfroThundr3007730 renamed this task from s7daaaaaaa to Use 'default' instead of 'value' in HTMLTextField.Jul 1 2018, 6:42 AM

AfroThundr3007730 raised the priority of this task from High to Needs Triage.

AfroThundr3007730 removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

AfroThundr3007730 updated the task description. (Show Details)

AfroThundr3007730 added subscribers: GerritBot, Aklapper.

Change 447848 had a related patch set uploaded (by Jayprakash12345; owner: Jayprakash12345):
[mediawiki/core@master] Use 'default' instead of 'value' in HTMLTextField

https://gerrit.wikimedia.org/r/447848