Page MenuHomePhabricator
Create Task
Maniphest T193101

Parent: Fix display title regressions (i.e. showing 'IPhone' when it should show 'iPhone')
Closed, ResolvedPublic
Actions

Description

Details:

  • If a query is using the pageprops param it should get pageprops.displaytitle in the results.
  • We just need to use pageprops.displaytitle from the results (if present) instead of just grabbing title from the query results.
  • Fallback to title if there's no pageprops.displaytitle or if pageprops.displaytitle contains html.
  • Reminder: ensure we only change what we're using for display and not the title bits which are used when user makes a selection to load actual article.

Related Objects
Search...

Event Timeline

Mhurd created this task.Apr 25 2018, 11:35 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 25 2018, 11:35 PM
Mhurd renamed this task from Fix display title regressions (i.e. showing 'IPhone' when it should show 'iPhone') to Parent: Fix display title regressions (i.e. showing 'IPhone' when it should show 'iPhone').Apr 25 2018, 11:36 PM
Mhurd added a subtask: T193097: [BUG] Search results not using API `displaytitle` (i.e. showing 'IPhone' when it should show 'iPhone').
Mhurd added a subtask: T193099: [BUG] Article footer "Read more" results not using API `displaytitle` (i.e. showing 'IPhone' when it should show 'iPhone').
Mhurd added a subtask: T193102: [BUG] `Because you read` results not using API `displaytitle` (i.e. showing 'IPhone' when it should show 'iPhone').Apr 25 2018, 11:45 PM
Mhurd added a subtask: T193104: [BUG] `Table of contents` not using API `displaytitle` (i.e. showing 'IPhone' when it should show 'iPhone').Apr 26 2018, 12:02 AM
Mhurd added a subtask: T193105: [BUG] Saved and History items not using API `displaytitle` (i.e. showing 'IPhone' when it should show 'iPhone').Apr 26 2018, 12:26 AM
• JMinor triaged this task as Medium priority.Apr 30 2018, 5:46 PM
• JMinor moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.
JoeWalsh subscribed.May 3 2018, 12:02 PM

Fallback to title if there's no pageprops.displaytitle or if pageprops.displaytitle contains html.

Should we remove the HTML instead of falling back to title so we retain the capitalization?

Also, if we want to start showing italics, now would probably be a good time.

Mhurd added a subscriber: • JMinor.May 3 2018, 5:52 PM

Should we remove the HTML instead of falling back to title so we retain the capitalization?

That makes sense.

Also, if we want to start showing italics, now would probably be a good time.

@JMinor ? ^

• JMinor added a comment.May 3 2018, 5:54 PM

Agreed, if we can resolve our italics issues at the same time, it would be good. Lets confirm in sync today.

LGoto subscribed.May 3 2018, 8:14 PM
• JMinor closed subtask T193099: [BUG] Article footer "Read more" results not using API `displaytitle` (i.e. showing 'IPhone' when it should show 'iPhone') as Resolved.May 25 2018, 9:24 PM
• JMinor closed subtask T193102: [BUG] `Because you read` results not using API `displaytitle` (i.e. showing 'IPhone' when it should show 'iPhone') as Resolved.May 25 2018, 9:27 PM
• JMinor closed subtask T193097: [BUG] Search results not using API `displaytitle` (i.e. showing 'IPhone' when it should show 'iPhone') as Resolved.
• JMinor closed subtask T193105: [BUG] Saved and History items not using API `displaytitle` (i.e. showing 'IPhone' when it should show 'iPhone') as Resolved.
• Vvjjkkii renamed this task from Parent: Fix display title regressions (i.e. showing 'IPhone' when it should show 'iPhone') to e7daaaaaaa.Jul 1 2018, 1:13 AM
• Vvjjkkii raised the priority of this task from Medium to High.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii reopened subtask T193099: [BUG] Article footer "Read more" results not using API `displaytitle` (i.e. showing 'IPhone' when it should show 'iPhone') as Open.
• Vvjjkkii reopened subtask T193102: [BUG] `Because you read` results not using API `displaytitle` (i.e. showing 'IPhone' when it should show 'iPhone') as Open.
• Vvjjkkii reopened subtask T193105: [BUG] Saved and History items not using API `displaytitle` (i.e. showing 'IPhone' when it should show 'iPhone') as Open.
• Vvjjkkii reopened subtask T193097: [BUG] Search results not using API `displaytitle` (i.e. showing 'IPhone' when it should show 'iPhone') as Open.
• Vvjjkkii removed a subscriber: Aklapper.
Mainframe98 closed subtask T193097: [BUG] Search results not using API `displaytitle` (i.e. showing 'IPhone' when it should show 'iPhone') as Resolved.Jul 1 2018, 8:31 AM
Mainframe98 renamed this task from e7daaaaaaa to Parent: Fix display title regressions (i.e. showing 'IPhone' when it should show 'iPhone').Jul 1 2018, 9:03 AM
Mainframe98 lowered the priority of this task from High to Medium.
Mainframe98 removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
Mainframe98 updated the task description. (Show Details)
Mainframe98 closed subtask T193099: [BUG] Article footer "Read more" results not using API `displaytitle` (i.e. showing 'IPhone' when it should show 'iPhone') as Resolved.
Mainframe98 closed subtask T193102: [BUG] `Because you read` results not using API `displaytitle` (i.e. showing 'IPhone' when it should show 'iPhone') as Resolved.
Mainframe98 added a subscriber: Aklapper.
Mainframe98 closed subtask T193105: [BUG] Saved and History items not using API `displaytitle` (i.e. showing 'IPhone' when it should show 'iPhone') as Resolved.Jul 1 2018, 9:06 AM
• JMinor closed this task as Resolved.Jun 25 2019, 6:58 PM
• JMinor claimed this task.
• JMinor closed subtask T193104: [BUG] `Table of contents` not using API `displaytitle` (i.e. showing 'IPhone' when it should show 'iPhone') as Resolved.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL