| • MichaelSchoenitzer_WMDE | |
| Apr 26 2018, 10:24 AM |
| F29330131: Bildschirmfoto 2019-06-03 um 11.38.23.png | |
| Jun 3 2019, 9:39 AM |
| F29284787: success.png | |
| May 31 2019, 2:59 PM |
| F29284786: error.png | |
| May 31 2019, 2:59 PM |
| F23307928: Screenshot_20180704_140845.png | |
| Jul 4 2018, 12:09 PM |
| F17320142: Bildschirmfoto zu 2018-04-26 12-18-39.png | |
| Apr 26 2018, 10:24 AM |
Motivation
The success-message of FileImporter currently looks like this:
The contrast does not full fill the WCAG-Recomendations.
Acceptance Criteria
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Make errorbox and successbox text black | mediawiki/extensions/FileImporter | master | +2 -2 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | thiemowmde | T223523 Newcomer-friendly FileImporter tasks at the Hackathon 2019 | |||
| Resolved | awight | T193125 Change font color in messages |
the colors are of the Wikimedia color palette, so the green is okay IMO
I would change the text to black, which would also fulfill all the WCAG recommendations.
I noticed that we're also subtly changing the successbox background color, which is already defined by mediawiki-core. I've rolled back our customization, here are screenshots of the resulting colors for review:
Change 513619 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/FileImporter@master] Make errorbox and successbox text black
Change 513619 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Make errorbox and successbox text black
When trying to test this, I get an error message with the following details
Yikes! Would you mind sketching out what steps you're taking which cause this error?
Clicking on the "move to commons" link for this file:
https://de.wikipedia.beta.wmflabs.org/wiki/Datei:TEST_Euro_exchange_rate_to_TRY_-_Turkish_Currency_and_Debt_Crisis_2018.svg
Renaming by adding AGAIN in front of the title and clicking submit then
I had a quick look at the exception. I believe there is a misconfiguration in one of the filters on this wiki: https://commons.wikimedia.beta.wmflabs.org/wiki/Special:AbuseFilter?furtheroptions%5B%5D=hidedisabled. I don't know which. In other words, I believe this is not us, and there is nothing we can do to fix this in our codebase. To not make a badly configured filter make the AbuseFilter extension crash, that extension would need a fix/partly rewrite. This might be worth opening a separate ticket.