Maniphest T193159

Source sections are not saved
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• santhosh
	Apr 26 2018, 12:21 PM

Description

Suspected regression from https://gerrit.wikimedia.org/r/c/427351/, Source sections are not send for saving from client side.

A restored translation looks like this:

Causes the js error

TypeError: Cannot read property 'content' of null
    at Object.mw.cx.dm.Translation.static.getSavedSection

The JS error was fixed in https://gerrit.wikimedia.org/r/c/429167/ but the cause for this skipped source section remains unsolved

Details

	Subject	Repo	Branch	Lines +/-
	Fix the incorrect condition for saving the source section	mediawiki/extensions/ContentTranslation	master	+3 -4

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		• santhosh	T193113 CX2 - "Cannot read property 'content' of null TypeError" -translation cannot load
		Resolved		• santhosh	T193159 Source sections are not saved

Event Timeline

• santhosh created this task.Apr 26 2018, 12:21 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 26 2018, 12:21 PM

• santhosh triaged this task as High priority.Apr 26 2018, 12:21 PM

• santhosh claimed this task.Apr 26 2018, 12:39 PM

Change 429173 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/ContentTranslation@master] Fix the incorrect condition for saving the source section

https://gerrit.wikimedia.org/r/429173

gerritbot added a project: Patch-For-Review.Apr 26 2018, 12:39 PM

• santhosh added a project: Language-2018-Apr-June.Apr 26 2018, 12:39 PM

• santhosh moved this task from Needs Triage to CX2 on the ContentTranslation board.

• santhosh moved this task from Backlog to In Review on the Language-2018-Apr-June board.

Change 429173 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Fix the incorrect condition for saving the source section

https://gerrit.wikimedia.org/r/429173

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)).Apr 26 2018, 3:00 PM

Etonkovidova added a parent task: T193113: CX2 - "Cannot read property 'content' of null TypeError" -translation cannot load .Apr 26 2018, 3:34 PM

• Petar.petkovic removed a project: Patch-For-Review.Apr 27 2018, 7:06 AM

• Petar.petkovic moved this task from In Review to QA on the Language-2018-Apr-June board.

@santhosh
I see couple of different errors when loading saved translations - are they related to the fix?

(1) 'Tour de France' en to de shows 11 errors when a saved translation is loaded:

VM305:1229 Uncaught TypeError: Cannot read property 'getModel' of undefined
    at VeInitMwCXTarget.ve.init.mw.CXTarget.getTargetSectionNode (<anonymous>:1229:196)
    at VeInitMwCXTarget.ve.init.mw.CXTarget.saveSection (<anonymous>:1228:193)
    at MwCxDmTranslation.oo.EventEmitter.emit (<anonymous>:49:486)
    at VeDmCXSectionNode.ve.dm.CXSectionNode.onUpdate (<anonymous>:1113:660)
    at later (load.php?debug=false&lang=en&modules=ext.visualEditor.core|oojs-ui-core%2Coojs-ui-widgets&skin=vector&version=1atip6i:799)

(2) 'Timeline of the Apple II family' as a New translation en to es persistently shows
[CX] Section 19 not restored

Etonkovidova mentioned this in T193113: CX2 - "Cannot read property 'content' of null TypeError" -translation cannot load .May 3 2018, 4:00 AM