Page MenuHomePhabricator
Create Task
Maniphest T193215

Tagline is missing in Timeless
Closed, ResolvedPublic
Actions

Description

Timeless does not include the tagline (site subtitle), unlike the other skins available on Wikimedia wikis. In those skins, this is an element with id siteSub (except for Cologne blue, which uses an element with class tagline). Though hidden on many sites, it is shown on English Wikipedia, and in print views for some skins.

See also https://www.mediawiki.org/wiki/Manual:Skinning_Part_2#Tagline

Fixing this would resolve T191589: Ensure compatibility with the metadata gadget (which displays an article assessment not shown in Timeless) without any changes to the gadget itself.

Details

ProjectBranchLines +/-Subject
mediawiki/skins/Timelessmaster+8 -0Add sitesub, but hide by default
Customize query in gerrit

Related Objects
Search...

Event Timeline

Evad37 created this task.Apr 27 2018, 2:03 AM
Evad37 added parent tasks: T154707: Add missing features that vector has, T191589: Ensure compatibility with the metadata gadget (which displays an article assessment not shown in Timeless).
Evad37 added a comment.EditedMay 2 2018, 10:56 AM

The lack of a tagline also means there's no obvious place to put coordinates. On Vector, they're positioned on the same line as the tagline, but on the far right. In Timeless (on enwiki), they're currently hidden, see https://en.wikipedia.org/wiki/MediaWiki:Timeless.css

• Vvjjkkii renamed this task from Tagline is missing in Timeless to 83daaaaaaa.Jul 1 2018, 1:13 AM
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
CommunityTechBot renamed this task from 83daaaaaaa to Tagline is missing in Timeless.Jul 2 2018, 4:36 PM
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
gerritbot added a subscriber: gerritbot.Jul 19 2018, 1:18 PM

Change 446811 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/Timeless@master] Add sitesub, but hide by default

https://gerrit.wikimedia.org/r/446811

gerritbot added a project: Patch-For-Review.Jul 19 2018, 1:18 PM
gerritbot added a comment.Jul 21 2018, 1:51 PM

Change 446811 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Add sitesub, but hide by default

https://gerrit.wikimedia.org/r/446811

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)).Jul 21 2018, 2:00 PM
Isarra closed this task as Resolved.Aug 2 2018, 5:25 PM
Isarra claimed this task.
Isarra added a subscriber: Isarra.

Technically fixed skin-side (it's now there, but as with in other skins, hidden by default), but it's up to the project(s) to actually unhide it if desired. Related: https://en.wikipedia.org/wiki/MediaWiki_talk:Common.css#SiteSub_display_('From_Wikipedia,_the_Free_Encyclopedia')

Evad37 mentioned this in T191589: Ensure compatibility with the metadata gadget (which displays an article assessment not shown in Timeless).Aug 3 2018, 5:07 AM
TheDJ awarded a token.Aug 3 2018, 6:09 PM
Evad37 mentioned this in T211398: Compile list of gadgets across various projects that broke in timeless, and why.Dec 22 2018, 5:54 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL