Page MenuHomePhabricator
Create Task
Maniphest T193227

Authorize L10n-bot to give +2 for SecureAuth extension
Closed, ResolvedPublic
Actions

Description

Currently L10n-bot is not allowed to give +2 for the SecureAuth extension, see https://gerrit.wikimedia.org/r/#/c/428799/

Details

SubjectRepoBranchLines +/-
Set correct parent project to allow L10n-bot and jenkins to submit.mediawiki/extensions/SecureAuthrefs/meta/config+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Raymond created this task.Apr 27 2018, 9:58 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 27 2018, 9:58 AM
Raymond added a parent task: T191169: Support and Improvement of Extension:SecureAuth (tracking).Apr 27 2018, 9:59 AM
MarcoAurelio claimed this task.Apr 27 2018, 10:10 AM
Restricted Application added a project: User-MarcoAurelio. · View Herald TranscriptApr 27 2018, 10:10 AM
gerritbot subscribed.Apr 27 2018, 10:13 AM

Change 429393 had a related patch set uploaded (by MarcoAurelio; owner: MarcoAurelio):
[mediawiki/extensions/SecureAuth@refs/meta/config] Set correct parent project to allow L10n-bot and jenkins to submit.

https://gerrit.wikimedia.org/r/429393

gerritbot added a project: Patch-For-Review.Apr 27 2018, 10:13 AM
MarcoAurelio mentioned this in rESECb056737ded96: Set correct parent project to allow L10n-bot and jenkins to submit..Apr 27 2018, 10:16 AM
gerritbot added a comment.Apr 27 2018, 10:27 AM

Change 429393 merged by Hashar:
[mediawiki/extensions/SecureAuth@refs/meta/config] Set correct parent project to allow L10n-bot and jenkins to submit.

https://gerrit.wikimedia.org/r/429393

MarcoAurelio triaged this task as High priority.Apr 27 2018, 10:34 AM
MarcoAurelio moved this task from Bugs & stuff to Repo Admin on the Gerrit board.
MarcoAurelio moved this task from unsorted/backlog to cabinet on the User-MarcoAurelio board.
MarcoAurelio moved this task from Backlog to New projects for translation on the translatewiki.net board.

This should be fixed by the patch above. Testing it now.

MarcoAurelio closed this task as Resolved.EditedApr 27 2018, 10:38 AM

After the fix, https://gerrit.wikimedia.org/r/#/c/429307/ was merged by jenkins bot. Also, given that the parent project is now mediawiki/extensions L10n-Bot should be allowed to merge their own patches as well.

Addenda: correct reasoning is that mediawiki/extensions is a child of mediawiki which has the implicit groups set to allow jenkins and l10n-bot to work; cf. https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki,access.

MarcoAurelio removed a project: Patch-For-Review.Apr 27 2018, 10:42 AM
MarcoAurelio added a comment.Apr 30 2018, 10:10 PM

Just to mention that the fix indeed seems to have worked as expected as you can see at https://gerrit.wikimedia.org/r/#/c/429956/ -- L10n-bot does upload and merge their changes as expected.

• Vvjjkkii renamed this task from Authorize L10n-bot to give +2 for SecureAuth extension to w3daaaaaaa.Jul 1 2018, 1:13 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed MarcoAurelio as the assignee of this task.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
Yann renamed this task from w3daaaaaaa to Authorize L10n-bot to give +2 for SecureAuth extension.Jul 1 2018, 11:36 AM
Yann assigned this task to MarcoAurelio.
Yann removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
Yann updated the task description. (Show Details)
Yann added subscribers: Aklapper, gerritbot.
Yann closed this task as Resolved.Jul 1 2018, 12:13 PM
Liuxinyu970226 added a project: MediaWiki-extensions-SecureAuth.Sep 16 2018, 12:50 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL