Page MenuHomePhabricator
Create Task
Maniphest T193252

CX2: Translation source toolbar too wide in Apex/monobook
Closed, ResolvedPublic
Actions

Description

image.png (80×429 px, 4 KB)

Details

SubjectRepoBranchLines +/-
CX2: Translation source toolbar too wide in Apex/monobookmediawiki/extensions/ContentTranslationmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Apr 27 2018, 3:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 27 2018, 3:33 PM
Pginer-WMF triaged this task as Low priority.May 3 2018, 2:07 PM
Pginer-WMF mentioned this in T188247: CX2: Automatic Translation card to adjust MT options.
Pginer-WMF added a project: Language-2018-Apr-June.
Pginer-WMF moved this task from Needs Triage to CX2 on the ContentTranslation board.
gerritbot subscribed.May 4 2018, 10:10 AM

Change 430874 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/ContentTranslation@master] CX2: Translation source toolbar too wide in Apex/monobook

https://gerrit.wikimedia.org/r/430874

gerritbot added a project: Patch-For-Review.May 4 2018, 10:10 AM
• santhosh claimed this task.May 4 2018, 10:11 AM
• santhosh moved this task from Backlog to In Review on the Language-2018-Apr-June board.
• santhosh subscribed.

Screenshot after the fix:

image.png (177×431 px, 8 KB)

Nikerabbit subscribed.May 7 2018, 6:49 AM

At closer zoom below. In my opinion this should be improved further.

image.png (216×774 px, 23 KB)

Esanders added a comment.May 7 2018, 10:47 AM

Apex toolbar menus should have padding. This would also avoid the issue of the double border / mismatched radii.

image.png (64×293 px, 5 KB)

Esanders added a comment.May 7 2018, 11:27 AM

I think you just need to replace the width: 100% override display: block. You should also remove the extra right border in WMUI (not Apex, see T194028)

gerritbot added a comment.May 7 2018, 2:29 PM

Change 430874 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] CX2: Translation source toolbar too wide in Apex/monobook

https://gerrit.wikimedia.org/r/430874

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)).May 7 2018, 3:01 PM
Nikerabbit moved this task from In Review to QA on the Language-2018-Apr-June board.May 7 2018, 3:19 PM
Nikerabbit removed a project: Patch-For-Review.
Etonkovidova closed this task as Resolved.May 10 2018, 5:47 PM
Etonkovidova subscribed.

The reported issue has been fixed. If there is anything else to fix ( a question to @Esanders and @Nikerabbit) - I think it should be reported as a separate issue.

• Petar.petkovic moved this task from QA to Done on the Language-2018-Apr-June board.May 14 2018, 9:10 PM
• Vvjjkkii renamed this task from CX2: Translation source toolbar too wide in Apex/monobook to 72daaaaaaa.Jul 1 2018, 1:13 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed • santhosh as the assignee of this task.
• Vvjjkkii raised the priority of this task from Low to High.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
CommunityTechBot renamed this task from 72daaaaaaa to CX2: Translation source toolbar too wide in Apex/monobook.Jul 2 2018, 7:47 AM
CommunityTechBot closed this task as Resolved.
CommunityTechBot assigned this task to • santhosh.
CommunityTechBot lowered the priority of this task from High to Low.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added subscribers: gerritbot, Aklapper.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL