Page MenuHomePhabricator

VisualEditor should not add local "|link=https://..." links to file description when copying images from another page
Open, MediumPublic

Description

On
https://pt.wikipedia.org/w/index.php?title=M%C3%A9todo_das_transformadas_de_Laplace_para_resolver_equa%C3%A7%C3%B5es_diferencais&type=revision&diff=51919474&oldid=51909291
VisualEditor added

[[Ficheiro:Laplace7.pdf|ligação=https://pt.wikipedia.org/wiki/Ficheiro:Laplace7.pdf|semmoldura|400x400px]]

but it should add

[[Ficheiro:Laplace7.pdf|semmoldura|400x400px]]

as in this edit: https://pt.wikipedia.org/w/index.php?diff=51919734

Event Timeline

He7d3r created this task.Apr 27 2018, 3:35 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 27 2018, 3:35 PM
Deskana added a subscriber: Deskana.May 1 2018, 6:41 PM

Reproduction steps would be helpful. Do you know what the user did to make this happen?

Vvjjkkii renamed this task from VisualEditor should not add local "|link=https://..." links to file description when adding images to 62daaaaaaa.Jul 1 2018, 1:13 AM
Vvjjkkii triaged this task as High priority.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed a subscriber: Aklapper.
Yann renamed this task from 62daaaaaaa to VisualEditor should not add local "|link=https://..." links to file description when adding images.Jul 1 2018, 1:56 PM
Yann raised the priority of this task from High to Needs Triage.
Yann updated the task description. (Show Details)
Yann added a subscriber: Aklapper.

I can reproduce this by copy-pasting the image from another article in VE edit mode.

matmarex renamed this task from VisualEditor should not add local "|link=https://..." links to file description when adding images to VisualEditor should not add local "|link=https://..." links to file description when copying images from another page.Aug 31 2018, 8:46 PM
ssastry triaged this task as Medium priority.Jun 10 2019, 8:50 PM
ssastry edited projects, added Parsoid-Edit-Support; removed Parsoid.
ssastry moved this task from Backlog to Link syntax (links & media) on the Parsoid-Edit-Support board.
hgzh added a subscriber: hgzh.Sep 7 2019, 9:22 PM

Just noticed this behaviour on dewiki: https://de.wikipedia.org/w/index.php?title=Kohlenstoff&type=revision&diff=192062719&oldid=191962285

Steps to reproduce:

  1. start editing a page using VisualEditor
  2. open another page with an image thumbnail in VisualEditor
  3. select the image thumbnail on the second page and copy it to clipboard
  4. go back to the first page and paste the copied thumbnail to it
  5. when checking diff/wikitext, there will be the useless extra link to the image in the link= parameter
JTannerWMF moved this task from To Triage to Q1 on the VisualEditor board.Sep 10 2019, 3:51 PM
JTannerWMF added a subscriber: JTannerWMF.

We will take a look at this ticket when we have a lull in feature work.

Change 535678 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Parse relative hrefs on image nodes like on regular links

https://gerrit.wikimedia.org/r/535678

Change 535678 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Parse relative hrefs on image nodes like on regular links

https://gerrit.wikimedia.org/r/535678

Ryasmeen edited projects, added Verified; removed Editing QA.Oct 17 2019, 7:59 PM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.

The patch was reverted, it caused dirty diffs (T237040).

Restricted Application added a project: VisualEditor. · View Herald TranscriptFeb 5 2020, 12:05 AM
JTannerWMF moved this task from Incoming to Freezer on the Editing-team board.
JTannerWMF added a subscriber: ppelberg.

This hasn't been updated in a while and after chatting with @ppelberg in comparison with all of the work we have this isn't a high priority.

Aklapper edited projects, added Parsoid; removed Parsoid-Edit-Support.Feb 29 2020, 5:15 PM
Arlolra moved this task from Needs Triage to Backlog on the Parsoid board.Mar 2 2020, 4:27 PM
LGoto removed a project: Parsoid.May 8 2020, 4:23 PM

I'd like to try doing this again, the fix for T108504 should prevent the issue with dirty diffs from re-occurring.