⚓ T193253 VisualEditor should not add local "|link=https://..." links to file description when copying images from another page

	Subject	Repo	Branch	Lines +/-
	Parse relative hrefs on image nodes like on regular links (try 2)	mediawiki/extensions/VisualEditor	master	+72 -52
	Parse relative hrefs on image nodes like on regular links	mediawiki/extensions/VisualEditor	master	+76 -54

		Status	Subtype	Assigned	Task
		Resolved		matmarex	T193253 VisualEditor should not add local "\|link=https://..." links to file description when copying images from another page
		Resolved		matmarex	T108504 Parsoid/VE adds images with pointless link parameter

He7d3r created this task.Apr 27 2018, 3:35 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 27 2018, 3:35 PM

Reproduction steps would be helpful. Do you know what the user did to make this happen?

Nope. But it is not the first user who does this:
https://pt.wikipedia.org/w/index.php?search=insource%3A%2Fliga%C3%A7%C3%A3o%3Dhttps%3A%2F&title=Especial:Pesquisar&profile=advanced&fulltext=1&ns0=1

matmarex added a project: Parsoid.May 1 2018, 9:11 PM

• Vvjjkkii renamed this task from VisualEditor should not add local "|link=https://..." links to file description when adding images to 62daaaaaaa.Jul 1 2018, 1:13 AM

• Vvjjkkii triaged this task as High priority.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed a subscriber: Aklapper.

Yann renamed this task from 62daaaaaaa to VisualEditor should not add local "|link=https://..." links to file description when adding images.Jul 1 2018, 1:56 PM

Yann raised the priority of this task from High to Needs Triage.

Yann removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

Yann updated the task description. (Show Details)

Yann added a subscriber: Aklapper.

I can reproduce this by copy-pasting the image from another article in VE edit mode.

matmarex renamed this task from VisualEditor should not add local "|link=https://..." links to file description when adding images to VisualEditor should not add local "|link=https://..." links to file description when copying images from another page.Aug 31 2018, 8:46 PM

matmarex added projects: VisualEditor-CopyPaste, VisualEditor-MediaWiki.

ssastry triaged this task as Medium priority.Jun 10 2019, 8:50 PM

ssastry edited projects, added Parsoid-Edit-Support; removed Parsoid.

ssastry moved this task from Backlog to Link syntax (links & media) on the Parsoid-Edit-Support board.

Just noticed this behaviour on dewiki: https://de.wikipedia.org/w/index.php?title=Kohlenstoff&type=revision&diff=192062719&oldid=191962285

Steps to reproduce:

start editing a page using VisualEditor
open another page with an image thumbnail in VisualEditor
select the image thumbnail on the second page and copy it to clipboard
go back to the first page and paste the copied thumbnail to it
when checking diff/wikitext, there will be the useless extra link to the image in the link= parameter

We will take a look at this ticket when we have a lull in feature work.

Change 535678 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Parse relative hrefs on image nodes like on regular links

https://gerrit.wikimedia.org/r/535678

gerritbot added a project: Patch-For-Review.Sep 10 2019, 7:28 PM

Change 535678 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Parse relative hrefs on image nodes like on regular links

https://gerrit.wikimedia.org/r/535678

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.2; 2019-10-15).Oct 11 2019, 4:00 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 11 2019, 4:10 PM

matmarex edited projects, added VisualEditor (Current work), Editing QA; removed VisualEditor.Oct 14 2019, 6:58 PM

matmarex moved this task from Incoming to QA on the VisualEditor (Current work) board.

Ryasmeen edited projects, added Verified; removed Editing QA.Oct 17 2019, 7:59 PM

Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.

matmarex mentioned this in T235707: VE not successfully loading on pages with video or audio embeds: "TypeError: href is null" from ve.dm.MWInternalLinkAnnotation.js:141:2.Oct 17 2019, 8:10 PM

matmarex mentioned this in T237040: Visual editor changing automatically something in text while saving.Oct 31 2019, 8:12 PM

The patch was reverted, it caused dirty diffs (T237040).

JTannerWMF edited projects, added Editing-team (Q3 2019-2020 Kanban Board); removed VisualEditor (Current work).Feb 5 2020, 12:05 AM

JTannerWMF moved this task from Needs Discussion / Investigation to Doing on the Editing-team (Q3 2019-2020 Kanban Board) board.

Restricted Application added a project: VisualEditor. · View Herald TranscriptFeb 5 2020, 12:05 AM

This hasn't been updated in a while and after chatting with @ppelberg in comparison with all of the work we have this isn't a high priority.

Aklapper edited projects, added Parsoid; removed Parsoid-Edit-Support.Feb 29 2020, 5:15 PM

Arlolra moved this task from Needs Triage to Backlog on the Parsoid board.Mar 2 2020, 4:27 PM

LGoto removed a project: Parsoid.May 8 2020, 4:23 PM

matmarex mentioned this in T257581: Visual Editor adds link= parameter to image when only caption is edited.Jul 9 2020, 6:22 PM

matmarex added a subtask: T108504: Parsoid/VE adds images with pointless link parameter.Aug 24 2020, 7:47 PM

ssastry closed subtask T108504: Parsoid/VE adds images with pointless link parameter as Resolved.Sep 17 2020, 12:16 AM

I'd like to try doing this again, the fix for T108504 should prevent the issue with dirty diffs from re-occurring.

matmarex edited projects, added Editing-team (Kanban Board); removed Editing-team, Verified, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15).Oct 29 2020, 7:59 PM

NicoV subscribed.Oct 30 2020, 6:41 PM

Change 637773 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Parse relative hrefs on image nodes like on regular links (try 2)

https://gerrit.wikimedia.org/r/637773

gerritbot added a project: Patch-For-Review.Oct 30 2020, 8:18 PM

matmarex moved this task from Inbox to Code Review on the Editing-team (Kanban Board) board.Oct 30 2020, 8:21 PM

Change 637773 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Parse relative hrefs on image nodes like on regular links (try 2)

https://gerrit.wikimedia.org/r/637773

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.33; 2021-03-02).Feb 24 2021, 6:00 PM

Maintenance_bot removed a project: Patch-For-Review.Feb 24 2021, 6:10 PM

matmarex added a project: Editing QA.Feb 24 2021, 6:47 PM

matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.

Ryasmeen edited projects, added Verified; removed Editing QA.Mar 4 2021, 10:25 PM

Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.

ppelberg closed this task as Resolved.Mar 6 2021, 1:59 AM

VisualEditor should not add local "|link=https://..." links to file description when copying images from another page
Closed, ResolvedPublic
Actions

Description

Details

Related Objects
Search...

Event Timeline

VisualEditor should not add local "|link=https://..." links to file description when copying images from another pageClosed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

VisualEditor should not add local "|link=https://..." links to file description when copying images from another page
Closed, ResolvedPublic
Actions

Related Objects
Search...