Page MenuHomePhabricator

Make publish/draft settings toolbar an OOUI toolbar
Open, NormalPublic

Description

Would make the styling consistent with the other toolbar, for example the custom dropdown:

and the button styling in Apex

are both inconsistent.

Event Timeline

Esanders created this task.Apr 27 2018, 3:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 27 2018, 3:50 PM

Change 429450 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/ContentTranslation@master] Convert publishSettings widget to a toolbar group

https://gerrit.wikimedia.org/r/429450

We may want to consider some of the aspects that we plan to include in the publish settings panel in the future (T133862 provides an overview, although designs may need to be iterated):

  • For destinations, provide an explanatory text for additional clarity. Knowing where the article will b created is an important decision, and namespace may be a complex concept for newcomers.
  • Provide access to help on the destination section. In case destinations are not clear, users can reach the documentation page and learn where they should publish and the implications.
  • Edit summary. In addition to the standard message used when publishing a translation for the edit summary to comply with attribution requirements, we want to let users to add some additional text to the edit summary (in-place or as part of a separate dialog).
  • Additional options to adjust the page creation further, with descriptions.

Would it be possible to support the above making the publish settings menu a toolbar? I'm not concerned about the purely styling changes, although I think there is value in making the selections more explicit with the use of radio buttons and checkboxes (maybe @Volker_E has some thoughts on that). I shared a mockup illustrating the initial design idea below:

Change 429450 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Convert publishSettings widget to a toolbar group

https://gerrit.wikimedia.org/r/429450

@Pginer-WMF What is the reason for it being a menu? Such rich menu seem counter-intuitive from our current UI library and most in-production combinations. This should rather be in a dialog from the example options given.

@Pginer-WMF What is the reason for it being a menu?
Such rich menu seem counter-intuitive from our current UI library and most in-production combinations. This should rather be in a dialog from the example options given.

This was intended to be a flyout panel: more detailed than a menu where you just select an option, but lighter that a modal dialog that blocks the user flow. Here is an example of the documentation of Windows platform guidelines where similar components are compared.

One question is whether we want to include such components as part of our guidelines. I think they bring the value to be more in-context, but I also understand the advantage of keeping the number of different components low, and a dialog can be a good solution for this case. I'll explore how this would work as a dialog. I'll continue such work on the main design ticket (T133862) where we can discuss the idea further.

Pginer-WMF triaged this task as Normal priority.May 4 2018, 11:57 AM
Pginer-WMF moved this task from Needs Triage to CX2 on the ContentTranslation board.
Vvjjkkii renamed this task from Make publish/draft settings toolbar an OOUI toolbar to 42daaaaaaa.Jul 1 2018, 1:13 AM
Vvjjkkii raised the priority of this task from Normal to High.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed subscribers: gerritbot, Aklapper.
CommunityTechBot renamed this task from 42daaaaaaa to Make publish/draft settings toolbar an OOUI toolbar.Jul 2 2018, 3:29 PM
CommunityTechBot lowered the priority of this task from High to Normal.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot added subscribers: gerritbot, Aklapper.