Page MenuHomePhabricator
Create Task
Maniphest T193339

Notice: Undefined index: 0 in /srv/mediawiki/php-1.32.0-wmf.1/extensions/AbuseFilter/includes/AbuseFilter.php on line 1498
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

We seem to get a few thousand of these per day. Seems wrong on several levels: something is calling AbuseFilter::takeConsequenceAction wrong (yay for completely undocumented public methods), but also why don't we have a type:mediawiki log event with a stack trace? And why is everything logged in duplicate? (one, two)

Details

SubjectRepoBranchLines +/-
Check if parameters are set instead of using strlenmediawiki/extensions/AbuseFilterREL1_31+1 -1
Check if parameters are set instead of using strlenmediawiki/extensions/AbuseFiltermaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Tgr created this task.Apr 29 2018, 9:37 AM
Restricted Application added subscribers: • OldUser02, Aklapper. · View Herald TranscriptApr 29 2018, 9:37 AM
Tgr mentioned this in T45086: Capture PHP warnings with stacktraces in MediaWiki and save to logstash.Apr 29 2018, 9:40 AM
Framawiki subscribed.Apr 29 2018, 11:31 AM
Daimona subscribed.Apr 29 2018, 4:39 PM

@Tgr Maybe T193324?

gerritbot subscribed.Apr 29 2018, 4:52 PM

Change 429659 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Check if parameters are set instead of using strlen

https://gerrit.wikimedia.org/r/429659

gerritbot added a project: Patch-For-Review.Apr 29 2018, 4:52 PM
Daimona added a comment.Apr 29 2018, 4:52 PM
In T193339#4166630, @Daimona wrote:

@Tgr Maybe T193324?

Not exactly, but caused by the same change.

gerritbot added a comment.Apr 30 2018, 6:10 AM

Change 429713 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@REL1_31] Check if parameters are set instead of using strlen

https://gerrit.wikimedia.org/r/429713

Daimona claimed this task.Apr 30 2018, 6:10 AM
gerritbot added a comment.May 1 2018, 2:26 AM

Change 429659 abandoned by Krinkle:
Check if parameters are set instead of using strlen

Reason:
Superseded by cbabcf1276da506abfa8187792d327c492078194

https://gerrit.wikimedia.org/r/429659

gerritbot added a comment.May 1 2018, 2:26 AM

Change 429713 abandoned by Krinkle:
Check if parameters are set instead of using strlen

Reason:
Superseded by https://gerrit.wikimedia.org/r/#/c/429999/

https://gerrit.wikimedia.org/r/429713

Krinkle closed this task as Resolved.May 1 2018, 2:27 AM
Krinkle added subscribers: Catrope, Krinkle.

Noticed and fixed independently by @Catrope in rEABFcbabcf1276da: Follow-up 392f37d516501fd: fix undefined index notice, which has since been deployed.

Daimona removed a project: Patch-For-Review.Jun 8 2018, 4:17 PM
• Vvjjkkii renamed this task from Notice: Undefined index: 0 in /srv/mediawiki/php-1.32.0-wmf.1/extensions/AbuseFilter/includes/AbuseFilter.php on line 1498 to s0daaaaaaa.Jul 1 2018, 1:13 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed Daimona as the assignee of this task.
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii edited projects, added CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish); removed AbuseFilter.
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
Daimona renamed this task from s0daaaaaaa to Notice: Undefined index: 0 in /srv/mediawiki/php-1.32.0-wmf.1/extensions/AbuseFilter/includes/AbuseFilter.php on line 1498.Jul 1 2018, 10:17 AM
Daimona closed this task as Resolved.
Daimona claimed this task.
Daimona raised the priority of this task from High to Needs Triage.
Daimona edited projects, added AbuseFilter; removed TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
Daimona updated the task description. (Show Details)
Daimona added subscribers: gerritbot, Aklapper.
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:09 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL