Page MenuHomePhabricator
Create Task
Maniphest T193352

Update librsvg to ≥2.42.3 (2.44.10)
Open, Stalled, MediumPublic
Actions

Assigned To
None
Authored By
Ebrahim
Apr 29 2018, 6:27 PM
Tags
Referenced Files
F31692374: image.png
Mar 19 2020, 4:43 PM
F31692371: image.png
Mar 19 2020, 4:43 PM
F17411508: out.png
Apr 29 2018, 6:27 PM
F17411512: out2.png
Apr 29 2018, 6:27 PM
F17411468: 001-grinning-face.svg
Apr 29 2018, 6:27 PM
Subscribers
• 4nn1l2
Ahecht
Aklapper
AntiCompositeNumber
DmitTrix
Ebrahim
Esanders
View All 25 Subscribers
Tokens
"Burninate" token, awarded by Volker_E."Burninate" token, awarded by Liuxinyu970226."Burninate" token, awarded by JoKalliauer.

Description

Steps to reproduce:

  1. Download this
    001-grinning-face.svg1 KBDownload
    and go to its path with terminal
  2. ssh tools-dev.wmflabs.org rsvg-convert <001-grinning-face.svg >out.png
  3. xdg-open out.png (or open out.png on macOS)

Actual:
It is broken with Wikimedia's librsvg, rsvg-convert version 2.40.2 (ssh tools-dev.wmflabs.org rsvg-convert -v)

out.png (48×48 px, 641 B)

Expected:

My local librsvg, rsvg-convert version 2.42.2, the result of rsvg-convert <001-grinning-face.svg >out.png

out2.png (48×48 px, 2 KB)

Update: After looking into it, it looks like backporting ≥2.42.3 in Debian stretch brings a long list of dependencies. This task is blocked until we upgrade Thumbor to Buster

Related Objects
Search...

StatusSubtypeAssignedTask
 StalledNoneT213139 Discrepancies in SVG Translate's pngs and Commons' versions in character and word spacings
 StalledNoneT36947 Incorrect text positioning in SVG rasterization (scale/transform; font-size; kerning)
 OpenBUG REPORTNoneT226318 Thumbnail rendering of complex SVG file leads to Error 500 or Error 429 instead of Error 408
 OpenNoneT200866 rsvg-convert times out while generating large thumbnails with heavy use of Gaussian blur
 OpenNoneT43371 Thumbnail/imagescaler (tracking)
 OpenNoneT88833 SVG thumbnail generator: relative font-size: smaller/larger not handled (text disappear)
 StalledNoneT200443 SVG text-anchor=end confused by tspan with following #text
 StalledNoneT43425 rsvg does not support the font shorthand style property
 StalledNoneT43423 CSS child selector not supported by rsvg
 StalledNoneT43422 rsvg cannot handle classes/ids with cyrillic alphabet when styling
 StalledNoneT7792 rsvg does not render baseline-shift correctly (<percentage> and <length>)
 OpenNoneT106240 Colorable SVG
 DuplicateBUG REPORTNoneT289236 SVG rendering bugs on a logo file
 StalledBUG REPORTNoneT271663 Offer to invert text-anchor for RTL languages
 StalledBUG REPORTNoneT316962 librsvg filter using FillPaint referencing a gradient fill does not work.
 StalledNoneT65236 Chinese text in SVG files misplaced and clustered
 StalledNoneT265549 Update librsvg to > 2.44.10
 DuplicateNoneT237539 429 error when requesting certain image resolutions on Commons
 StalledNoneT64987 librsvg misinterpret quoted font family names that contain whitespaces
 StalledNoneT143086 SVG thumbnailing: radialGradient get ruined (striped)
 OpenNoneT32033 stroke-dasharray in PNG thumbnails does not support spaces as separators
 StalledNoneT214738 Several thumbnail sizes of SVG with large gradientTransform fail
 DuplicateNoneT205776 Punjabi letters in SVG files have unnecessary spacing in their corresponding PNG thumbnails
 OpenNoneT215823 librsvg handles errors in path data incorrectly
 DuplicateNoneT208123 HTTP 500 error trying to render an SVG file (2048x2048px; 2.9MB) to a large PNG thumbnail
 StalledNoneT217268 blur not applied to rotated clones
 StalledNoneT253947 SVG elements with feConvolveMatrix not rendered
 DuplicateBUG REPORTNoneT252672 PNG thumbnail of a specific SVG files not generated correctly
 StalledNoneT217990 arc flags without space
 OpenBUG REPORTNoneT246366 update librsvg for correct dash-density
 StalledNoneT229666 librsvg has broken attribute handling for masks
 OpenBUG REPORTNoneT228321 librsvg ignores functional URLs that use single quotation marks
 StalledNoneT194582 filter="url(#a)" (feGaussianBlur) does not work in combination with transform="matrix(-1 0 0 -1 0 0)"
 StalledNoneT68551 CSS class are not inherited to child text/tspan elements in SVG (not general)
 StalledNoneT55899 SVG masks (opacity gradient / transparency) fail to render (or even display)
 StalledNoneT46016 SVG fails to render properly due to several issues
 StalledNoneT8250 PNG replacement image for .SVG does not show transparency gradient correctly
 StalledBUG REPORTNoneT294843 BackgroundImage filter antialiasing pixel artifacts
 InvalidNoneT43426 hsl colors not supported by rsvg
 StalledBUG REPORTNoneT304209 SVG `<style` element ignored if put at the end
 StalledBUG REPORTNoneT316165 librsvg mishandles newlines when xml:space=preserve
 StalledNoneT193352 Update librsvg to ≥2.42.3 (2.44.10)
 ResolvedNoneT68672 SVG style element ignored if no type attribute is specified
 OpenNoneT216815 Upgrade Thumbor to Buster
 InvalidNoneT212941 Investigate systemd hardening to replace Firejail for Thumbor
 ResolvedfgiunchediT212946 Stream Thumbor logs to logstash
 Resolved• GillesT187765 Replace the Nginx fronting Thumbor with Haproxy
 ResolvedfgiunchediT204266 Backport prometheus haproxy exporter for Jessie
 ResolvedjijikiT220499 Export useful metrics from haproxy logs for Thumbor
 ResolvedNoneT216892 Santali font shown as square boxes in thumbnail version of a specific SVG file
 ResolvedjijikiT221562 Build Thumbor packages for buster
 OpenNoneT40010 RFC: Re-evaluate librsvg as SVG renderer on Wikimedia wikis
 DuplicateNoneT56030 Support PhantomJS as an SVG rasterizer/renderer option

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Esanders added a comment.Mar 19 2020, 4:43 PM

Most of the icons in the OOUI library, which are just simple black and white paths compressed by SVGO, won't convert correctly on the live servers:

image.png (507×704 px, 32 KB)

They work fine for me locally with 2.44.14:

image.png (495×700 px, 31 KB)

As SVGO is used in more and more tools and workflows this is only going to get worse.

Jdforrester-WMF added a subscriber: Jdforrester-WMF.Mar 19 2020, 4:46 PM

AFAICT this entire task stack is the wrong way around? We can't do this upgrade until T216815 is done, and all of the "sub-tasks" are mostly different aspects of duplicates of this one, and so should be parents/blocked by this one, right?

JoKalliauer added a comment.Mar 19 2020, 4:59 PM

@Esanders : Your bug is imho T217990 and can be fixed using https://tools.wmflabs.org/svgworkaroundbot/ (activate "run svgcleaner"). It is related to missing spaces between arc-to-flags. That is a common SVGO problem, you should try https://github.com/scour-project/scour and https://github.com/RazrFalcon/svgcleaner instead, which are imho less buggy and sometimes even offer woraounds for librsvg-bugs. (so they often repair svgs; and hardly break them)

Esanders added a comment.Mar 26 2020, 9:52 PM

That is a common SVGO problem

Is SVGO actually violating the spec, or is this just a bug in librsvg?

JoKalliauer added a comment.Mar 26 2020, 10:46 PM
In T193352#6003571, @Esanders wrote:

That is a common SVGO problem

Is SVGO actually violating the spec, or is this just a bug in librsvg?

SVGO removes spaces between flags, which are not necesarry since flags can only be 0 or 1, so it is imho a librsvg-bug, see https://github.com/svg/svgo/issues/822 for details. It is similar as removing spaces before dots (.) or minuses (-).

Inkscape, Chrome, Firefox, resvg can handle them imho without problems, but librsvg not. Also most software understand them, hardly anyone (except svgo) removes those spaces, also removing is imho allowed.

But I do not know the W3C-SVG-1.1-DTD-Specifications, so I might be wrong.

Esanders added a comment.EditedMay 4 2020, 11:23 AM

Thanks, sounds like this isn't an SVGO problem, but a librsvg problem. Those fixes are workarounds, but the correct fix here is to upgrade librsvg.

Esanders mentioned this in T179154: Have a way to export and update Wikimedia Design System (Codex, OOUI) icons on Commons.May 4 2020, 11:24 AM
AntiCompositeNumber mentioned this in T200866: rsvg-convert times out while generating large thumbnails with heavy use of Gaussian blur.May 14 2020, 1:01 AM
AntiCompositeNumber added a parent task: T200866: rsvg-convert times out while generating large thumbnails with heavy use of Gaussian blur.
AntiCompositeNumber added a parent task: T237539: 429 error when requesting certain image resolutions on Commons.May 14 2020, 4:00 AM
AntiCompositeNumber removed a subtask: T64987: librsvg misinterpret quoted font family names that contain whitespaces.May 14 2020, 4:04 AM
AntiCompositeNumber added a parent task: T64987: librsvg misinterpret quoted font family names that contain whitespaces.
AntiCompositeNumber removed a subtask: T143086: SVG thumbnailing: radialGradient get ruined (striped).May 14 2020, 4:08 AM
AntiCompositeNumber added a parent task: T143086: SVG thumbnailing: radialGradient get ruined (striped).
AntiCompositeNumber removed a subtask: T32033: stroke-dasharray in PNG thumbnails does not support spaces as separators.May 14 2020, 4:10 AM
AntiCompositeNumber added a parent task: T32033: stroke-dasharray in PNG thumbnails does not support spaces as separators.
AntiCompositeNumber removed a subtask: T214738: Several thumbnail sizes of SVG with large gradientTransform fail.May 14 2020, 4:17 AM
AntiCompositeNumber added a parent task: T214738: Several thumbnail sizes of SVG with large gradientTransform fail.
AntiCompositeNumber removed a subtask: T162263: PNG thumbnail of a specific SVG file uploaded to Commons is clipped / cut at some sides.May 14 2020, 4:22 AM
AntiCompositeNumber removed a subtask: T184578: Colors missing in SVG thumbnail.May 14 2020, 4:29 AM
AntiCompositeNumber removed a subtask: T36947: Incorrect text positioning in SVG rasterization (scale/transform; font-size; kerning).
AntiCompositeNumber added a parent task: T36947: Incorrect text positioning in SVG rasterization (scale/transform; font-size; kerning).May 14 2020, 4:31 AM
AntiCompositeNumber removed a subtask: T205776: Punjabi letters in SVG files have unnecessary spacing in their corresponding PNG thumbnails.May 14 2020, 4:35 AM
AntiCompositeNumber added a parent task: T205776: Punjabi letters in SVG files have unnecessary spacing in their corresponding PNG thumbnails.
AntiCompositeNumber removed a subtask: T215823: librsvg handles errors in path data incorrectly.May 14 2020, 4:38 AM
AntiCompositeNumber added a parent task: T215823: librsvg handles errors in path data incorrectly.
AntiCompositeNumber removed a parent task: T216815: Upgrade Thumbor to Buster.May 14 2020, 4:47 AM
AntiCompositeNumber added a subtask: T216815: Upgrade Thumbor to Buster.
AntiCompositeNumber added a subscriber: AntiCompositeNumber.
In T193352#5984551, @Jdforrester-WMF wrote:

AFAICT this entire task stack is the wrong way around? We can't do this upgrade until T216815 is done, and all of the "sub-tasks" are mostly different aspects of duplicates of this one, and so should be parents/blocked by this one, right?

Agreed, fixed (I think).

AntiCompositeNumber added a parent task: T208123: HTTP 500 error trying to render an SVG file (2048x2048px; 2.9MB) to a large PNG thumbnail.May 14 2020, 5:44 AM
AntiCompositeNumber added a parent task: T217268: blur not applied to rotated clones.May 15 2020, 1:05 AM
AntiCompositeNumber added a parent task: T253947: SVG elements with feConvolveMatrix not rendered.May 29 2020, 3:56 PM
AntiCompositeNumber added a project: Thumbor.May 29 2020, 4:07 PM
AntiCompositeNumber moved this task from Backlog to Upstream (librsvg) on the Thumbor board.
AntiCompositeNumber added a parent task: T252672: PNG thumbnail of a specific SVG files not generated correctly.Jun 13 2020, 7:37 PM
toorich changed the task status from Stalled to Open.Jun 24 2020, 9:58 AM
toorich added a subscriber: toorich.

Because of a lot of thumbnail error, I think now can re-open this task.

toorich added a comment.Jun 24 2020, 10:01 AM
This comment was removed by toorich.
Aklapper changed the task status from Open to Stalled.Jun 24 2020, 10:34 AM

@toorich: This has nothing to do with "lots of thumbnail errors". See previous comments that this is stalled on upgrading Debian versions on Wikimedia servers.

Aklapper mentioned this in T125710: systemLanguage process issues in SVG.php.Aug 25 2020, 6:34 PM
• Ladsgroup mentioned this in T259906: Add 'volumeUp', 'volumeDown' and 'volumeMute' icons in Design Style Guide & OOUI.Oct 8 2020, 9:23 AM
Volker_E added a subscriber: Volker_E.Oct 8 2020, 1:33 PM
AntiCompositeNumber added a parent task: T217990: arc flags without space.Oct 14 2020, 4:01 PM
AntiCompositeNumber renamed this task from Update librsvg to ≥2.42.3 to Update librsvg to ≥2.42.3 (2.44.10).Oct 14 2020, 5:26 PM
AntiCompositeNumber added a parent task: T246366: update librsvg for correct dash-density.Oct 14 2020, 5:40 PM
AntiCompositeNumber added a parent task: T245864: xml:space="preserve" with text-align:end handled wrong.Oct 14 2020, 6:00 PM
AntiCompositeNumber removed a parent task: T245864: xml:space="preserve" with text-align:end handled wrong.
AntiCompositeNumber added a parent task: T229666: librsvg has broken attribute handling for masks.Oct 14 2020, 6:10 PM
AntiCompositeNumber added a parent task: T228321: librsvg ignores functional URLs that use single quotation marks.Oct 14 2020, 6:21 PM
AntiCompositeNumber added a parent task: T194582: filter="url(#a)" (feGaussianBlur) does not work in combination with transform="matrix(-1 0 0 -1 0 0)".Oct 14 2020, 6:27 PM
AntiCompositeNumber added a parent task: T88833: SVG thumbnail generator: relative font-size: smaller/larger not handled (text disappear).Oct 14 2020, 8:35 PM
AntiCompositeNumber added a parent task: T68551: CSS class are not inherited to child text/tspan elements in SVG (not general).Oct 14 2020, 8:37 PM
AntiCompositeNumber added a parent task: T55899: SVG masks (opacity gradient / transparency) fail to render (or even display).Oct 14 2020, 8:41 PM
AntiCompositeNumber added a parent task: T46016: SVG fails to render properly due to several issues.Oct 14 2020, 8:47 PM
AntiCompositeNumber added a parent task: T8250: PNG replacement image for .SVG does not show transparency gradient correctly.Oct 14 2020, 9:33 PM
AntiCompositeNumber added a parent task: T265549: Update librsvg to > 2.44.10.Oct 14 2020, 9:42 PM
AntiCompositeNumber added a comment.Oct 19 2020, 5:08 PM

T154237: SVG image wikisyntax can't use "lang=zh-hant" has indicated that this update may introduce a regression in the handling of some languages in <switch>-translated SVGs.

Volker_E awarded a token.Nov 2 2020, 9:30 AM
AntiCompositeNumber mentioned this in T270209: Image fails to load with CORS violation.Dec 18 2020, 9:30 PM
JoKalliauer mentioned this in T276684: direct clone of a element not displayed.Mar 6 2021, 7:25 PM
DmitTrix added a subscriber: DmitTrix.Mar 6 2021, 11:02 PM
Glrx added a subscriber: Glrx.Apr 10 2021, 2:44 AM
JoKalliauer mentioned this in T281027: Unicode-Character 🤣 not rendered in SVG.Apr 24 2021, 11:03 AM
JoKalliauer mentioned this in T280718: Re-evaluate whether keeping around https://noc.wikimedia.org/conf/fc-list is a good practive.Apr 24 2021, 1:56 PM
JoKalliauer mentioned this in T253947: SVG elements with feConvolveMatrix not rendered.May 9 2021, 12:35 PM
JoKalliauer mentioned this in T282740: evaluate priorities of Wikimedia-svg-rendering-tasks .May 12 2021, 8:09 PM
JoKalliauer mentioned this in T283083: [Session] RFC: Re-evaluate librsvg as SVG renderer on Wikimedia wikis .May 22 2021, 4:35 PM
Ricordisamoa added a subscriber: Ricordisamoa.Jun 7 2021, 6:01 PM
JoKalliauer moved this task from Backlog to update librsvg on the Wikimedia-SVG-rendering board.Jun 30 2021, 3:12 PM
Aklapper mentioned this in T289765: SVG paint-order property doesn't works in SVG renderer.Aug 26 2021, 10:03 AM
JoKalliauer added a parent task: T294843: BackgroundImage filter antialiasing pixel artifacts.Nov 2 2021, 3:01 PM
JoKalliauer added a subtask: T40010: RFC: Re-evaluate librsvg as SVG renderer on Wikimedia wikis.Nov 3 2021, 9:50 PM
JoKalliauer removed a parent task: T36947: Incorrect text positioning in SVG rasterization (scale/transform; font-size; kerning).
Leksey removed a subscriber: Leksey.Nov 4 2021, 1:54 AM
Ahecht added a subscriber: Ahecht.Dec 16 2021, 3:33 PM
JoKalliauer added a parent task: T43426: hsl colors not supported by rsvg.Dec 20 2021, 9:21 PM
Xeriphas1994 added a subscriber: Xeriphas1994.Feb 8 2022, 8:23 PM
• 4nn1l2 added a subscriber: • 4nn1l2.Feb 15 2022, 8:27 PM
JoKalliauer added a parent task: T304209: SVG `<style` element ignored if put at the end.Mar 19 2022, 9:08 PM
Aklapper mentioned this in T302419: Images on the front page need special handling to make sure they can render..Mar 22 2022, 2:18 PM
Krinkle mentioned this in T216815: Upgrade Thumbor to Buster.Aug 11 2022, 8:39 PM
RanD added a subscriber: RanD.Aug 19 2022, 11:26 PM
Mathglot added a subscriber: Mathglot.Aug 20 2022, 9:19 PM
Aklapper added a parent task: T316165: librsvg mishandles newlines when xml:space=preserve.Aug 25 2022, 5:23 AM
Aklapper removed a project: Upstream.Oct 5 2022, 12:05 PM
Aklapper removed a subscriber: • Krassotkin.
Aklapper mentioned this in T319377: SVG <use> element with href attribute not displayed.Oct 5 2022, 4:22 PM
Mathglot removed a subscriber: Mathglot.Oct 5 2022, 5:03 PM
jbond edited projects, added Packaging; removed SRE.Nov 2 2022, 12:49 PM
Restricted Application added a project: Infrastructure-Foundations. · View Herald TranscriptNov 2 2022, 12:49 PM
MoritzMuehlenhoff added a comment.Nov 2 2022, 2:53 PM

Removing Packaging and Infrastructure-Foundations, 2.44.10 is included in Buster, which is the version Thumbor is currently being migrated to in Kubernetes.

MoritzMuehlenhoff removed projects: Packaging, Infrastructure-Foundations.Nov 2 2022, 2:53 PM
JoKalliauer added projects: Epic, Technical-Debt.Dec 20 2022, 7:38 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL