Page MenuHomePhabricator
Create Task
Maniphest T193352

Update librsvg to ≥2.42.3 (2.44.10)
Closed, ResolvedPublic
Actions

Assigned To
hnowlan
Authored By
Ebrahim
Apr 29 2018, 6:27 PM
Project Tags
Referenced Files
F31692374: image.png
Mar 19 2020, 4:43 PM
F31692371: image.png
Mar 19 2020, 4:43 PM
F17411508: out.png
Apr 29 2018, 6:27 PM
F17411512: out2.png
Apr 29 2018, 6:27 PM
F17411468: 001-grinning-face.svg
Apr 29 2018, 6:27 PM
Subscribers
• 4nn1l2
Ahecht
Aklapper
AntiCompositeNumber
Arthur2e5
DmitTrix
Ebrahim
View All 26 Subscribers

Description

T112421: Update rsvg on the image scalers to 2.40.16 (to solve several SVG rendering issues) | T265549: Update librsvg to version > 2.44.10 (2.50.3)
Steps to reproduce:

  1. Download this F17411468 and go to its path with terminal
  2. ssh tools-dev.wmflabs.org rsvg-convert <001-grinning-face.svg >out.png
  3. xdg-open out.png (or open out.png on macOS)

Actual:
It is broken with Wikimedia's librsvg, rsvg-convert version 2.40.2 (ssh tools-dev.wmflabs.org rsvg-convert -v)

out.png (48×48 px, 641 B)

Expected:

My local librsvg, rsvg-convert version 2.42.2, the result of rsvg-convert <001-grinning-face.svg >out.png

out2.png (48×48 px, 2 KB)

Update: After looking into it, it looks like backporting ≥2.42.3 in Debian stretch brings a long list of dependencies. This task is blocked until we upgrade Thumbor to Buster

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT43371 Thumbnail/imagescaler (tracking)
 ResolvedTheDJT88833 SVG thumbnail generator: relative font-size: smaller/larger not handled (text disappear)
 ResolvedhnowlanT213139 Discrepancies in SVG Translate's pngs and Commons' versions in character and word spacings
 ResolvedJoKalliauerT36947 Incorrect text positioning in SVG rasterization (scale/transform; font-size; kerning)
 DuplicateNoneT237539 429 error when requesting certain image resolutions on Commons
 ResolvedJoKalliauerT64987 librsvg misinterpret quoted font family names that contain whitespaces
 ResolvedJoKalliauerT143086 SVG thumbnailing: radialGradient get ruined (striped)
 ResolvedhnowlanT32033 stroke-dasharray in PNG thumbnails does not support spaces as separators
 DuplicateNoneT205776 Punjabi letters in SVG files have unnecessary spacing in their corresponding PNG thumbnails
 ResolvedTheDJT215823 librsvg handles errors in path data incorrectly
 ResolvedTheDJT217268 blur not applied to rotated clones
 ResolvedTheDJT253947 SVG elements with feConvolveMatrix not rendered
 DuplicateBUG REPORTNoneT252672 PNG thumbnail of a SVG files containing arc flags not generated correctly
 ResolvedTheDJT217990 arc flags without space
 ResolvedBUG REPORTTheDJT246366 update librsvg for correct dash-density
 ResolvedTheDJT229666 librsvg has broken attribute handling for masks
 ResolvedBUG REPORTTheDJT228321 librsvg ignores functional URLs that use single quotation marks
 ResolvedTheDJT194582 filter="url(#a)" (feGaussianBlur) does not work in combination with transform="matrix(-1 0 0 -1 0 0)"
 ResolvedJoKalliauerT68551 CSS class are not inherited to child text/tspan elements in SVG (not general)
 ResolvedTheDJT55899 SVG masks (opacity gradient / transparency) fail to render (or even display)
 ResolvedTheDJT8250 PNG replacement image for .SVG does not show transparency gradient correctly
 InvalidNoneT43426 hsl colors not supported by rsvg
 ResolvedBUG REPORTTheDJT316165 librsvg mishandles newlines when xml:space=preserve
 DuplicateBUG REPORTNoneT289236 SVG rendering bugs on a logo file
 ResolvedNoneT68672 SVG style element ignored if no type attribute is specified
 ResolvedhnowlanT193352 Update librsvg to ≥2.42.3 (2.44.10)
 ResolvedhnowlanT216815 Upgrade Thumbor to Buster
 InvalidNoneT212941 Investigate systemd hardening to replace Firejail for Thumbor
 ResolvedfgiunchediT212946 Stream Thumbor logs to logstash
 Resolved• GillesT187765 Replace the Nginx fronting Thumbor with Haproxy
 ResolvedfgiunchediT204266 Backport prometheus haproxy exporter for Jessie
 ResolvedjijikiT220499 Export useful metrics from haproxy logs for Thumbor
 ResolvedjijikiT221562 Build Thumbor packages for buster

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
AntiCompositeNumber added a parent task: T215823: librsvg handles errors in path data incorrectly.May 14 2020, 4:38 AM
AntiCompositeNumber removed a parent task: T216815: Upgrade Thumbor to Buster.May 14 2020, 4:47 AM
AntiCompositeNumber added a subtask: T216815: Upgrade Thumbor to Buster.
AntiCompositeNumber subscribed.
In T193352#5984551, @Jdforrester-WMF wrote:

AFAICT this entire task stack is the wrong way around? We can't do this upgrade until T216815 is done, and all of the "sub-tasks" are mostly different aspects of duplicates of this one, and so should be parents/blocked by this one, right?

Agreed, fixed (I think).

AntiCompositeNumber added a parent task: T208123: HTTP 500 error trying to render an SVG file (2048x2048px; 2.9MB) to a large PNG thumbnail.May 14 2020, 5:44 AM
AntiCompositeNumber added a parent task: T217268: blur not applied to rotated clones.May 15 2020, 1:05 AM
AntiCompositeNumber added a parent task: T253947: SVG elements with feConvolveMatrix not rendered.May 29 2020, 3:56 PM
AntiCompositeNumber added a project: Thumbor.May 29 2020, 4:07 PM
AntiCompositeNumber moved this task from Backlog to Upstream (librsvg) on the Thumbor board.
AntiCompositeNumber added a parent task: T252672: PNG thumbnail of a SVG files containing arc flags not generated correctly.Jun 13 2020, 7:37 PM
toorich changed the task status from Stalled to Open.Jun 24 2020, 9:58 AM
toorich subscribed.

Because of a lot of thumbnail error, I think now can re-open this task.

toorich added a comment.Jun 24 2020, 10:01 AM
This comment was removed by toorich.
Aklapper changed the task status from Open to Stalled.Jun 24 2020, 10:34 AM

@toorich: This has nothing to do with "lots of thumbnail errors". See previous comments that this is stalled on upgrading Debian versions on Wikimedia servers.

Aklapper mentioned this in T125710: systemLanguage process issues in SVG.php.Aug 25 2020, 6:34 PM
Ladsgroup mentioned this in T259906: Add 'volumeUp', 'volumeDown' and 'volumeMute' icons in Design Style Guide & OOUI.Oct 8 2020, 9:23 AM
Volker_E subscribed.Oct 8 2020, 1:33 PM
AntiCompositeNumber added a parent task: T217990: arc flags without space.Oct 14 2020, 4:01 PM
AntiCompositeNumber renamed this task from Update librsvg to ≥2.42.3 to Update librsvg to ≥2.42.3 (2.44.10).Oct 14 2020, 5:26 PM
AntiCompositeNumber added a parent task: T246366: update librsvg for correct dash-density.Oct 14 2020, 5:40 PM
AntiCompositeNumber added a parent task: T245864: xml:space="preserve" with text-align:end handled wrong.Oct 14 2020, 6:00 PM
AntiCompositeNumber removed a parent task: T245864: xml:space="preserve" with text-align:end handled wrong.
AntiCompositeNumber added a parent task: T229666: librsvg has broken attribute handling for masks.Oct 14 2020, 6:10 PM
AntiCompositeNumber added a parent task: T228321: librsvg ignores functional URLs that use single quotation marks.Oct 14 2020, 6:21 PM
AntiCompositeNumber added a parent task: T194582: filter="url(#a)" (feGaussianBlur) does not work in combination with transform="matrix(-1 0 0 -1 0 0)".Oct 14 2020, 6:27 PM
AntiCompositeNumber added a parent task: T88833: SVG thumbnail generator: relative font-size: smaller/larger not handled (text disappear).Oct 14 2020, 8:35 PM
AntiCompositeNumber added a parent task: T68551: CSS class are not inherited to child text/tspan elements in SVG (not general).Oct 14 2020, 8:37 PM
AntiCompositeNumber added a parent task: T55899: SVG masks (opacity gradient / transparency) fail to render (or even display).Oct 14 2020, 8:41 PM
AntiCompositeNumber added a parent task: T46016: SVG fails to render properly due to several issues.Oct 14 2020, 8:47 PM
AntiCompositeNumber added a parent task: T8250: PNG replacement image for .SVG does not show transparency gradient correctly.Oct 14 2020, 9:33 PM
AntiCompositeNumber added a parent task: T265549: Update librsvg to version > 2.44.10 (2.50.3).Oct 14 2020, 9:42 PM
AntiCompositeNumber added a comment.Oct 19 2020, 5:08 PM

T154237: SVG image wikisyntax incorrectly shows zh-hans for "lang=zh-hant" has indicated that this update may introduce a regression in the handling of some languages in <switch>-translated SVGs.

Volker_E awarded a token.Nov 2 2020, 9:30 AM
AntiCompositeNumber mentioned this in T270209: Image fails to load with CORS violation.Dec 18 2020, 9:30 PM
JoKalliauer mentioned this in T276684: direct clone of a element not displayed.Mar 6 2021, 7:25 PM
DmitTrix subscribed.Mar 6 2021, 11:02 PM
Glrx subscribed.Apr 10 2021, 2:44 AM
JoKalliauer mentioned this in T281027: Unicode-Character 🤣 not rendered in SVG.Apr 24 2021, 11:03 AM
JoKalliauer mentioned this in T280718: Re-evaluate whether keeping around https://noc.wikimedia.org/conf/fc-list is a good practice.Apr 24 2021, 1:56 PM
JoKalliauer mentioned this in T253947: SVG elements with feConvolveMatrix not rendered.May 9 2021, 12:35 PM
JoKalliauer mentioned this in T282740: evaluate priorities of Wikimedia-svg-rendering-tasks .May 12 2021, 8:09 PM
JoKalliauer mentioned this in T283083: [Session] RFC: Re-evaluate librsvg as SVG renderer on Wikimedia wikis .May 22 2021, 4:35 PM
Ricordisamoa subscribed.Jun 7 2021, 6:01 PM
JoKalliauer moved this task from Backlog to update librsvg on the Wikimedia-SVG-rendering board.Jun 30 2021, 3:12 PM
Aklapper mentioned this in T289765: SVG paint-order property doesn't works in SVG renderer.Aug 26 2021, 10:03 AM
JoKalliauer added a parent task: T294843: BackgroundImage filter antialiasing pixel artifacts.Nov 2 2021, 3:01 PM
JoKalliauer added a subtask: T40010: RFC: Re-evaluate librsvg as SVG renderer on Wikimedia wikis.Nov 3 2021, 9:50 PM
JoKalliauer removed a parent task: T36947: Incorrect text positioning in SVG rasterization (scale/transform; font-size; kerning).
Leksey unsubscribed.Nov 4 2021, 1:54 AM
Ahecht subscribed.Dec 16 2021, 3:33 PM
JoKalliauer added a parent task: T43426: hsl colors not supported by rsvg.Dec 20 2021, 9:21 PM
Xeriphas1994 subscribed.Feb 8 2022, 8:23 PM
• 4nn1l2 subscribed.Feb 15 2022, 8:27 PM
JoKalliauer added a parent task: T304209: SVG `<style` element ignored if put at the end.Mar 19 2022, 9:08 PM
Aklapper mentioned this in T302419: Images on the front page need special handling to make sure they can render..Mar 22 2022, 2:18 PM
Krinkle mentioned this in T216815: Upgrade Thumbor to Buster.Aug 11 2022, 8:39 PM
RanD subscribed.Aug 19 2022, 11:26 PM
Mathglot subscribed.Aug 20 2022, 9:19 PM
Aklapper added a parent task: T316165: librsvg mishandles newlines when xml:space=preserve.Aug 25 2022, 5:23 AM
Aklapper removed a project: Upstream.Oct 5 2022, 12:05 PM
Aklapper removed a subscriber: • Krassotkin.
Aklapper mentioned this in T319377: SVG <use> element with href attribute not displayed.Oct 5 2022, 4:22 PM
Mathglot unsubscribed.Oct 5 2022, 5:03 PM
jbond edited projects, added: Packaging; removed: SRE.Nov 2 2022, 12:49 PM
Restricted Application added a project: Infrastructure-Foundations. · View Herald TranscriptNov 2 2022, 12:49 PM
MoritzMuehlenhoff added a comment.Nov 2 2022, 2:53 PM

Removing Packaging and Infrastructure-Foundations, 2.44.10 is included in Buster, which is the version Thumbor is currently being migrated to in Kubernetes.

MoritzMuehlenhoff removed projects: Packaging, Infrastructure-Foundations.Nov 2 2022, 2:53 PM
JoKalliauer added projects: Epic, Technical-Debt.Dec 20 2022, 7:38 PM
Ladsgroup mentioned this in T331138: FileBackendMultiWrite multi-dc and thumbnail handling.Apr 21 2023, 8:19 AM
hnowlan closed this task as Resolved.May 17 2023, 11:36 AM
hnowlan claimed this task.

Thumbor is now running on buster and using 2.44.10

hnowlan mentioned this in T207506: librsvg does not shift from bold to normal font-weight.May 17 2023, 12:05 PM
Ladsgroup added a comment.May 17 2023, 2:15 PM

Macro itshappening:

TheDJ removed a parent task: T46016: SVG fails to render properly due to several issues.May 17 2023, 2:24 PM
Ahecht added a comment.May 17 2023, 3:28 PM

Fun fact: 2.44.10 is older now (4.5 years) than 2.40.2 was when this task was first opened (4.1 years).

hnowlan closed subtask T216815: Upgrade Thumbor to Buster as Resolved.May 17 2023, 3:47 PM
Ladsgroup added a comment.May 17 2023, 4:03 PM
In T193352#8859769, @Ahecht wrote:

Fun fact: 2.44.10 is older now (4.5 years) than 2.40.2 was when this task was first opened (4.1 years).

T336881: [XL] Upgrade Thumbor to bullseye Let's hope this one doesn't take a couple more years (with k8s, it should be easier)

Izno added a parent task: T36947: Incorrect text positioning in SVG rasterization (scale/transform; font-size; kerning).May 17 2023, 11:21 PM
Izno removed a subtask: T40010: RFC: Re-evaluate librsvg as SVG renderer on Wikimedia wikis.
Izno added a parent task: T289236: SVG rendering bugs on a logo file.May 17 2023, 11:23 PM
JoKalliauer removed a parent task: T214738: Several thumbnail sizes of SVG with large gradientTransform fail.May 18 2023, 2:58 AM
JoKalliauer removed a parent task: T208123: HTTP 500 error trying to render an SVG file (2048x2048px; 2.9MB) to a large PNG thumbnail.May 18 2023, 1:17 PM
JoKalliauer removed a parent task: T200866: rsvg-convert times out while generating large thumbnails with heavy use of Gaussian blur.May 18 2023, 1:19 PM
JoKalliauer removed a parent task: T304209: SVG `<style` element ignored if put at the end.May 19 2023, 11:48 AM
Arthur2e5 subscribed.May 20 2023, 3:54 PM

It's done? Cool. Now to remove these ugly hacks from all the SVGs that have piled up...

Izno removed a parent task: T265549: Update librsvg to version > 2.44.10 (2.50.3).Aug 8 2023, 11:01 PM
Izno removed a subtask: T68672: SVG style element ignored if no type attribute is specified.Aug 8 2023, 11:03 PM
Izno added a parent task: T68672: SVG style element ignored if no type attribute is specified.
Izno removed a parent task: T294843: BackgroundImage filter antialiasing pixel artifacts.Mar 24 2024, 4:29 PM
zdev mentioned this in T265549: Update librsvg to version > 2.44.10 (2.50.3).Sun, Sep 13, 10:24 AM
zdev updated the task description. (Show Details)Sun, Sep 13, 10:27 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits