Maniphest T193375

Use the problems' dedicated page instead of tags to show actions which hit the condition limit
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	Daimona
	Apr 30 2018, 6:34 AM

Description

Right now we use a tag to identify such actions, and that is great. However, as we'll have a dedicated AF page to show problematic executions (slow ones and the ones which had a runtime error) it would make more sense to move this info there.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Use /problems together with tagging for actions which hit the conds limit	mediawiki/extensions/AbuseFilter	master	+31 -12

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T209023 Major overhaul for AbuseFilter
Open	None	T193064 Create a dedicated page for stats
Resolved	Daimona	T193374 Mass actions always reach condition limit
Open	None	T193375 Use the problems' dedicated page instead of tags to show actions which hit the condition limit

Event Timeline

Daimona created this task.Apr 30 2018, 6:34 AM

Restricted Application added subscribers: • OldUser02, Aklapper. · View Herald TranscriptApr 30 2018, 6:34 AM

Daimona added a parent task: T193374: Mass actions always reach condition limit.Apr 30 2018, 6:34 AM

Daimona added a parent task: T193064: Create a dedicated page for stats.

Change 429731 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Use /problems instead of tagging for actions which hit the conds limit

https://gerrit.wikimedia.org/r/429731

gerritbot added a project: Patch-For-Review.Apr 30 2018, 7:54 AM

The tagging was meant not only to help maintainers, but also patrollers. If an edit reaches the limit, no additional checks are executed and a potentionally bad edit might have gone through. Is there any problem with keeping this feature?

In T193375#4167917, @matej_suchanek wrote:

The tagging was meant not only to help maintainers, but also patrollers. If an edit reaches the limit, no additional checks are executed and a potentionally bad edit might have gone through. Is there any problem with keeping this feature?

@matej_suchanek I didn't think about that. I guess there's no problem in keeping it, I'll just edit the patch so that it won't remove existing code. The real problem here is for mass actions per parent task.

Daimona claimed this task.Apr 30 2018, 5:21 PM

• Vvjjkkii renamed this task from Use the problems' dedicated page instead of tags to show actions which hit the condition limit to szdaaaaaaa.Jul 1 2018, 1:13 AM

• Vvjjkkii removed Daimona as the assignee of this task.

• Vvjjkkii triaged this task as High priority.

• Vvjjkkii edited projects, added CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish); removed AbuseFilter.

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed subscribers: gerritbot, Aklapper.

Daimona renamed this task from szdaaaaaaa to Use the problems' dedicated page instead of tags to show actions which hit the condition limit.Jul 1 2018, 12:50 PM

Daimona claimed this task.

Daimona raised the priority of this task from High to Needs Triage.

Daimona edited projects, added AbuseFilter; removed TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

Daimona updated the task description. (Show Details)

Daimona added subscribers: gerritbot, Aklapper.

Aklapper edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Oct 15 2020, 12:57 PM

Removing task assignee due to inactivity, as this open task has been assigned to the same person for more than two years (see the emails sent to the task assignee on Oct27 and Nov23). Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome.
(See https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator.)

Change #429731 abandoned by Daimona Eaytoy:

[mediawiki/extensions/AbuseFilter@master] Use /problems together with tagging for actions which hit the conds limit