Page MenuHomePhabricator
Create Task
Maniphest T193428

[wmf.1] Horizontal scrolling on full-map view panel
Closed, ResolvedPublic
Actions

Assigned To
Mooeypoo
Authored By
Etonkovidova
Apr 30 2018, 7:23 PM
Tags
Referenced Files
F18393236: Screen Shot 2018-05-20 at 6.43.01 PM.png
May 20 2018, 4:43 PM
F18104002: Screen Shot 2018-05-09 at 1.23.23 PM.png
May 9 2018, 8:37 PM
F18104005: Screen Shot 2018-05-09 at 1.35.42 PM.png
May 9 2018, 8:37 PM
F17457468: Screen Shot 2018-04-30 at 12.22.27 PM.png
Apr 30 2018, 7:23 PM
Subscribers
Aklapper
Etonkovidova
gerritbot
Mooeypoo
SBisson
stjn

Description

The issue is present in betalabs too:

Go to any mapframe (or insert one e.g. below:) - the horizontal scrolling will be present:

<mapframe text="India (80,20)" width=700 height=400 zoom=3 longitude="80" latitude="20">

Screen Shot 2018-04-30 at 12.22.27 PM.png (689×525 px, 87 KB)

Details

SubjectRepoBranchLines +/-
Adjust sidebar items' width to prevent horizontal scrollbarmediawiki/extensions/Kartographermaster+6 -4
Adjust padding/overflow to prevent redundant scrollbars in map sidebarmediawiki/extensions/Kartographermaster+4 -3
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Apr 30 2018, 7:23 PM
Restricted Application added a project: Maps. · View Herald TranscriptApr 30 2018, 7:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Etonkovidova updated the task description. (Show Details)Apr 30 2018, 7:23 PM
Restricted Application added a project: Discovery-ARCHIVED. · View Herald TranscriptApr 30 2018, 7:23 PM
SBisson added subscribers: Mooeypoo, SBisson.May 8 2018, 1:45 PM

@Mooeypoo You've worked on this panel. Any idea why it started scrolling?

Mooeypoo added a comment.May 8 2018, 10:24 PM

eek; it was a combination of an older condition with the padding/placements that the new widgets used.

Fixed in the attached commit.

gerritbot subscribed.May 8 2018, 10:24 PM

Change 432008 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[mediawiki/extensions/Kartographer@master] Adjust padding/overflow to prevent redundant scrollbars in map sidebar

https://gerrit.wikimedia.org/r/432008

gerritbot added a project: Patch-For-Review.May 8 2018, 10:24 PM
Mooeypoo claimed this task.May 8 2018, 10:24 PM
Mooeypoo moved this task from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
SBisson moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.May 9 2018, 2:43 PM
gerritbot added a comment.May 9 2018, 2:52 PM

Change 432008 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] Adjust padding/overflow to prevent redundant scrollbars in map sidebar

https://gerrit.wikimedia.org/r/432008

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-15 (1.32.0-wmf.4)).May 9 2018, 3:00 PM
Etonkovidova added a comment.May 9 2018, 8:37 PM

Perfectly working in betalabs (also works when re-sizing the window):

Screen Shot 2018-05-09 at 1.23.23 PM.png (732×746 px, 382 KB)

@Mooeypoo
However, when clicking on "View more", the horizontal scrolling appears. I vaguely remember that it's extremely difficult to disable horizontal scrolling if a vertical scrolling is in place, so maybe we should be fine as it is?

Screen Shot 2018-05-09 at 1.35.42 PM.png (735×746 px, 393 KB)

Mooeypoo added a comment.EditedMay 10 2018, 2:14 AM
In T193428#4195273, @Etonkovidova wrote:

@Mooeypoo
However, when clicking on "View more", the horizontal scrolling appears. I vaguely remember that it's extremely difficult to disable horizontal scrolling if a vertical scrolling is in place, so maybe we should be fine as it is?

Screen Shot 2018-05-09 at 1.35.42 PM.png (735×746 px, 393 KB)

Oy, I'll take another look at this. I think I know why this happens, though, so I have a place to start...

I think I can try and play around with the sizing of the buttons to make this go away. If not, I can try and cheat but having the buttons themselves smaller than the highlight area, and have that area extend with an overflow. Alternatively, I can also hide all horizontal scrollbars, since those should never appear, but I am slightly worried about them being needed at some point in smaller screens.

I'll take another look.

gerritbot added a comment.May 11 2018, 7:48 PM

Change 432640 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[mediawiki/extensions/Kartographer@master] Adjust sidebar items' width to prevent horizontal scrollbar

https://gerrit.wikimedia.org/r/432640

Mooeypoo moved this task from QA Review to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.May 11 2018, 7:48 PM
SBisson merged a task: T194675: ‘External maps’ panel is scrollable in Firefox.May 15 2018, 10:36 AM
SBisson added a subscriber: stjn.
gerritbot added a comment.May 17 2018, 11:20 AM

Change 432640 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] Adjust sidebar items' width to prevent horizontal scrollbar

https://gerrit.wikimedia.org/r/432640

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)); removed MW-1.32-notes (WMF-deploy-2018-05-15 (1.32.0-wmf.4)).May 17 2018, 12:00 PM
Etonkovidova moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.May 20 2018, 4:40 PM
Etonkovidova added a comment.May 20 2018, 4:43 PM

Checked in betalabs - fixed:

Screen Shot 2018-05-20 at 6.43.01 PM.png (751×538 px, 243 KB)

Etonkovidova closed this task as Resolved.May 20 2018, 4:43 PM
JTannerWMF moved this task from QA Review to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.May 30 2018, 6:37 PM
JTannerWMF mentioned this in Collaboration-Team-Triage (Collab-Team-This-Quarter).May 30 2018, 6:42 PM
Etonkovidova updated the task description. (Show Details)May 30 2018, 11:14 PM
• Vvjjkkii renamed this task from [wmf.1] Horizontal scrolling on full-map view panel to bydaaaaaaa.Jul 1 2018, 1:12 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed Mooeypoo as the assignee of this task.
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
CommunityTechBot renamed this task from bydaaaaaaa to [wmf.1] Horizontal scrolling on full-map view panel.Jul 1 2018, 2:14 PM
CommunityTechBot closed this task as Resolved.
CommunityTechBot assigned this task to Mooeypoo.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added subscribers: gerritbot, Aklapper.
CommunityTechBot raised the priority of this task from High to Needs Triage.Jul 3 2018, 1:50 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL