Page MenuHomePhabricator
Create Task
Maniphest T193583

[betalabs] mapframe without lang attribute not displayed in wiki lang
Closed, ResolvedPublic
Actions

Assigned To
Catrope
Authored By
Etonkovidova
May 1 2018, 10:27 PM
Tags
Referenced Files
F17510019: Screen Shot 2018-05-01 at 3.25.49 PM.png
May 1 2018, 10:27 PM
F17509983: Screen Shot 2018-05-01 at 3.24.34 PM.png
May 1 2018, 10:27 PM
Subscribers
Aklapper
Catrope
Etonkovidova
gerritbot

Description

  1. In hewiki betalabs source editor add mapframe (no lang attribute), e.g.
<mapframe  zoom=9 latitude=31.925 longitude=34.62 />
  1. Switch to VE and the map will be displayed in local lang-Hebrew and Arabic

Screen Shot 2018-05-01 at 3.24.34 PM.png (471×395 px, 309 KB)

  1. Save - the map will be displayed in English:

Screen Shot 2018-05-01 at 3.25.49 PM.png (464×356 px, 207 KB)

Details

SubjectRepoBranchLines +/-
ve.dm.MWMapsNode: Don't hard-code server and stylemediawiki/extensions/Kartographermaster+2 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Etonkovidova created this task.May 1 2018, 10:27 PM
Restricted Application added a project: Maps. · View Herald TranscriptMay 1 2018, 10:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot subscribed.May 2 2018, 1:02 AM

Change 430275 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/Kartographer@master] ve.dm.MWMapsNode: Don't hard-code server and style

https://gerrit.wikimedia.org/r/430275

Restricted Application added a project: Discovery-ARCHIVED. · View Herald TranscriptMay 2 2018, 1:02 AM
gerritbot added a project: Patch-For-Review.May 2 2018, 1:02 AM
Catrope edited projects, added Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage.May 2 2018, 1:03 AM
Catrope moved this task from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Catrope subscribed.
In T193583#4173391, @gerritbot wrote:

Change 430275 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/Kartographer@master] ve.dm.MWMapsNode: Don't hard-code server and style

https://gerrit.wikimedia.org/r/430275

This patch should fix the fact that VE behaves differently than read mode. The fact that it uses English instead of the wiki language is also a problem, I'll fix that next.

Catrope added a comment.May 2 2018, 1:09 AM
In T193583#4173395, @Catrope wrote:

The fact that it uses English instead of the wiki language is also a problem, I'll fix that next.

I deployed the latest version of the Kartotherian deploy repo in beta, and this is now fixed.

SBisson assigned this task to Catrope.May 2 2018, 10:33 AM
SBisson moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
gerritbot added a comment.May 2 2018, 10:37 AM

Change 430275 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] ve.dm.MWMapsNode: Don't hard-code server and style

https://gerrit.wikimedia.org/r/430275

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)).May 2 2018, 11:00 AM
Etonkovidova mentioned this in T192968: Give maplink maps the same internationalization features as mapframe maps.May 2 2018, 11:28 PM
Etonkovidova added a parent task: T192968: Give maplink maps the same internationalization features as mapframe maps.
Etonkovidova updated the task description. (Show Details)May 3 2018, 10:00 PM
• jmatazzoni moved this task from Need Triage to In Progress on the Collaboration-Feature-Rollouts (Collaboration-Maps) board.May 3 2018, 10:17 PM
Etonkovidova closed this task as Resolved.May 4 2018, 9:51 PM
• Vvjjkkii renamed this task from [betalabs] mapframe without lang attribute not displayed in wiki lang to 0tdaaaaaaa.Jul 1 2018, 1:13 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed Catrope as the assignee of this task.
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
CommunityTechBot renamed this task from 0tdaaaaaaa to [betalabs] mapframe without lang attribute not displayed in wiki lang.Jul 1 2018, 9:38 AM
CommunityTechBot closed this task as Resolved.
CommunityTechBot assigned this task to Catrope.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added subscribers: gerritbot, Aklapper.
CommunityTechBot raised the priority of this task from High to Needs Triage.Jul 3 2018, 1:56 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL