Page MenuHomePhabricator

Knock down puppet 4 deprecation warnings
Open, MediumPublic

Description

Since upgrading to puppet 4 our puppet masters have been logging various deprecation warnings. We should address them and then prevent new instances from being committed.

Here are some ideas and steps to get there

  1. First, we need a view of currently outstanding deprecation warnings. These can be obtained crudely by parsing /var/log/syslog on a puppetmaster, but a more elegant way would be ideal. A Kibana visualization is one way to go. To accomplish that we would need to...
    • Ship puppet master syslogs to logstash - There are a few ways to accomplish this each with their own pros/cons so I think it's best suited for a separate task.
    • Parse as necessary in logstash - At a minimum extract the standard syslog fields.
    • Build a puppet deprecation warnings Kibana visualization .
  2. Work through outstanding warnings until there are no more deprecation warnings - Since these warnings are logged during each puppet run "no more" means "there hasn't been a deprecation warning logged in N time units". I think ~1 week should be long enough. It needs to be balanced between long enough to catch outliers (disabled agents, etc.) but short enough to stay on top of new offenders committed while this effort is under way.
  3. Then, once we're not seeing deprecation warnings logged, enable fail_on_deprecation_notices as discussed in T154915

Event Timeline

herron triaged this task as Medium priority.May 2 2018, 6:13 PM
herron created this task.
Vvjjkkii renamed this task from Knock down puppet 4 deprecation warnings to rrdaaaaaaa.Jul 1 2018, 1:12 AM
Vvjjkkii raised the priority of this task from Medium to High.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot renamed this task from rrdaaaaaaa to Knock down puppet 4 deprecation warnings.Jul 2 2018, 2:10 PM
CommunityTechBot lowered the priority of this task from High to Medium.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot added a subscriber: Aklapper.

I think we got rid of all puppet deprecation. At least PuppetSyntax does not report any and we can make it stricter. That is the subject of T154915 and I have prepared https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/333012/ ona while back :-)