Page MenuHomePhabricator

Support whitelisting IPs in CookieWarning extension
Open, Needs TriagePublic

Description

Hi, could support for whitelisting ips be supported in this extension please?

The main reason is when installing the electron service which produces pdfs, it captures the cookie warning header. But we doint need that to be included in the pdf (and it hides some of the content at the top)

Event Timeline

Paladox created this task.May 3 2018, 7:46 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 3 2018, 7:46 AM
Aklapper renamed this task from Support whitelisting ips in CookieWarning extensikn to Support whitelisting IPs in CookieWarning extension.May 3 2018, 12:14 PM
Vvjjkkii renamed this task from Support whitelisting IPs in CookieWarning extension to bqdaaaaaaa.Jul 1 2018, 1:12 AM
Vvjjkkii triaged this task as High priority.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot renamed this task from bqdaaaaaaa to Support whitelisting IPs in CookieWarning extension.Jul 1 2018, 7:30 AM
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot added a subscriber: Aklapper.
CommunityTechBot raised the priority of this task from High to Needs Triage.Jul 3 2018, 2:04 AM

Hmm, is whitelisting the IP really the correct way of doing that? How does the electron service get's the content of the page? If it is displaying it like a normal user, it can just put the cookiewarning_dismissed cookie into the request and CookieWarning will not render the warning header at all. Isn't that a reasonable solution? :)

Hmm, im not sure how to get it to put that "cookiewarning_dismissed" as im using what the wmf uses :)

Hmm, im not sure how to get it to put that "cookiewarning_dismissed" as im using what the wmf uses :)

@Florian D0 Do you know how it can put the cookie into the request?

That highly depends on how the electron service is working :P So, honestly, I don't know as I don't know the source of the electron service.