Page MenuHomePhabricator
Create Task
Maniphest T193719

Pick up DOMComplete and send to Graphite
Closed, ResolvedPublic
Actions

Description

We have DOMComplete in WebPageTest but we don't send it to Graphite. Let us add it so we can follow changes when we do the Resource Loader 2018 review.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Enable pick up DOMComplete.Phedenskogperformance/WebPageTestmaster+3 -3
Rollback DOMComplete.Phedenskogperformance/WebPageTestmaster+3 -3
Collect DOMComplete.Phedenskogperformance/WebPageTestmaster+5 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

Peter created this task.May 3 2018, 9:09 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 3 2018, 9:09 AM
gerritbot subscribed.May 3 2018, 9:43 AM

Change 430569 had a related patch set uploaded (by Phedenskog; owner: Phedenskog):
[performance/WebPageTest@master] Collect domContentLoadedEventEnd

https://gerrit.wikimedia.org/r/430569

gerritbot added a project: Patch-For-Review.May 3 2018, 9:43 AM
Peter triaged this task as Medium priority.May 3 2018, 9:55 AM
Peter moved this task from Inbox, needs triage to To-do: Goals prioritized current Quarter on the Performance-Team board.May 7 2018, 8:08 PM
gerritbot added a comment.Jun 5 2018, 5:16 PM

Change 430569 merged by jenkins-bot:
[performance/WebPageTest@master] Collect DOMComplete.

https://gerrit.wikimedia.org/r/430569

Krinkle closed this task as Resolved.Jun 6 2018, 6:39 PM
Krinkle added a parent task: T192623: ResourceLoader 2018 Review.
gerritbot added a comment.Jun 11 2018, 8:04 PM

Change 439654 had a related patch set uploaded (by Phedenskog; owner: Phedenskog):
[performance/WebPageTest@master] Rollback DOMComplete.

https://gerrit.wikimedia.org/r/439654

Peter reopened this task as Open.Jun 11 2018, 8:19 PM

Reopening since this is rollbacked in https://gerrit.wikimedia.org/r/#/c/performance/WebPageTest/+/439654/

Somehow this broke sending a lot of other metrics to Graphite. Lets make sure we log the full URL in Jenkins in step 1 so it's easier to just see the problem.

gerritbot added a comment.Jun 12 2018, 4:38 AM

Change 439654 merged by jenkins-bot:
[performance/WebPageTest@master] Rollback DOMComplete.

https://gerrit.wikimedia.org/r/439654

Peter added a comment.Jun 20 2018, 2:56 PM

So the message looked like this:

webpagetest.enwiki.anonymous.Facebook.us-east.Chrome.firstView.domComplete=2494.5999999982ms&

I've changed so WebPageTest parse it to an int.

gerritbot added a comment.Jun 20 2018, 3:01 PM

Change 441216 had a related patch set uploaded (by Phedenskog; owner: Phedenskog):
[performance/WebPageTest@master] Enable pick up DOMComplete.

https://gerrit.wikimedia.org/r/441216

gerritbot added a comment.Jun 20 2018, 3:32 PM

Change 441216 merged by jenkins-bot:
[performance/WebPageTest@master] Enable pick up DOMComplete.

https://gerrit.wikimedia.org/r/441216

Krinkle closed this task as Resolved.Jun 22 2018, 2:19 PM
Krinkle removed a project: Patch-For-Review.
• Vvjjkkii renamed this task from Pick up DOMComplete and send to Graphite to 8pdaaaaaaa.Jul 1 2018, 1:12 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed Peter as the assignee of this task.
• Vvjjkkii raised the priority of this task from Medium to High.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
Krinkle renamed this task from 8pdaaaaaaa to Pick up DOMComplete and send to Graphite.Jul 1 2018, 9:48 PM
Krinkle closed this task as Resolved.
Krinkle assigned this task to Peter.
Krinkle lowered the priority of this task from High to Medium.
Krinkle removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
Krinkle updated the task description. (Show Details)
Krinkle added a subscriber: Aklapper.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits