Page MenuHomePhabricator

Add Phan to Babel
Closed, ResolvedPublic


Babel lacks Phan tests and would be good to have.

Event Timeline

Change 430572 had a related patch set uploaded (by MarcoAurelio; owner: MarcoAurelio):
[mediawiki/extensions/Babel@master] [WIP] Add Phan tests to Babel

So it seems just two phan issues need to be fixed (or suppressed if false positives):

10:34:48 <checkstyle version="6.5">
10:34:48   <file name="includes/Babel.php">
10:34:48     <error line="409" severity="info" message="array to bool comparison" source="PhanTypeComparisonFromArray"/>
10:34:48     <error line="438" severity="warning" message="Call to undeclared method \StatusValue::getWikiText" source="PhanUndeclaredMethod"/>
10:34:48   </file>
10:34:48 </checkstyle>

taint-check-plugin reports no issues so we can enable that too if that's okay; but in a new patch.

Change 430572 merged by jenkins-bot:
[mediawiki/extensions/Babel@master] Add Phan tests to Babel

MarcoAurelio claimed this task.
MarcoAurelio removed a project: Patch-For-Review.

Done & CI setup completed as well.

Vvjjkkii renamed this task from Add Phan to Babel to 3pdaaaaaaa.Jul 1 2018, 1:12 AM
Vvjjkkii reopened this task as Open.
Vvjjkkii removed MarcoAurelio as the assignee of this task.
Vvjjkkii triaged this task as High priority.
Vvjjkkii updated the task description. (Show Details)
CommunityTechBot raised the priority of this task from High to Needs Triage.Jul 3 2018, 2:05 AM