Maniphest T193731

CheckboxMultiSelect- & RadioSelectWidget changes vertical spacing when infused
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Esanders
	May 3 2018, 12:59 PM

Description

Before:

After:

This will lead to FOUCs

There is also a slight change in Apex, where the spacing gets a litle smaller

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Update OOUI to v0.31.3	mediawiki/core	master	+403 -355
	themes: Fix infusion reflow in CheckboxMultiselect- & RadioselectInputWidget	oojs/ui	master	+44 -2

Customize query in gerrit

Related Objects

Mentioned In: T195986: FOUC in OOUIfied Special:Preferences
Mentioned Here: rMWf2a83fe4ac1c: HTMLRadioField: Do not automatically infuse our RadioSelectInputWidgets
T195986: FOUC in OOUIfied Special:Preferences

Event Timeline

Esanders created this task.May 3 2018, 12:59 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 3 2018, 12:59 PM

Jdforrester-WMF triaged this task as High priority.May 3 2018, 3:03 PM

• Vvjjkkii renamed this task from RadioSelectWidget changes vertical spacing when infused to wpdaaaaaaa.Jul 1 2018, 1:12 AM

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed a subscriber: Aklapper.

JJMC89 renamed this task from wpdaaaaaaa to RadioSelectWidget changes vertical spacing when infused.Jul 1 2018, 5:28 AM

JJMC89 removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

JJMC89 updated the task description. (Show Details)

CommunityTechBot updated the task description. (Show Details)Jul 5 2018, 6:35 PM

Volker_E renamed this task from RadioSelectWidget changes vertical spacing when infused to CheckboxMultiSelect- & RadioSelectWidget changes vertical spacing when infused.Jul 6 2018, 1:57 PM

Eurgh, the overly complex .oo-ui-fieldLayout-body > .oo-ui-fieldLayout-field + .oo-ui-fieldLayout-header combination is once more not helping.

matmarex mentioned this in T195986: FOUC in OOUIfied Special:Preferences.Jul 10 2018, 4:15 PM

matmarex added a parent task: T195986: FOUC in OOUIfied Special:Preferences.

Is this still an issue? I don't see it on https://en.wikipedia.beta.wmflabs.org/wiki/Special:Preferences?ooui=1#mw-prefsection-personal

Me either, tested Chrome/FF + Ubuntu.

It's still a problem, but this field is not infused on Special:Preferences on page load any more since f2a83fe4ac1c603b7f70d12566e5f8e9bcba1bcd, so this might not be a blocker to T195986 now.

Jdforrester-WMF removed a parent task: T195986: FOUC in OOUIfied Special:Preferences.Sep 10 2018, 6:32 PM

Change 500636 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] themes: Fix infusion reflow in CheckboxMultiselect- & RadioselectInputWidget

https://gerrit.wikimedia.org/r/500636

gerritbot added a project: Patch-For-Review.Apr 2 2019, 12:01 AM

Volker_E moved this task from Backlog to Reviewing on the OOUI board.Apr 2 2019, 12:03 AM

Change 500636 merged by jenkins-bot:
[oojs/ui@master] themes: Fix infusion reflow in CheckboxMultiselect- & RadioselectInputWidget

https://gerrit.wikimedia.org/r/500636

matmarex awarded a token.Apr 3 2019, 7:21 PM

Volker_E moved this task from Reviewing to OOUI-0.31.3 on the OOUI board.Apr 4 2019, 12:38 AM

Volker_E edited projects, added OOUI (OOUI-0.31.3); removed OOUI.

Change 501429 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.31.3

https://gerrit.wikimedia.org/r/501429

Change 501429 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.31.3