| Dzahn | |
| May 3 2018, 8:08 PM |
| F17621797: device-not-healthy-but-ok.png | |
| May 3 2018, 8:08 PM |
The SMART Icinga check "Device not healthy -SMART-" returns OK and is green even when the actual message is "(No output returned from plugin)".
See screenshot.
It should not be OK when it gets nothing from plugin.
Should be UNKNOWN instead i would say.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| prometheus_check_metric: print message when status is OK | operations/puppet | production | +2 -1 |
That's the current behavior of the check, i.e. when things are ok exit 0 and no output. We can change it to print "OK" or sth similar, and the values/thresholds perhaps
Change 430898 had a related patch set uploaded (by Filippo Giunchedi; owner: Filippo Giunchedi):
[operations/puppet@production] prometheus_check_metric: print message when status is OK
The screenshot above is from a time when a host being reinstalled and every other check on the host was red. Is it possible that it was actually ok during this time ?
Change 430898 merged by Dzahn:
[operations/puppet@production] prometheus_check_metric: print message when status is OK