Maniphest T193821

mediawiki.ui.button should be loaded via JavaScript
Closed, DeclinedPublic
Actions

Assigned To

None

Authored By

	Jdlrobson
	May 4 2018, 12:43 AM

Description

Problem: We load lots of mediawiki.ui styles as render blocking, but they do not need to be render blocking.

We will load most of mediawiki.ui.button via JavaScript. This will trim down initial CSS by up to 0.7kb.
Minerva will load a lightweight CSS module which simply provides the basic CSS for the button.

@Volker_E and I took a look at mediawiki.ui.button usage and Minerva and special pages are the only things that use this code without JavaScript.

Acceptance criteria

Make sure a minimum render blocking module mediawiki.ui.lite is loaded on all pages
Make sure the basic mediawiki.ui.lite module is loaded on Special:MobileWatchlist pages without JavaScript and the full mediawiki.ui.button module is loaded with JavaScript.
Make sure mediawiki.ui.button is loaded via JavaScript on all content pages

Details

	Subject	Repo	Branch	Lines +/-
	Load mediawiki.ui.button in JavaScript	mediawiki/skins/MinervaNeue	master	+11 -1

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Jdlrobson	T195473 [GOAL] Invest in the MobileFrontend & MinervaNeue frontend architecture
Resolved	Jdlrobson	T195478 [EPIC] Speed up unit test execution and increase code coverage
Resolved	Jdlrobson	T195482 [EPIC] Review and refactor MobileFrontend components used by Minerva
Declined	None	T182648 [EPIC] Review, rearrange and remove unnecessary CSS in the mobile site
Declined	None	T193821 mediawiki.ui.button should be loaded via JavaScript

Event Timeline

Jdlrobson created this task.May 4 2018, 12:43 AM

Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.

Jdlrobson mentioned this in T182050: Remove all mediawiki.ui components and libraries in favor of Codex.May 4 2018, 12:52 AM

From a UX perspective, the basic styles should not only contain box sizing specific properties, but also backgrounds, colors, border-colors (, box-shadows) of the normal states in order not only preventing reflow but having an acceptable visual first widget rendering.

Jdlrobson moved this task from Needs Prioritization to Tracking on the Web-Team-Backlog board.Jun 15 2018, 8:03 PM

Jdlrobson edited projects, added Web-Team-Backlog (Tracking); removed Web-Team-Backlog.

• Vvjjkkii renamed this task from mediawiki.ui.button should be loaded via JavaScript to endaaaaaaa.Jul 1 2018, 1:12 AM

• Vvjjkkii triaged this task as High priority.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed a subscriber: Aklapper.

CommunityTechBot renamed this task from endaaaaaaa to mediawiki.ui.button should be loaded via JavaScript.Jul 2 2018, 4:30 PM

CommunityTechBot raised the priority of this task from High to Needs Triage.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot added a subscriber: Aklapper.

Jdlrobson mentioned this in T182648: [EPIC] Review, rearrange and remove unnecessary CSS in the mobile site.Jul 6 2018, 7:54 PM

Change 444276 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Load mediawiki.ui.button in JavaScript

https://gerrit.wikimedia.org/r/444276

gerritbot added a project: Patch-For-Review.Jul 6 2018, 7:54 PM

Jdlrobson moved this task from Untriaged to Move to Backlog on the Web-Team-Backlog (Tracking) board.Jul 6 2018, 9:25 PM

• Jhernandez unsubscribed.Jul 7 2018, 12:26 PM

Change 444276 abandoned by Jdlrobson:
Load mediawiki.ui.button in JavaScript

https://gerrit.wikimedia.org/r/444276

Maintenance_bot removed a project: Patch-For-Review.Aug 29 2019, 8:10 PM

CKoerner_WMF unsubscribed.Dec 12 2019, 4:11 PM

Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptDec 12 2019, 4:11 PM

Jdlrobson moved this task from Inbox to Tracking on the User-Jdlrobson board.Mar 2 2020, 10:46 PM

Jdlrobson moved this task from Backlog to Team: web on the MobileFrontend board.Jul 24 2020, 2:52 AM

Jdlrobson edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Tracking).Jul 24 2020, 3:15 PM

Jdlrobson triaged this task as Medium priority.Aug 4 2020, 4:58 PM

Jdlrobson moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.

Not a focus right now. Probably little impact.

mediawiki.ui.button should be loaded via JavaScriptClosed, DeclinedPublicActions