Page MenuHomePhabricator
Create Task
Maniphest T193880

MediaViewer not working for thumbnails as of 1.32.0-wmf.2
Closed, ResolvedPublic
Actions

Description

Thumbnails on entities rendered after the 1.32.0-wmf.2 deploy wont be picked up by MMV. This is because MMV uses the select a.image img to pick up the thumbs, but we stopped setting the image class onto our image link with 45d1ff372fd702ab6730a8188fb380f65b01ea0f given that ThumbnailImage::toHtml stops setting it once a custom target URL is provided.

Details

SubjectRepoBranchLines +/-
Rewrite CommonsInlineImageFormattermediawiki/extensions/Wikibasemaster+125 -159
Customize query in gerrit

Related Objects

Event Timeline

hoo created this task.May 4 2018, 2:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 4 2018, 2:38 PM
gerritbot subscribed.May 4 2018, 3:51 PM

Change 430930 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/Wikibase@master] Rewrite CommonsInlineImageFormatter

https://gerrit.wikimedia.org/r/430930

gerritbot added a project: Patch-For-Review.May 4 2018, 3:51 PM
hoo added a project: Wikidata-Ministry-Of-Magic.May 4 2018, 3:54 PM
hoo moved this task from Tasks to Needs Review on the Wikidata-Ministry-Of-Magic board.
Lucas_Werkmeister_WMDE moved this task from Needs Review to Test (Product Review) on the Wikidata-Ministry-Of-Magic board.May 7 2018, 11:42 AM
gerritbot added a comment.May 7 2018, 11:53 AM

Change 430930 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Rewrite CommonsInlineImageFormatter

https://gerrit.wikimedia.org/r/430930

Lydia_Pintscher closed this task as Resolved.May 8 2018, 8:22 AM
Lydia_Pintscher claimed this task.
Lydia_Pintscher moved this task from Test (Product Review) to Done on the Wikidata-Ministry-Of-Magic board.
• Vvjjkkii renamed this task from MediaViewer not working for thumbnails as of 1.32.0-wmf.2 to rldaaaaaaa.Jul 1 2018, 1:12 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed Lydia_Pintscher as the assignee of this task.
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii edited subscribers, added: Lydia_Pintscher; removed: gerritbot, Aklapper.
CommunityTechBot renamed this task from rldaaaaaaa to MediaViewer not working for thumbnails as of 1.32.0-wmf.2.Jul 2 2018, 4:28 PM
CommunityTechBot closed this task as Resolved.
CommunityTechBot assigned this task to Lydia_Pintscher.
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot edited subscribers, added: gerritbot, Aklapper; removed: Lydia_Pintscher.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL