Page MenuHomePhabricator
Create Task
Maniphest T194068

CodeMirror and 2017 Wikitext editor combination produce invisible text in Category and File namespaces
Closed, ResolvedPublic
Actions

Assigned To
matmarex
Authored By
• Niharika
May 7 2018, 5:43 PM
Tags
Referenced Files
F26210139: image.png
Sep 26 2018, 11:27 AM
F26210130: image.png
Sep 26 2018, 11:27 AM
F26210141: image.png
Sep 26 2018, 11:27 AM
F26210134: image.png
Sep 26 2018, 11:27 AM
F18062138: Capture.PNG
May 7 2018, 9:12 PM
Subscribers
Aklapper
Anon126
Bencemac
deryckchan
• Deskana
• Elitre
Esanders
View All 16 Subscribers
Tokens
"Love" token, awarded by Sebastian_Berlin-WMSE."Like" token, awarded by Robby."Piece of Eight" token, awarded by Liuxinyu970226."Piece of Eight" token, awarded by deryckchan.

Description

When one tries to edit a Category or File page using the 2017 Wikitext Editor with Syntax Highlighting turned on, the Wikitext turns invisible (white text on white background) once the page finishes loading.

This bug affects Category and File namespaces only, and affects most wikis and most browsers (see comments below for combinations that we've tried).

Reported here.

Screenshot: https://www.mediawiki.org/wiki/File:Syntax_highlighter_white_text.png

We've encountered similar bugs before but I can't find an exact same one.

Details

SubjectRepoBranchLines +/-
Remove special handling for category and file pagesmediawiki/extensions/VisualEditormaster+3 -35
Customize query in gerrit

Related Objects

Event Timeline

• Niharika created this task.May 7 2018, 5:43 PM
Restricted Application added projects: VisualEditor, Community-Tech. · View Herald TranscriptMay 7 2018, 5:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gh87 added a project: Browser-Support-Firefox.May 7 2018, 7:19 PM
MusikAnimal subscribed.May 7 2018, 7:28 PM

I am able to reproduce. Just browse to Category:中國嘅鄰國 and hit Edit with 2017 editor and CodeMirror already enabled.

Interestingly, during the same editing session, if you turn syntax highlighting off and then back on the text will reappear. Also if you go directly to the page with action=edit all is fine.

deryckchan subscribed.May 7 2018, 9:12 PM

Thanks @Niharika and @MusikAnimal.

I can confirm that I can reproduce the same error both (1) on a different Category: page on yue.wp; and (2) on a Category: page on en.wp (see attached screenshot), with a slightly different set-up (Chrome 65 on Win10).

Capture.PNG (590×794 px, 31 KB)

As far as I can tell, the bug affects Category: namespace only, and affects all wikis.

deryckchan awarded a token.May 7 2018, 9:16 PM
• TBolliger moved this task from New & TBD Tickets to Needs Discussion on the Community-Tech board.May 7 2018, 11:54 PM
• Deskana subscribed.May 8 2018, 6:45 PM

Is this only happening on specific pages, or all pages when you use both CodeMirror and 2017WTE in Firefox.

• TBolliger moved this task from Needs Discussion to Older: Tracking Work by Others on the Community-Tech board.May 8 2018, 9:29 PM
deryckchan renamed this task from CodeMirror and 2017 Wikitext editor combination produce invisible text on Firefox to CodeMirror and 2017 Wikitext editor combination produce invisible text in Category: namespace.May 9 2018, 9:50 AM
deryckchan updated the task description. (Show Details)
In T194068#4191717, @Deskana wrote:

Is this only happening on specific pages, or all pages when you use both CodeMirror and 2017WTE in Firefox.

All Category pages on all wikis I've tried, whenever I use CodeMirror in 2017WTE.

Liuxinyu970226 removed a project: Browser-Support-Firefox.May 14 2018, 2:59 PM
Liuxinyu970226 subscribed.

per author, not just certain browser only bug

matmarex claimed this task.May 14 2018, 4:32 PM
matmarex edited projects, added VisualEditor (Current work); removed VisualEditor.
matmarex subscribed.

I investigated today why this happens:

  • During VisualEditor's initialisation, <div id="mw-content-text"> is temporarily hidden while its contents are rearranged
  • On category pages, VisualEditor initialisation happens a bit differently so that the list of pages remains visible – in particular, the editing surface is inserted inside the <div id="mw-content-text"> rather than next to it (DesktopArticleTarget#getEditableContent)
  • When CodeEditor syntax-highlighting initializes (updateDisplayIfNeeded()), on category pages the editing surface is inside the hidden div, and so CodeEditor doesn't render it
  • Then the div is shown again and the incomplete syntax-highlighting editing surface appears (looks like invisible text)

I think a similar issue may occur on file pages too, where we initialise differently to keep the file thumbnail visible.

I'm not sure how to best fix this yet. We'll need to either remove/change the initialisation special case to avoid this, or force the syntax-highlighting to render manually.

JJMC89 renamed this task from CodeMirror and 2017 Wikitext editor combination produce invisible text in Category: namespace to CodeMirror and 2017 Wikitext editor combination produce invisible text in Category and File namespaces.May 17 2018, 4:04 PM
JJMC89 merged a task: T192658: Editing source code of File with Beta new wikitext feature yields blank white section..
JJMC89 updated the task description. (Show Details)
JJMC89 added subscribers: Waddie96, Bencemac, Framawiki.
matmarex moved this task from Incoming to In progress on the VisualEditor (Current work) board.May 31 2018, 1:27 AM
Liuxinyu970226 awarded a token.Jun 15 2018, 1:48 PM
matmarex triaged this task as Medium priority.Jun 15 2018, 9:28 PM
matmarex merged a task: T188069: Text on category page is invisible when syntax highlighting is enabled.Jun 21 2018, 6:51 PM
matmarex added subscribers: Anon126, • Elitre, TheDJ.
matmarex mentioned this in T139191: VisualEditor makes redlinked category index pages inacessible.Jun 21 2018, 11:27 PM
gerritbot subscribed.Jun 21 2018, 11:44 PM

Change 441509 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Remove special handling for category and file pages

https://gerrit.wikimedia.org/r/441509

gerritbot added a project: Patch-For-Review.Jun 21 2018, 11:44 PM
matmarex moved this task from In progress to Code review on the VisualEditor (Current work) board.Jun 21 2018, 11:48 PM
• Vvjjkkii renamed this task from CodeMirror and 2017 Wikitext editor combination produce invisible text in Category and File namespaces to jgdaaaaaaa.Jul 1 2018, 1:11 AM
• Vvjjkkii removed matmarex as the assignee of this task.
• Vvjjkkii raised the priority of this task from Medium to High.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
Anon126 renamed this task from jgdaaaaaaa to CodeMirror and 2017 Wikitext editor combination produce invisible text in Category and File namespaces.Jul 1 2018, 4:43 AM
Anon126 assigned this task to matmarex.
Anon126 lowered the priority of this task from High to Medium.
Anon126 removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
Anon126 updated the task description. (Show Details)
Anon126 added subscribers: gerritbot, Aklapper.
Robby subscribed.Jul 20 2018, 8:44 AM
Robby awarded a token.Jul 20 2018, 8:50 AM
• Niharika removed a project: Community-Tech.Aug 9 2018, 10:53 PM
Esanders subscribed.Sep 21 2018, 2:06 PM

Can you add screenshots showing the before/after of editing a file page in VE/VE source mode?

Esanders added a comment.Sep 26 2018, 11:27 AM
VENWE
Before
image.png (1×1 px, 858 KB)
image.png (1×1 px, 865 KB)
After
image.png (1×1 px, 170 KB)
image.png (765×1 px, 141 KB)
Esanders added a comment.Sep 26 2018, 5:42 PM

Thoughts @Deskana?

Niridya subscribed.Oct 29 2018, 9:14 PM
Schnark merged a task: T212713: With "Syntax highlighting" enabled in 2017 wikitext editor, source code is highlighted in white at first when editing category pages.Dec 31 2018, 9:42 AM
Sebastian_Berlin-WMSE awarded a token.Feb 8 2019, 7:49 AM
Esanders moved this task from Code review to QA on the VisualEditor (Current work) board.Mar 19 2019, 6:47 PM
gerritbot added a comment.Mar 19 2019, 7:24 PM

Change 441509 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Remove special handling for category and file pages

https://gerrit.wikimedia.org/r/441509

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.22; 2019-03-19).Mar 19 2019, 8:01 PM
Ryasmeen added a project: Editing QA.Mar 21 2019, 7:24 PM
Niridya closed this task as Resolved.Mar 21 2019, 8:57 PM

I changed the status to resolved because the bug is now fixed on Mediawiki version that is installed on Wikimedia's wikis.

Ryasmeen edited projects, added Verified; removed Editing QA.Mar 21 2019, 9:13 PM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.
Liuxinyu970226 unsubscribed.Mar 24 2019, 4:52 AM
matmarex mentioned this in T188186: New wikitext editor should not display uneditable page content.Nov 14 2019, 6:46 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 14 2019, 7:10 PM
TheDJ moved this task from Backlog to Done on the MediaWiki-extensions-CodeMirror board.Feb 26 2020, 10:10 AM
matmarex mentioned this in T197951: Show category content when switching from source code to visual editing.Jul 17 2020, 2:43 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL