Page MenuHomePhabricator
Create Task
Maniphest T194082

Cannot read property 'insertBefore' of null
Closed, ResolvedPublic
Actions

Description

https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2018.05.07/parsoid?id=AWM8HkRWVAdyMbafo2dw&_g=h@44136fa

trwiki/Batman'da_spor

TypeError: Cannot read property 'insertBefore' of null
    at Object.prependTypedMeta (/srv/deployment/parsoid/deploy-cache/revs/d8d7b424aa0f8fc5028099168e3646c2f131212e/src/lib/utils/DOMUtils.js:1422:18)
    at Object.addDiffMark (/srv/deployment/parsoid/deploy-cache/revs/d8d7b424aa0f8fc5028099168e3646c2f131212e/src/lib/utils/DOMUtils.js:1110:7)
    at Normalizer.addDiffMarks (/srv/deployment/parsoid/deploy-cache/revs/d8d7b424aa0f8fc5028099168e3646c2f131212e/src/lib/html2wt/normalizeDOM.js:41:6)
    at Normalizer.merge (/srv/deployment/parsoid/deploy-cache/revs/d8d7b424aa0f8fc5028099168e3646c2f131212e/src/lib/html2wt/normalizeDOM.js:124:8)
    at Normalizer.normalizeSiblingPair (/srv/deployment/parsoid/deploy-cache/revs/d8d7b424aa0f8fc5028099168e3646c2f131212e/src/lib/html2wt/normalizeDOM.js:520:13)
    at Normalizer.processSubtree (/srv/deployment/parsoid/deploy-cache/revs/d8d7b424aa0f8fc5028099168e3646c2f131212e/src/lib/html2wt/normalizeDOM.js:567:13)
    at Normalizer.processNode (/srv/deployment/parsoid/deploy-cache/revs/d8d7b424aa0f8fc5028099168e3646c2f131212e/src/lib/html2wt/normalizeDOM.js:601:9)
    at Normalizer.processSubtree (/srv/deployment/parsoid/deploy-cache/revs/d8d7b424aa0f8fc5028099168e3646c2f131212e/src/lib/html2wt/normalizeDOM.js:561:12)
    at Normalizer.processNode (/srv/deployment/parsoid/deploy-cache/revs/d8d7b424aa0f8fc5028099168e3646c2f131212e/src/lib/html2wt/normalizeDOM.js:601:9)
    at Normalizer.processSubtree (/srv/deployment/parsoid/deploy-cache/revs/d8d7b424aa0f8fc5028099168e3646c2f131212e/src/lib/html2wt/normalizeDOM.js:561:12)
    at Normalizer.processNode (/srv/deployment/parsoid/deploy-cache/revs/d8d7b424aa0f8fc5028099168e3646c2f131212e/src/lib/html2wt/normalizeDOM.js:601:9)
    at Normalizer.processSubtree (/srv/deployment/parsoid/deploy-cache/revs/d8d7b424aa0f8fc5028099168e3646c2f131212e/src/lib/html2wt/normalizeDOM.js:561:12)
    at Normalizer.processNode (/srv/deployment/parsoid/deploy-cache/revs/d8d7b424aa0f8fc5028099168e3646c2f131212e/src/lib/html2wt/normalizeDOM.js:601:9)
    at Normalizer.processSubtree (/srv/deployment/parsoid/deploy-cache/revs/d8d7b424aa0f8fc5028099168e3646c2f131212e/src/lib/html2wt/normalizeDOM.js:561:12)
    at Normalizer.processNode (/srv/deployment/parsoid/deploy-cache/revs/d8d7b424aa0f8fc5028099168e3646c2f131212e/src/lib/html2wt/normalizeDOM.js:601:9)
    at Normalizer.normalizeDOM (/srv/deployment/parsoid/deploy-cache/revs/d8d7b424aa0f8fc5028099168e3646c2f131212e/src/lib/html2wt/normalizeDOM.js:622:14)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
TRY #2: normalizeDOM: normalize a node after it is merged with a siblingmediawiki/services/parsoidmaster+8 -1
Customize query in gerrit

Related Objects

Event Timeline

Arlolra created this task.May 7 2018, 8:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 7 2018, 8:22 PM
Arlolra assigned this task to • Sbailey.May 7 2018, 9:07 PM
Arlolra triaged this task as High priority.
ssastry moved this task from Needs Triage to html2wt on the Parsoid board.May 9 2018, 9:50 PM
Arlolra added a comment.May 10 2018, 6:40 PM

This crasher looks like the result of https://github.com/wikimedia/parsoid/commit/58d49a8588b7831af0e3385315f01c72a60b5936

When the sentinel itself is normalized away (it being a text node and as a result of the call to a.normalize()) it is left dangling and eventually throws while trying to addDiffMarks around it.

ssastry subscribed.May 11 2018, 3:00 AM
In T194082#4198263, @Arlolra wrote:

This crasher looks like the result of https://github.com/wikimedia/parsoid/commit/58d49a8588b7831af0e3385315f01c72a60b5936

When the sentinel itself is normalized away (it being a text node and as a result of the call to a.normalize()) it is left dangling and eventually throws while trying to addDiffMarks around it.

Good catch! You are right. Let us just revert that patch for now and revisit how to redo that functionality.

gerritbot subscribed.May 11 2018, 6:40 PM

Change 432624 had a related patch set uploaded (by Sbailey; owner: Sbailey):
[mediawiki/services/parsoid@master] Fix for Cannot read property 'insertBefore' of null

https://gerrit.wikimedia.org/r/432624

gerritbot added a project: Patch-For-Review.May 11 2018, 6:40 PM
gerritbot added a comment.May 12 2018, 12:16 AM

Change 432624 merged by jenkins-bot:
[mediawiki/services/parsoid@master] TRY #2: normalizeDOM: normalize a node after it is merged with a sibling

https://gerrit.wikimedia.org/r/432624

Arlolra closed this task as Resolved.May 12 2018, 3:38 AM
Stashbot subscribed.May 14 2018, 9:03 PM

Mentioned in SAL (#wikimedia-operations) [2018-05-14T21:03:06Z] <arlolra> Updated Parsoid to 945ed23 (T194082, T194083, T194084)

Stashbot mentioned this in T194083: Found nested inserted dom-diff flags!.May 14 2018, 9:03 PM
Stashbot mentioned this in T194084: Expecting : in parser function definiton.
• Vvjjkkii renamed this task from Cannot read property 'insertBefore' of null to 5fdaaaaaaa.Jul 1 2018, 1:11 AM
• Vvjjkkii reopened this task as Open.
• Vvjjkkii removed • Sbailey as the assignee of this task.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii edited subscribers, added: • Sbailey; removed: gerritbot, Aklapper.
CommunityTechBot renamed this task from 5fdaaaaaaa to Cannot read property 'insertBefore' of null.Jul 2 2018, 1:54 PM
CommunityTechBot closed this task as Resolved.
CommunityTechBot assigned this task to • Sbailey.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot edited subscribers, added: gerritbot, Aklapper; removed: • Sbailey.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits