Page MenuHomePhabricator
Create Task
Maniphest T194083

Found nested inserted dom-diff flags!
Closed, ResolvedPublic
Actions

Description

https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2018.05.07/parsoid?id=AWM7GA5nVAdyMbafgUUy&_g=h@1251ff0

skwiki/Alessia_Cara

AssertionError: Found nested inserted dom-diff flags!
    at Console.assert (console.js:95:23)
    at Normalizer.processNode (/srv/deployment/parsoid/deploy-cache/revs/d8d7b424aa0f8fc5028099168e3646c2f131212e/src/lib/html2wt/normalizeDOM.js:594:12)
    at Normalizer.processSubtree (/srv/deployment/parsoid/deploy-cache/revs/d8d7b424aa0f8fc5028099168e3646c2f131212e/src/lib/html2wt/normalizeDOM.js:552:11)
    at Normalizer.processNode (/srv/deployment/parsoid/deploy-cache/revs/d8d7b424aa0f8fc5028099168e3646c2f131212e/src/lib/html2wt/normalizeDOM.js:601:9)
    at Normalizer.processSubtree (/srv/deployment/parsoid/deploy-cache/revs/d8d7b424aa0f8fc5028099168e3646c2f131212e/src/lib/html2wt/normalizeDOM.js:552:11)
    at Normalizer.processNode (/srv/deployment/parsoid/deploy-cache/revs/d8d7b424aa0f8fc5028099168e3646c2f131212e/src/lib/html2wt/normalizeDOM.js:601:9)
    at Normalizer.processSubtree (/srv/deployment/parsoid/deploy-cache/revs/d8d7b424aa0f8fc5028099168e3646c2f131212e/src/lib/html2wt/normalizeDOM.js:561:12)
    at Normalizer.processNode (/srv/deployment/parsoid/deploy-cache/revs/d8d7b424aa0f8fc5028099168e3646c2f131212e/src/lib/html2wt/normalizeDOM.js:601:9)
    at Normalizer.processSubtree (/srv/deployment/parsoid/deploy-cache/revs/d8d7b424aa0f8fc5028099168e3646c2f131212e/src/lib/html2wt/normalizeDOM.js:561:12)
    at Normalizer.processNode (/srv/deployment/parsoid/deploy-cache/revs/d8d7b424aa0f8fc5028099168e3646c2f131212e/src/lib/html2wt/normalizeDOM.js:601:9)
    at Normalizer.normalizeDOM (/srv/deployment/parsoid/deploy-cache/revs/d8d7b424aa0f8fc5028099168e3646c2f131212e/src/lib/html2wt/normalizeDOM.js:622:14)
    at WikitextSerializer.<anonymous> (/srv/deployment/parsoid/deploy-cache/revs/d8d7b424aa0f8fc5028099168e3646c2f131212e/src/lib/html2wt/WikitextSerializer.js:1416:26)
    at next (native)
    at tryCatchNext (/srv/deployment/parsoid/deploy-cache/revs/d8d7b424aa0f8fc5028099168e3646c2f131212e/node_modules/prfun/lib/index.js:783:28)
    at continuer (/srv/deployment/parsoid/deploy-cache/revs/d8d7b424aa0f8fc5028099168e3646c2f131212e/node_modules/prfun/lib/index.js:800:24)
    at callback (/srv/deployment/parsoid/deploy-cache/revs/d8d7b424aa0f8fc5028099168e3646c2f131212e/node_modules/prfun/lib/index.js:812:43)

Details

SubjectRepoBranchLines +/-
Add 'inserted' diff-marker to the correct nodemediawiki/services/parsoidmaster+18 -3
Followup on de1d7bc3: Refine that original checkmediawiki/services/parsoidmaster+22 -0
Dump debugging info for nested inserted dom-diff flags errormediawiki/services/parsoidmaster+7 -0
Distinguish between inserted & deleted diff markersmediawiki/services/parsoidmaster+50 -29
Customize query in gerrit

Related Objects

Event Timeline

Arlolra created this task.May 7 2018, 8:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 7 2018, 8:24 PM
Arlolra assigned this task to • Sbailey.May 7 2018, 9:07 PM
Arlolra triaged this task as High priority.
gerritbot subscribed.May 9 2018, 2:00 PM

Change 432077 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] Distinguish between inserted & deleted diff markers

https://gerrit.wikimedia.org/r/432077

gerritbot added a project: Patch-For-Review.May 9 2018, 2:00 PM
ssastry claimed this task.May 9 2018, 2:00 PM
ssastry added a subscriber: • Sbailey.
ssastry moved this task from Needs Triage to html2wt on the Parsoid board.May 9 2018, 9:50 PM
gerritbot added a comment.May 9 2018, 11:38 PM

Change 432077 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Distinguish between inserted & deleted diff markers

https://gerrit.wikimedia.org/r/432077

Arlolra closed this task as Resolved.May 14 2018, 4:35 PM
Stashbot mentioned this in T194082: Cannot read property 'insertBefore' of null.May 14 2018, 9:03 PM
Stashbot subscribed.

Mentioned in SAL (#wikimedia-operations) [2018-05-14T21:03:06Z] <arlolra> Updated Parsoid to 945ed23 (T194082, T194083, T194084)

Stashbot mentioned this in T194084: Expecting : in parser function definiton.May 14 2018, 9:03 PM
ssastry reopened this task as Open.EditedJun 9 2018, 4:55 AM

New instances found

 stack 	AssertionError: Found nested inserted dom-diff flags!
    at Console.assert (console.js:95:23)
    at Normalizer.processNode (/srv/deployment/parsoid/deploy-cache/revs/2f806399a5cce497e55f60fc2cb0aee88d14d932/src/lib/html2wt/normalizeDOM.js:607:12)
    at Normalizer.processSubtree (/srv/deployment/parsoid/deploy-cache/revs/2f806399a5cce497e55f60fc2cb0aee88d14d932/src/lib/html2wt/normalizeDOM.js:574:12)
    at Normalizer.processNode (/srv/deployment/parsoid/deploy-cache/revs/2f806399a5cce497e55f60fc2cb0aee88d14d932/src/lib/html2wt/normalizeDOM.js:614:9)
    at Normalizer.processSubtree (/srv/deployment/parsoid/deploy-cache/revs/2f806399a5cce497e55f60fc2cb0aee88d14d932/src/lib/html2wt/normalizeDOM.js:574:12)
    at Normalizer.processNode (/srv/deployment/parsoid/deploy-cache/revs/2f806399a5cce497e55f60fc2cb0aee88d14d932/src/lib/html2wt/normalizeDOM.js:614:9)
    at Normalizer.normalizeDOM (/srv/deployment/parsoid/deploy-cache/revs/2f806399a5cce497e55f60fc2cb0aee88d14d932/src/lib/html2wt/normalizeDOM.js:635:14)
    at WikitextSerializer.<anonymous> (/srv/deployment/parsoid/deploy-cache/revs/2f806399a5cce497e55f60fc2cb0aee88d14d932/src/lib/html2wt/WikitextSerializer.js:1429:26)
    at next (native)
    at tryCatchNext (/srv/deployment/parsoid/deploy-cache/revs/2f806399a5cce497e55f60fc2cb0aee88d14d932/node_modules/prfun/lib/index.js:783:28)
    at continuer (/srv/deployment/parsoid/deploy-cache/revs/2f806399a5cce497e55f60fc2cb0aee88d14d932/node_modules/prfun/lib/index.js:800:24)
    at callback (/srv/deployment/parsoid/deploy-cache/revs/2f806399a5cce497e55f60fc2cb0aee88d14d932/node_modules/prfun/lib/index.js:812:43)
    at /srv/deployment/parsoid/deploy-cache/revs/2f806399a5cce497e55f60fc2cb0aee88d14d932/node_modules/prfun/lib/index.js:814:9
    at tryCatch2 (/srv/deployment/parsoid/deploy-cache/revs/2f806399a5cce497e55f60fc2cb0aee88d14d932/node_modules/babybird/lib/promise.js:48:12)
    at PrFunPromise.Promise (/srv/deployment/parsoid/deploy-cache/revs/2f806399a5cce497e55f60fc2cb0aee88d14d932/node_modules/babybird/lib/promise.js:458:15)
    at new PrFunPromise (/srv/deployment/parsoid/deploy-cache/revs/2f806399a5cce497e55f60fc2cb0aee88d14d932/node_modules/prfun/lib/index.js:100:21)
t tags 	es, gelf, normalized_message_untrimmed
t title 	User:Chandan_mrc
t type 	parsoid
t userAgent 	VisualEditor-MediaWiki/1.32.0-wmf.7
t version 	1.0
t wiki 	enwiki

Also frwiki:Cimetière_Vagankovo

Arlolra claimed this task.Jun 26 2018, 10:48 PM
Arlolra added a subscriber: ssastry.
• Vvjjkkii renamed this task from Found nested inserted dom-diff flags! to 4fdaaaaaaa.Jul 1 2018, 1:13 AM
• Vvjjkkii removed Arlolra as the assignee of this task.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: gerritbot, Aklapper.
CommunityTechBot renamed this task from 4fdaaaaaaa to Found nested inserted dom-diff flags!.Jul 2 2018, 1:53 PM
CommunityTechBot assigned this task to Arlolra.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added subscribers: gerritbot, Aklapper.
ssastry claimed this task.Jul 18 2018, 5:56 PM
gerritbot added a comment.Jul 23 2018, 9:58 AM

Change 447391 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] Dump debugging info for nested inserted dom-diff flags error

https://gerrit.wikimedia.org/r/447391

gerritbot added a comment.Jul 23 2018, 3:21 PM

Change 447391 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Dump debugging info for nested inserted dom-diff flags error

https://gerrit.wikimedia.org/r/447391

Stashbot mentioned this in T199808: Update portals to cater for foundationwiki move.Jul 23 2018, 8:27 PM

Mentioned in SAL (#wikimedia-operations) [2018-07-23T20:27:34Z] <arlolra> Updated Parsoid to rGPARa1e851c6c7e0 (T199808, T194083)

gerritbot added a comment.Jul 24 2018, 5:38 AM

Change 447578 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] Followup on de1d7bc3: Refine that original check

https://gerrit.wikimedia.org/r/447578

gerritbot added a comment.Jul 25 2018, 4:51 PM

Change 447578 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Followup on de1d7bc3: Refine that original check

https://gerrit.wikimedia.org/r/447578

Stashbot mentioned this in T194806: P-wrapping doesn't match php parser's $inBlockElem.Jul 26 2018, 6:08 PM
Stashbot mentioned this in T110004: DOM Pass for wrapping bare text found in <body> and other "block" (in html4-parlance) nodes like <blockquote>, <td>, <th>..
Stashbot mentioned this in T156099: Be explicit about what ext api exports.
Stashbot mentioned this in T188478: Parsoid needs a native implementation of <poem>.

Mentioned in SAL (#wikimedia-operations) [2018-07-26T18:08:31Z] <arlolra> Updated Parsoid to cdf8ace (T194806, T110004, T156099, T188478, T194083)

Arlolra closed this task as Resolved.Jul 26 2018, 7:03 PM

There haven't been any occurrences of this since the deploy.

Arlolra reopened this task as Open.Nov 29 2018, 6:56 PM

Seeing some more of these.

https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2018.11.29/parsoid?id=AWdgm8Xli-uKhB2cWXfP&_g=h@44136fa

frwiki Sarah_Trouche

AssertionError: Found nested inserted dom-diff flags!
    at Console.assert (console.js:95:23)
    at Normalizer.processNode (/srv/deployment/parsoid/deploy-cache/revs/9ed8c470937756803bc2d6540a9ab20a0c342230/src/lib/html2wt/normalizeDOM.js:668:12)
    at Normalizer.processSubtree (/srv/deployment/parsoid/deploy-cache/revs/9ed8c470937756803bc2d6540a9ab20a0c342230/src/lib/html2wt/normalizeDOM.js:624:12)
    at Normalizer.processNode (/srv/deployment/parsoid/deploy-cache/revs/9ed8c470937756803bc2d6540a9ab20a0c342230/src/lib/html2wt/normalizeDOM.js:675:9)
    at Normalizer.processSubtree (/srv/deployment/parsoid/deploy-cache/revs/9ed8c470937756803bc2d6540a9ab20a0c342230/src/lib/html2wt/normalizeDOM.js:624:12)
    at Normalizer.processNode (/srv/deployment/parsoid/deploy-cache/revs/9ed8c470937756803bc2d6540a9ab20a0c342230/src/lib/html2wt/normalizeDOM.js:675:9)
    at Normalizer.normalizeDOM (/srv/deployment/parsoid/deploy-cache/revs/9ed8c470937756803bc2d6540a9ab20a0c342230/src/lib/html2wt/normalizeDOM.js:696:14)
    at WikitextSerializer.<anonymous> (/srv/deployment/parsoid/deploy-cache/revs/9ed8c470937756803bc2d6540a9ab20a0c342230/src/lib/html2wt/WikitextSerializer.js:1448:26)
    at next (native)
    at tryCatchNext (/srv/deployment/parsoid/deploy-cache/revs/9ed8c470937756803bc2d6540a9ab20a0c342230/node_modules/prfun/lib/index.js:783:28)
    at continuer (/srv/deployment/parsoid/deploy-cache/revs/9ed8c470937756803bc2d6540a9ab20a0c342230/node_modules/prfun/lib/index.js:800:24)
    at callback (/srv/deployment/parsoid/deploy-cache/revs/9ed8c470937756803bc2d6540a9ab20a0c342230/node_modules/prfun/lib/index.js:812:43)
    at /srv/deployment/parsoid/deploy-cache/revs/9ed8c470937756803bc2d6540a9ab20a0c342230/node_modules/prfun/lib/index.js:814:9
    at tryCatch2 (/srv/deployment/parsoid/deploy-cache/revs/9ed8c470937756803bc2d6540a9ab20a0c342230/node_modules/babybird/lib/promise.js:48:12)
    at PrFunPromise.Promise (/srv/deployment/parsoid/deploy-cache/revs/9ed8c470937756803bc2d6540a9ab20a0c342230/node_modules/babybird/lib/promise.js:458:15)
    at new PrFunPromise (/srv/deployment/parsoid/deploy-cache/revs/9ed8c470937756803bc2d6540a9ab20a0c342230/node_modules/prfun/lib/index.js:100:21)

https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2018.11.29/parsoid?id=AWdf5_4VnlBds_JjD6KP&_g=h@44136fa
etc.

Arlolra added a comment.Nov 29 2018, 6:58 PM

Looking at the histogram in logstash, these coincide with yesterday's deploy.

https://www.mediawiki.org/wiki/Parsoid/Deployments#Wednesday,_Nov._28,_2018_around_1:16_pm_PT:_Deployed_18a98af

gerritbot added a comment.Nov 29 2018, 9:29 PM

Change 476752 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] Add 'inserted' diff-marker to the correct node

https://gerrit.wikimedia.org/r/476752

gerritbot added a comment.Nov 29 2018, 9:56 PM

Change 476752 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Add 'inserted' diff-marker to the correct node

https://gerrit.wikimedia.org/r/476752

ssastry closed this task as Resolved.Nov 30 2018, 8:19 PM

Deployed a fix to production about 20 mins back. Resolving. Let us reopen if we see anything else.

Arlolra mentioned this in T322559: Wikimedia\Assert\InvariantException: Invariant failed: Found nested inserted dom-diff flags!.Aug 8 2023, 6:18 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 8 2023, 6:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits