Page MenuHomePhabricator

Checkbox not rendering inside popup widget
Closed, ResolvedPublic

Description

image.png (155×336 px, 17 KB)

The issue is this selector

oo-ui-widget.oo-ui-iconElement .oo-ui-widget .oo-ui-iconElement-icon { display: none; }

One could either try and add child selectors >, or avoid nesting widgets by moving the popup to an overlay.

Event Timeline

Root cause of this is described in T178437, I proposed a patch there half a year ago, but Volker thinks he can fix it differently. Maybe it still merges.

(Moving this from OOUI to VisualEditor, since we have task T178437 for OOUI. This should get fixed when we fix that one.)

(Moving this from OOUI to VisualEditor, since we have task T178437 for OOUI. This should get fixed when we fix that one.)

Do you mean that this is a duplicate of T178437, or that this one needs to be fixed first?

matmarex edited projects, added VisualEditor (Current work); removed VisualEditor.

@Deskana Basically a duplicate, but I think it might be useful to have a separate task for VE for QA purposes, so I kept this open. I'll mark this as done after the OOUI update is released and we actually pull it in.

Vvjjkkii renamed this task from Checkbox not rendering inside popup widget to 2fdaaaaaaa.Jul 1 2018, 1:11 AM
Vvjjkkii reopened this task as Open.
Vvjjkkii removed matmarex as the assignee of this task.
Vvjjkkii triaged this task as High priority.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot renamed this task from 2fdaaaaaaa to Checkbox not rendering inside popup widget.Jul 1 2018, 3:51 PM
CommunityTechBot closed this task as Resolved.
CommunityTechBot assigned this task to matmarex.
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot added a subscriber: Aklapper.