Page MenuHomePhabricator

Using mobile view on Wikisource proofread pages (Tamil; Spanish), clicking an item in edittools/charinsert does not insert the item in the textarea
Closed, ResolvedPublic

Description

Usually at the bottom of proofread edit window there is edit tools. It contains templates. by clicking on the templates, it is added in the edit window. In Tamil wikisource, in the mobile view while clicking on the templates on the edit tools, the template is not inserted into the edit window.

So it is very difficult to insert big templates in the proofread edit in the mobile view version.

Event Timeline

Aklapper changed the task status from Open to Stalled.May 8 2018, 11:01 AM

Hi @Balajijagadesh, thanks for taking the time to report this!
Unfortunately this report lacks some information. If you have time and can still reproduce the problem: Please add a more complete description to this report.
That can be a clear list of specific steps to reproduce the situation, as little details sometimes matter, so that nobody needs to guess how you performed each step, describing actual results and expected results after performing the steps to reproduce, and providing a direct link to a web page where the issue can be seen.
You can edit the task description by clicking Edit Task.
Ideally, exact and clear steps to reproduce should allow any other person to follow these steps (without having to interpret those steps) and see the same results. Problems that others can reliably reproduce can get fixed faster. Thanks!

Aklapper changed the task status from Stalled to Open.May 29 2018, 11:45 AM
Aklapper added projects: CharInsert, Mobile.

@Balajijagadesh : For future reference, please always provide an example link and a comparison.

If I go to https://ta.wikisource.org/wiki/அட்டவணை:நலம்_தரும்_நாட்டு_மருந்துகள்.pdf and choose a red page like https://ta.wikisource.org/wiki/பக்கம்:நலம்_தரும்_நாட்டு_மருந்துகள்.pdf/19 (is that what you mean by "proofread edit window"?) and click "Edit", I assume you refer to "விக்கி நிரல்கள்:" (HTML id: edittools_wikimarkup) at the bottom?

If yes, I go to https://ta.m.wikisource.org/w/index.php?title=பக்கம்:நலம்_தரும்_நாட்டு_மருந்துகள்.pdf/19&action=edit&debug=true and click and item in the "விக்கி நிரல்கள்:" section and it is not inserted in the text edit area.

Can reproduce the same issue on other sites, like https://es.m.wikisource.org/w/index.php?title=P%C3%A1gina:La_ilustraci%C3%B3n_ib%C3%A9rica_tomo_V_1887.djvu/52&action=edit&redlink=1

Aklapper renamed this task from In Mobile view, Inserting templates via edittools is not working in Tamil wikisource proofread page to Using mobile view on Wikisource proofread pages (Tamil; Spanish), clicking an item in edittools/charinsert does not insert the item in the textarea.May 29 2018, 11:46 AM
Vvjjkkii renamed this task from Using mobile view on Wikisource proofread pages (Tamil; Spanish), clicking an item in edittools/charinsert does not insert the item in the textarea to 2edaaaaaaa.Jul 1 2018, 1:12 AM
Vvjjkkii triaged this task as High priority.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed a subscriber: Aklapper.
Bodhisattwa renamed this task from 2edaaaaaaa to Using mobile view on Wikisource proofread pages (Tamil; Spanish), clicking an item in edittools/charinsert does not insert the item in the textarea.Jul 1 2018, 2:58 PM
Bodhisattwa raised the priority of this task from High to Needs Triage.
Bodhisattwa updated the task description. (Show Details)

Change 865805 had a related patch set uploaded (by Bartosz Dziewoński; author: Jdlrobson):

[mediawiki/extensions/CharInsert@master] Add CharInsert modules to editor on mobile domain

https://gerrit.wikimedia.org/r/865805

Change 865805 merged by jenkins-bot:

[mediawiki/extensions/CharInsert@master] Add CharInsert modules to editor on mobile domain

https://gerrit.wikimedia.org/r/865805

matmarex assigned this task to Jdlrobson.
matmarex added subscribers: Jdlrobson, matmarex.

@Jdlrobson proposed this patch while working on another task (T324723), and I realized that it will also resolve this task.

The change will be deployed to Wikimedia wikis next week, per the usual schedule.