Maniphest T194161

Explore card content showing Traditional Chinese when Simplified Chinese is selected
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	RHo
	May 8 2018, 2:11 PM

Tags

Referenced Files

	F18080725: main-MainActivity-05082018153708.png
	May 8 2018, 2:11 PM

Subscribers

Tokens

"Party Time" token, awarded by cooltey.

Description

Steps to Reproduce:

Set app language to Simplified Chinese
Refresh the feed and scroll to a Simplified Chinese trending card

Accept-Language: zh-hans
https://zh.wikipedia.org/api/rest_v1/feed/featured/2018/05/07

Actual Results:

Articles are showing in the Traditional Chinese variant in the feed

main-MainActivity-05082018153708.png (1×1 px, 240 KB)

displaytitle	"復仇者聯盟3：無限之戰"

Expected Results:

Articles show in Simplified Chinese

displaytitle	"复仇者联盟3：无限之战"

Please notice that the display in titles should be also updated

"titles": {
    "canonical": "復仇者聯盟3：無限之戰",
    "normalized": "復仇者聯盟3：無限之戰",
    "display": "复仇者联盟3：无限之战"
 }

Occurring on

Wikipedia 2.7.232-alpha-2018-05-07

Related Objects

Mentioned In: T227092: Utilize the displaytitle returned by /page/summary wherever article titles are displayed
Mentioned Here: T227092: Utilize the displaytitle returned by /page/summary wherever article titles are displayed
T159985: Implement language variant support in the REST API

Event Timeline

RHo created this task.May 8 2018, 2:11 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 8 2018, 2:11 PM

possible duplicate/child of T159985

• Charlotte moved this task from Needs Triage to Bug Backlog on the Wikipedia-Android-App-Backlog board.May 8 2018, 3:49 PM

Shizhao added a project: Chinese-Sites.May 9 2018, 3:26 AM

Shizhao moved this task from Backlog to Extensions/Skins on the Chinese-Sites board.May 9 2018, 3:28 AM

• Vvjjkkii renamed this task from Explore card content showing Traditional Chinese when Simplified Chinese is selected to yddaaaaaaa.Jul 1 2018, 1:11 AM

• Vvjjkkii triaged this task as High priority.

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii removed a subscriber: Aklapper.

CommunityTechBot renamed this task from yddaaaaaaa to Explore card content showing Traditional Chinese when Simplified Chinese is selected.Jul 1 2018, 3:33 PM

CommunityTechBot raised the priority of this task from High to Needs Triage.

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot added a subscriber: Aklapper.

cooltey mentioned this in T227092: Utilize the displaytitle returned by /page/summary wherever article titles are displayed.Aug 28 2019, 8:30 PM

cooltey updated the task description. (Show Details)Aug 28 2019, 8:34 PM

cooltey edited projects, added Product-Infrastructure-Team-Backlog-Deprecated, Page Content Service; removed Android-app-feature-Multilingual.

Restricted Application added a subscriber: Stang. · View Herald TranscriptAug 28 2019, 8:34 PM

Context about updating the ticket: T227092#5444194

cooltey updated the task description. (Show Details)Aug 28 2019, 8:37 PM

• Jhernandez updated the task description. (Show Details)Sep 4 2019, 3:44 PM

LGoto triaged this task as High priority.Sep 4 2019, 3:46 PM

LGoto moved this task from Needs triage to Backlog on the Product-Infrastructure-Team-Backlog-Deprecated board.

Looks like related may not be forwarding the language header to the page/summary endpoint for composing the responses.

• Charlotte moved this task from Bug Backlog to Tracking on the Wikipedia-Android-App-Backlog board.Mar 30 2020, 4:20 PM

• Jhernandez unsubscribed.Apr 2 2020, 6:46 PM

@cooltey can you confirm if this is still happening?

@MSantos Yes, it is still happening.

MSantos edited projects, added Product-Infrastructure-Team-Backlog-Deprecated (Kanban); removed Product-Infrastructure-Team-Backlog-Deprecated.Apr 8 2020, 3:57 PM

MSantos claimed this task.Apr 9 2020, 3:22 PM

MSantos moved this task from To Do to Doing on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.

cooltey awarded a token.Apr 9 2020, 3:31 PM

WIP patch can be seen here: https://github.com/wikimedia/restbase/pull/1256/files.

MSantos moved this task from Doing to Code Review on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Apr 17 2020, 2:45 PM

MSantos moved this task from Code Review to Doing on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.May 11 2020, 5:06 PM

MSantos moved this task from Doing to Blocked on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.May 12 2020, 4:58 PM

@MSantos What is this blocked on?

This is blocked on restbase PR to be reviewed and merged.

Last time restbase CI was broken for some reason, @Pchelolo any thoughts?

If it's waiting for review shouldn't it live in the Code Review column?

@bearND CI is still broken

Ping Platform Engineering for review of https://github.com/wikimedia/restbase/pull/1256.

MSantos moved this task from Blocked to Sign off on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Jun 23 2020, 3:37 PM

Merged and deployed. Please verify it's working, I'm untagging CPT, please retag if something else needed.

Shizhao moved this task from Extensions/Skins to Apps/Tools/Services on the Chinese-Sites board.Jul 6 2020, 1:08 AM

MSantos closed this task as Resolved.Jul 8 2020, 12:14 PM

Shizhao moved this task from Apps/Tools/Services to Closed on the Chinese-Sites board.Jul 9 2020, 1:28 AM

Stang unsubscribed.Nov 13 2021, 8:51 PM