Maniphest T194193

"packed" galleries are jumpy because browser menu bars sliding into view secretly resize the browser viewport
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matmarex
	May 8 2018, 6:34 PM

Description

"packed" galleries are jumpy because browser menu bars sliding into view secretly resize the browser viewport, and every time the browser viewport is resized we recalculate their dimensions.

In this example, I am testing on https://en.wikipedia.org/wiki/Middle_East#Gallery, I press Ctrl+F to open the search bar, and then close it. The gallery jumps back and forth both times. (This is on Opera, but Firefox and Edge do the same thing.)

https://drive.google.com/file/d/14uC6DLy32mK_VJxhc9ZWSgWO0K29GZMO/view?usp=sharing

(the file is too large for Phabricator…)

@Legoktm has had similar issues with mobile browsers when their address bar slides into view:

https://cloud.legoktm.com/index.php/s/tcfnedbgXaE937P

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	mw.page.gallery: Prevent jumpiness due to viewport height changes	mediawiki/core	master	+22 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T88654 Performance review 2015: mediawiki.page.gallery module
		Resolved		matmarex	T194193 "packed" galleries are jumpy because browser menu bars sliding into view secretly resize the browser viewport

Event Timeline

matmarex created this task.May 8 2018, 6:34 PM

Restricted Application added a project: Multimedia. · View Herald TranscriptMay 8 2018, 6:34 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

I think we can do two things to improve this:

Do not recalculate if only window height has changed, but not width
Set a min-height on the gallery element so that content following it does not reflow twice

Change 431822 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] mw.page.gallery: Prevent jumpiness due to viewport height changes

https://gerrit.wikimedia.org/r/431822

gerritbot added a project: Patch-For-Review.May 8 2018, 7:24 PM

matmarex updated the task description. (Show Details)May 8 2018, 7:36 PM

Krinkle added a parent task: T88654: Performance review 2015: mediawiki.page.gallery module.May 9 2018, 4:38 PM

matmarex triaged this task as Medium priority.May 10 2018, 12:48 AM

Change 431822 merged by jenkins-bot:
[mediawiki/core@master] mw.page.gallery: Prevent jumpiness due to viewport height changes

https://gerrit.wikimedia.org/r/431822

matmarex closed this task as Resolved.May 24 2018, 7:34 PM

matmarex removed a project: Patch-For-Review.

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)).May 24 2018, 8:01 PM

• Vvjjkkii renamed this task from "packed" galleries are jumpy because browser menu bars sliding into view secretly resize the browser viewport to 2cdaaaaaaa.Jul 1 2018, 1:11 AM

• Vvjjkkii reopened this task as Open.

• Vvjjkkii removed matmarex as the assignee of this task.

• Vvjjkkii raised the priority of this task from Medium to High.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed subscribers: gerritbot, Aklapper.

• Community_Tech_bot renamed this task from 2cdaaaaaaa to "packed" galleries are jumpy because browser menu bars sliding into view secretly resize the browser viewport.Jul 1 2018, 6:14 AM

• Community_Tech_bot closed this task as Resolved.

• Community_Tech_bot assigned this task to matmarex.

• Community_Tech_bot updated the task description. (Show Details)