Page MenuHomePhabricator

SelectFileWidget file input doesn't present a dedicated label
Closed, ResolvedPublic

Description

Another small idea, with big impact:
Instead of adding a label element to SelectFileWidget and hiding it at high code complexity, let's just transform the ButtonElement span wrapper around the file input into a label.

Originated in T94749#4192648.

Event Timeline

Volker_E created this task.

Change 432002 had a related patch set uploaded (by VolkerE; owner: Mooeypoo):
[oojs/ui@master] SelectFileWidget: Use <label> for select button

https://gerrit.wikimedia.org/r/432002

Volker_E edited projects, added OOUI (OOUI-0.27.0); removed OOUI.

Change 432002 merged by jenkins-bot:
[oojs/ui@master] SelectFileWidget: Use <label> for select ButtonElement

https://gerrit.wikimedia.org/r/432002

Volker_E claimed this task.
Volker_E removed a project: Patch-For-Review.
Vvjjkkii renamed this task from SelectFileWidget file input doesn't present a dedicated label to 8bdaaaaaaa.Jul 1 2018, 1:11 AM
Vvjjkkii reopened this task as Open.
Vvjjkkii removed Volker_E as the assignee of this task.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed subscribers: Aklapper, gerritbot.
CommunityTechBot renamed this task from 8bdaaaaaaa to SelectFileWidget file input doesn't present a dedicated label.Jul 2 2018, 1:51 PM
CommunityTechBot closed this task as Resolved.
CommunityTechBot assigned this task to Volker_E.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot added subscribers: Aklapper, gerritbot.