Page MenuHomePhabricator
Create Task
Maniphest T194297

Make wp10 rows be a squeezed to a weighted sum in ores_classification
Closed, ResolvedPublic
Actions

Description

If we deploy wp10 storage, it will take lots of space and also lots of work as each class will take one row per revision, SP team decided to keep a squeezed version of it in the database that is called weighted sum and we used it before too. See this mock: https://gist.github.com/halfak/b925a2d45a3903a3e10dc5d6cd7c01b1

Details

SubjectRepoBranchLines +/-
Make ScoreParser aggregate wp10 predictionsmediawiki/extensions/ORESmaster+11 -3
Make aggregation of score results possible so they take less rowsmediawiki/extensions/ORESmaster+128 -10
Customize query in gerrit

Related Objects
Search...

Event Timeline

Ladsgroup created this task.May 9 2018, 6:37 PM
gerritbot added a comment.May 23 2018, 1:08 PM

Change 434689 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/ORES@master] Make squeezing of score results possible so they take less rows

https://gerrit.wikimedia.org/r/434689

gerritbot added a project: Patch-For-Review.May 23 2018, 1:08 PM
Ladsgroup moved this task from Parked to Review on the Machine-Learning-Team (Active Tasks) board.May 23 2018, 1:09 PM
Halfak added a comment.May 25 2018, 3:58 PM

I like this, but I think we should use the term "aggregate" rather than "squeeze".

Halfak added a comment.May 25 2018, 4:05 PM

It seems that this metaphor works for damaging and goodfaith too. There, we want to aggregate two probabilities into one row.

E.g. a "class_selector(true)" aggregator would turn {"probability": {"true": 0.95, "false": 0.05}} into damaging 0.95

Similarly a "weighted_sum(weights)" aggregator would turn {"probability": {"Stub": 0.34, ..., "FA": 0.01}} into weighted_sum 1.67

Ladsgroup mentioned this in T166427: Measure maturity/quality of Wikidata items in a way it can be queried.May 28 2018, 4:49 AM
Ladsgroup added a comment.May 28 2018, 5:27 AM
In T194297#4231945, @Halfak wrote:

It seems that this metaphor works for damaging and goodfaith too. There, we want to aggregate two probabilities into one row.

E.g. a "class_selector(true)" aggregator would turn {"probability": {"true": 0.95, "false": 0.05}} into damaging 0.95

Similarly a "weighted_sum(weights)" aggregator would turn {"probability": {"Stub": 0.34, ..., "FA": 0.01}} into weighted_sum 1.67

We already store one row for damaging classes because you can get the other one by subtracting from 1

Lydia_Pintscher subscribed.May 28 2018, 12:03 PM
Halfak added a comment.May 29 2018, 5:08 PM

Right. I guess what I was getting at is that storing one row is already a form of aggregation (selection).

awight moved this task from Review to Pending deployment on the Machine-Learning-Team (Active Tasks) board.Jun 4 2018, 11:07 AM
gerritbot added a comment.Jun 4 2018, 11:08 AM

Change 434689 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Make aggregation of score results possible so they take less rows

https://gerrit.wikimedia.org/r/434689

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)).Jun 4 2018, 12:01 PM
gerritbot added a comment.Jun 4 2018, 6:28 PM

Change 437295 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/ORES@master] Make ScoreParser aggregate wp10 predictions

https://gerrit.wikimedia.org/r/437295

gerritbot added a comment.Jun 4 2018, 10:41 PM

Change 437295 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Make ScoreParser aggregate wp10 predictions

https://gerrit.wikimedia.org/r/437295

Halfak moved this task from Pending deployment to Completed on the Machine-Learning-Team (Active Tasks) board.Jun 18 2018, 1:41 PM
• Vvjjkkii renamed this task from Make wp10 rows be a squeezed to a weighted sum in ores_classification to 69caaaaaaa.Jul 1 2018, 1:10 AM
• Vvjjkkii removed Ladsgroup as the assignee of this task.
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed subscribers: Aklapper, gerritbot.
CommunityTechBot updated the task description. (Show Details)Jul 1 2018, 2:51 PM
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added subscribers: Aklapper, gerritbot.
Vachovec1 renamed this task from 69caaaaaaa to Make wp10 rows be a squeezed to a weighted sum in ores_classification.Jul 1 2018, 3:44 PM
Vachovec1 raised the priority of this task from High to Needs Triage.
CommunityTechBot assigned this task to Ladsgroup.Jul 3 2018, 2:30 AM
Halfak added a comment.Oct 9 2018, 7:12 PM

Looks like this is done.

Ladsgroup closed this task as Resolved.Nov 1 2018, 7:59 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL