Page MenuHomePhabricator

The interface direction of the Lemma is based on direction of the user interface and not the Lemma's language
Open, MediumPublic

Description

Problem:
When we have a Lemma in Persian language which is a RTL language and we see it from German interface we'll get:


This is clearly wrong, similarly for LTR lemmas in RTL interfaces:

BDD
GIVEN
AND
WHEN
AND
THEN
AND

Acceptance criteria:

Event Timeline

Ladsgroup created this task.May 9 2018, 8:58 PM
Restricted Application added a project: I18n. · View Herald TranscriptMay 9 2018, 8:58 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Lydia_Pintscher triaged this task as Medium priority.May 27 2018, 4:11 PM
Vvjjkkii renamed this task from The lemma interface direction is based on direction of the user interface and not lemma's language to s9caaaaaaa.Jul 1 2018, 1:11 AM
Vvjjkkii raised the priority of this task from Medium to High.
Vvjjkkii updated the task description. (Show Details)
Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot renamed this task from s9caaaaaaa to The lemma interface direction is based on direction of the user interface and not lemma's language.Jul 1 2018, 3:40 PM
CommunityTechBot raised the priority of this task from High to Needs Triage.
CommunityTechBot updated the task description. (Show Details)
CommunityTechBot added a subscriber: Aklapper.
CommunityTechBot triaged this task as Medium priority.Jul 3 2018, 2:20 AM

Can you post 1 or 2 links to a real not working example on Wikidata?

Lydia_Pintscher added a comment.EditedJul 13 2018, 4:56 PM

Also a mockup/screenshot/... of how it should look would be super useful. (/me fails @ rtl -.-)

Honestly, Defining how it should look is hard, the Lemma text should have interface-independent direction and the vertical bar should be put in the right place. Practically, They need to get very close to the edit button.

Restricted Application added a project: Design. · View Herald TranscriptSep 2 2018, 3:35 PM
Lydia_Pintscher lowered the priority of this task from High to Medium.Sep 2 2018, 3:37 PM
Lydia_Pintscher renamed this task from The lemma interface direction is based on direction of the user interface and not lemma's language to The interface direction of the Lemma is based on direction of the user interface and not the Lemma's language.Sep 2 2018, 4:46 PM

A design/tech suggestion: Define the "box" the lemma is in as wide as possible inside the UI (which follows UI-aligment). Inside this box, align content according to the appropriate alignment for the language it content is in.

This applies to every form, not just the title at the top.

The HTML elements already have the lang attribute, but not the dir attribute for some reason. Every element to which the lang attribute is applied, must have the dir attribute, too. Here's an example:

Taken from https://www.wikidata.org/wiki/Lexeme:L205750?uselang=en

The Hebrew word must have the exclamation mark on the left-hand end, but because the element doesn't have the dir attribute and the UI language is English, it's shown on the right-hand end.

This would also be an issue with certain CJK Unicode characters, since their rendering and stroke order may vary between languages.