Maniphest T194314

Summary endpoint doesn't scrub parenetheticals at start of input
Closed, DeclinedPublic
Actions

Assigned To

None

Authored By

	Jdlrobson
	May 9 2018, 9:20 PM

Description

https://en.wikipedia.beta.wmflabs.org/wiki/Page_previews_test_() has the wikitext:

(this text should be invisible) No other text should appear before or after this sentence （this should be invisible too）

Summary obtained via:
https://en.wikipedia.beta.wmflabs.org/api/rest_v1/page/summary/Page_previews_test_()

Expected:
Summary should be

<p>No other text should appear before or after this sentence</p>

Actual:

<p>(this text should be invisible) No other text should appear before or after this sentence</p>

Related Objects

Mentioned In: T173952: Remove A/B testing instrumentation code

Event Timeline

Jdlrobson created this task.May 9 2018, 9:20 PM

Restricted Application added a project: Product-Infrastructure-Team-Backlog-Deprecated. · View Herald TranscriptMay 9 2018, 9:20 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Jdlrobson mentioned this in T173952: Remove A/B testing instrumentation code.May 9 2018, 9:22 PM

Does this actually happen on real pages?

LGoto moved this task from Needs triage to Needs investigation on the Product-Infrastructure-Team-Backlog-Deprecated board.May 11 2018, 7:52 PM

I don't know but probably not. That said I'd recommend investigating the issue in case it impacts other situations which are more common (and document it as expected behaviour in the test if it's too difficult to fix given the tests are effectively the spec for how this should work). I assume it's a minor issue with the regex we're using so should be easy to fix.

Krinkle moved this task from Incoming to Summary on the Mobile-Content-Service board.Jun 6 2018, 2:10 AM

• Vvjjkkii renamed this task from Summary endpoint doesn't scrub parenetheticals at start of input to p9caaaaaaa.Jul 1 2018, 1:10 AM

• Vvjjkkii triaged this task as High priority.

• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed a subscriber: Aklapper.

CommunityTechBot renamed this task from p9caaaaaaa to Summary endpoint doesn't scrub parenetheticals at start of input.Jul 1 2018, 2:43 PM

CommunityTechBot raised the priority of this task from High to Needs Triage.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot added a subscriber: Aklapper.

Declining for now. We need real content issues if we are to tackle this.

Summary endpoint doesn't scrub parenetheticals at start of inputClosed, DeclinedPublicActions

Description

Related Objects

Event Timeline

Summary endpoint doesn't scrub parenetheticals at start of input
Closed, DeclinedPublic
Actions