Page MenuHomePhabricator
Create Task
Maniphest T194317

Support Amazon payments initiated off paymentswiki
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

When we get an Amazon payment and don't have a pending message, let's use their API to look up donor details.

We need this to accept payments via Alexa.

Details

SubjectRepoBranchLines +/-
Amazon audit: donations without log data go to jobs-amazonwikimedia/fundraising/crmmaster+24 -0
Amazon audit: fix IDs for donations started off-wikiwikimedia/fundraising/SmashPigmaster+39 -3
Don't stop action chain if CloseOrderReference failswikimedia/fundraising/SmashPigmaster+2 -2
Send Amazon capture messages to jobs-amazonwikimedia/fundraising/SmashPigmaster+95 -63
Amazon RecordPaymentJobwikimedia/fundraising/SmashPigmaster+350 -2
Customize query in gerrit

Event Timeline

Ejegg created this task.May 9 2018, 9:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 9 2018, 9:48 PM
Ejegg added a comment.May 10 2018, 2:08 AM

So this is an opportunity to make the Amazon flow more like the Adyen flow, where we combine the donor details from the pending DB in a separate job before sending the data to the donations queue. The Amazon version of the RecordCapture job should first look in the pending DB, then if the details aren't there, ask Amazon.

To ask Amazon, call getOrderReferenceDetails with amazon_order_reference_id set to the amazon-side ID, then use the details in the response
$getDetailsResult['GetOrderReferenceDetailsResult']['OrderReferenceDetails']['Buyer'] has properties 'Email' and 'Name'. We have to split first_name and last_name out of the name field.

• DStrine moved this task from Triage to Sprint +1 on the Fundraising-Backlog board.May 14 2018, 7:40 PM
• Vvjjkkii renamed this task from Support Amazon payments initiated off paymentswiki to m9caaaaaaa.Jul 1 2018, 1:11 AM
• Vvjjkkii triaged this task as High priority.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed a subscriber: Aklapper.
CommunityTechBot updated the task description. (Show Details)Jul 1 2018, 2:40 PM
CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
CommunityTechBot added a subscriber: Aklapper.
Vachovec1 renamed this task from m9caaaaaaa to Support Amazon payments initiated off paymentswiki.Jul 1 2018, 3:37 PM
Vachovec1 raised the priority of this task from High to Needs Triage.
• DStrine moved this task from Sprint +1 to Current Sprint on the Fundraising-Backlog board.Sep 13 2018, 4:55 PM
• DStrine added projects: Fundraising Sprint Raw data can give you salmonella, Unplanned-Sprint-Work.
gerritbot subscribed.Sep 14 2018, 4:12 AM

Change 460468 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/SmashPig@master] WIP Amazon RecordPaymentJob

https://gerrit.wikimedia.org/r/460468

gerritbot added a project: Patch-For-Review.Sep 14 2018, 4:12 AM
Ejegg claimed this task.Sep 14 2018, 4:15 AM
Ejegg triaged this task as High priority.
Ejegg set the point value for this task to 2.
Ejegg moved this task from Backlog to Doing on the Fundraising Sprint Raw data can give you salmonella board.
• DStrine added a project: Fundraising Sprint Sasquatches can't find us either.Sep 18 2018, 8:37 PM
Ejegg moved this task from Backlog to Doing on the Fundraising Sprint Sasquatches can't find us either board.Sep 19 2018, 3:59 AM
gerritbot added a comment.Sep 21 2018, 12:14 AM

Change 461830 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/SmashPig@master] Don't stop action chain if CloseOrderReference fails

https://gerrit.wikimedia.org/r/461830

gerritbot added a comment.Sep 21 2018, 12:42 AM

Change 461833 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/SmashPig@master] WIP send Amazon capture messages to jobs-amazon

https://gerrit.wikimedia.org/r/461833

gerritbot added a comment.Sep 21 2018, 11:24 PM

Change 460468 merged by jenkins-bot:
[wikimedia/fundraising/SmashPig@master] Amazon RecordPaymentJob

https://gerrit.wikimedia.org/r/460468

Ejegg moved this task from Doing to Review on the Fundraising Sprint Sasquatches can't find us either board.Sep 22 2018, 2:44 AM
gerritbot added a comment.Sep 24 2018, 3:24 PM

Change 461833 merged by jenkins-bot:
[wikimedia/fundraising/SmashPig@master] Send Amazon capture messages to jobs-amazon

https://gerrit.wikimedia.org/r/461833

gerritbot added a comment.Sep 24 2018, 3:29 PM

Change 461830 merged by Ejegg:
[wikimedia/fundraising/SmashPig@master] Don't stop action chain if CloseOrderReference fails

https://gerrit.wikimedia.org/r/461830

Ejegg moved this task from Review to Done on the Fundraising Sprint Sasquatches can't find us either board.Sep 24 2018, 8:26 PM
gerritbot added a comment.Sep 28 2018, 4:37 PM

Change 463508 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/SmashPig@master] Amazon audit: fix IDs for donations started off-wiki

https://gerrit.wikimedia.org/r/463508

Ejegg moved this task from Done to Review on the Fundraising Sprint Sasquatches can't find us either board.Sep 28 2018, 8:37 PM
gerritbot added a comment.Oct 1 2018, 10:38 PM

Change 463508 merged by jenkins-bot:
[wikimedia/fundraising/SmashPig@master] Amazon audit: fix IDs for donations started off-wiki

https://gerrit.wikimedia.org/r/463508

gerritbot added a comment.Oct 2 2018, 1:40 AM

Change 463882 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/crm@master] Amazon audit: donations without log data go to jobs-amazon

https://gerrit.wikimedia.org/r/463882

• DStrine added a project: Fundraising Sprint They Live.Oct 2 2018, 8:12 PM
Ejegg moved this task from Backlog to Review on the Fundraising Sprint They Live board.Oct 2 2018, 10:09 PM
gerritbot added a comment.Oct 4 2018, 8:41 PM

Change 463882 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Amazon audit: donations without log data go to jobs-amazon

https://gerrit.wikimedia.org/r/463882

Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint They Live board.Oct 4 2018, 8:46 PM
Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint They Live board.Oct 4 2018, 11:32 PM
Ejegg closed this task as Resolved.Oct 16 2018, 8:17 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL